From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 98D22CA6E for ; Sat, 27 Jun 2015 04:39:28 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 26 Jun 2015 19:39:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,687,1427785200"; d="scan'208";a="751336914" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by fmsmga002.fm.intel.com with ESMTP; 26 Jun 2015 19:39:28 -0700 Received: from orsmsx155.amr.corp.intel.com (10.22.240.21) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.224.2; Fri, 26 Jun 2015 19:39:27 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by ORSMSX155.amr.corp.intel.com (10.22.240.21) with Microsoft SMTP Server (TLS) id 14.3.224.2; Fri, 26 Jun 2015 19:39:27 -0700 Received: from FMSMSX110.amr.corp.intel.com ([169.254.14.199]) by fmsmsx120.amr.corp.intel.com ([169.254.15.219]) with mapi id 14.03.0224.002; Fri, 26 Jun 2015 19:39:26 -0700 From: "Wang, Liang-min" To: Stephen Hemminger Thread-Topic: [dpdk-dev] [PATCH v9 2/5] ixgbe: add ops to support ethtool ops Thread-Index: AQHQsHdNltaETzYkh0W6/WEMw2fQ3p3ABxyA//+cbFA= Date: Sat, 27 Jun 2015 02:39:26 +0000 Message-ID: References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com> <1435367948-20240-1-git-send-email-liang-min.wang@intel.com> <1435367948-20240-3-git-send-email-liang-min.wang@intel.com> <20150626183403.6a3dc4fb@urahara> In-Reply-To: <20150626183403.6a3dc4fb@urahara> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.200.107] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v9 2/5] ixgbe: add ops to support ethtool ops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Jun 2015 02:39:29 -0000 > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Friday, June 26, 2015 9:34 PM > To: Wang, Liang-min > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v9 2/5] ixgbe: add ops to support ethtool = ops >=20 > On Fri, 26 Jun 2015 21:19:05 -0400 > Liang-Min Larry Wang wrote: >=20 > > + reg_group =3D reg_set[g_ind++]; > > + while (reg_group) { > > + count +=3D ixgbe_regs_group_count(reg_group); > > + reg_group =3D reg_set[g_ind++]; > > + } >=20 > I don't care what checkpatch says, this an example of a loop > which reads better as: >=20 > while ((reg_group =3D reg_set[g_ind++])) > count +=3D ixgbe_regs_group_count(reg_group); There is no specific guideline on which to follow besides running checkpatc= h. Maybe this type of exception should be listed on dpdk web-link. This suggestion is taken on v10.