From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 550645A7A for ; Wed, 15 Jul 2015 12:15:48 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 15 Jul 2015 03:15:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,479,1432623600"; d="scan'208";a="729265887" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by orsmga001.jf.intel.com with ESMTP; 15 Jul 2015 03:15:47 -0700 Received: from orsmsx116.amr.corp.intel.com (10.22.240.14) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.224.2; Wed, 15 Jul 2015 03:15:46 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by ORSMSX116.amr.corp.intel.com (10.22.240.14) with Microsoft SMTP Server (TLS) id 14.3.224.2; Wed, 15 Jul 2015 03:15:46 -0700 Received: from FMSMSX110.amr.corp.intel.com ([169.254.14.199]) by FMSMSX113.amr.corp.intel.com ([169.254.13.28]) with mapi id 14.03.0224.002; Wed, 15 Jul 2015 03:15:46 -0700 From: "Wang, Liang-min" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v16 0/6] User-space Ethtool Thread-Index: AQHQvjawpA9cMW7Twk6UPbc0EszA9J3b3B6A//+WKPCAAQuugP//0a8A Date: Wed, 15 Jul 2015 10:15:45 +0000 Message-ID: References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com> <3613205.a925kSz8Fg@xps13> <10500550.BxuzPEpZpz@xps13> In-Reply-To: <10500550.BxuzPEpZpz@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.200.107] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v16 0/6] User-space Ethtool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jul 2015 10:15:48 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, July 15, 2015 1:53 AM > To: Wang, Liang-min > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v16 0/6] User-space Ethtool >=20 > 2015-07-14 20:56, Wang, Liang-min: > > Thomas, > > The mac_addr_set is needed for ethtool net-op as described in > > examples/ethtool-ethtool/lib/rte_ethtool.c > (rte_ethtool_net_set/get_mac_addr). >=20 > That's why it should be the first patch of this series. > You probably misread "another patch" which means different patch in same > series. >=20 That's why this API and rest of API's added into librte_ether are all prepa= red in the same patch: 001. I'm confused on your comment here. Are you asking me to break the patch 001= into two patches in the same series? Meaning 001 and 002, would that be more confusing? > > Could you use the v15 for the release? >=20 > No, there are more comments. >=20 >=20 > > > -----Original Message----- > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > Sent: Tuesday, July 14, 2015 4:14 PM > > > To: Wang, Liang-min > > > Cc: dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH v16 0/6] User-space Ethtool > > > > > > 2015-07-14 09:11, Liang-Min Larry Wang: > > > > v16 changes: > > > > - Re-do patch v15 and separate changes between v15 and v14 into > patch > > > files 005 and 006 > > > > > > No, you misunderstood the need. > > > You must merge your fixes in appropriate patches. > > > But you must separate the mac_addr_set feature in another patch as it= is > > > not related to ethtool dumps. > > > > > > You are winning the record of patch iterations :) >=20