From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id E0B7F5A51 for ; Fri, 17 Jul 2015 00:15:02 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 16 Jul 2015 15:15:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,491,1432623600"; d="scan'208";a="765966600" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by orsmga002.jf.intel.com with ESMTP; 16 Jul 2015 15:15:02 -0700 Received: from fmsmsx108.amr.corp.intel.com (10.18.124.206) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.224.2; Thu, 16 Jul 2015 15:15:01 -0700 Received: from FMSMSX110.amr.corp.intel.com ([169.254.14.199]) by FMSMSX108.amr.corp.intel.com ([10.18.124.206]) with mapi id 14.03.0224.002; Thu, 16 Jul 2015 15:15:01 -0700 From: "Wang, Liang-min" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v17 0/5] User-space Ethtool Thread-Index: AQHQv8ruj6lPzWBLp0OC7z6p5aI9dJ3fF/AA//+MRLCAAHmYgP//i3Ew Date: Thu, 16 Jul 2015 22:15:01 +0000 Message-ID: References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com> <3483104.M20H0g0coM@xps13> <1922905.J0eqSKxbIu@xps13> In-Reply-To: <1922905.J0eqSKxbIu@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.200.106] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v17 0/5] User-space Ethtool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jul 2015 22:15:03 -0000 Thomas, Thanks for clarification. Our next step is to create hooks on virtio and v= mxnet3 and other ethtool op. Thanks again for making prompt reply as I am aware it's very late in your t= ime zone. Larry > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Thursday, July 16, 2015 6:09 PM > To: Wang, Liang-min > Cc: dev@dpdk.org; O'Driscoll, Tim > Subject: Re: [dpdk-dev] [PATCH v17 0/5] User-space Ethtool >=20 > 2015-07-16 21:55, Wang, Liang-min: > > Thomas, > > Do you want me to create a separate patch just include the > example/l2fwd-ethtool? >=20 > Yes >=20 > > Do you also mean besides the identified Makefiles, you see more > rework needs to be done, > > or I just need to fix Makefile issue? If just Makefile issue, I could = try > to make another attempt tomorrow? >=20 > After checking the build there is probably more review to do. > Let's take more time to have something clean and maybe more complete in > 2.2. > This patchset is your first contribution to DPDK and is already a nice > achievement. > The new API must now be implemented in more drivers to be effective. >=20 >=20 > > > -----Original Message----- > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > Sent: Thursday, July 16, 2015 5:48 PM > > > To: Wang, Liang-min > > > Cc: dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH v17 0/5] User-space Ethtool > > > > > > 2015-07-16 09:25, Liang-Min Larry Wang: > > > > This implementation is designed to provide a familar interface for > > > applications that rely on kernel-space driver to support ethtool_op a= nd > > > net_device_op for device management. The initial implementation > focuses > > > on ops that can be implemented through existing netdev APIs. More ops > will > > > be supported in latter release. > > > > > > Applied without example which needs more work, thanks >=20