From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <liang-min.wang@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id BF14F3979
 for <dev@dpdk.org>; Fri, 20 Nov 2015 17:33:02 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga102.jf.intel.com with ESMTP; 20 Nov 2015 08:32:45 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,323,1444719600"; d="scan'208";a="825335058"
Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204])
 by orsmga001.jf.intel.com with ESMTP; 20 Nov 2015 08:32:45 -0800
Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by
 FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Fri, 20 Nov 2015 08:32:44 -0800
Received: from FMSMSX110.amr.corp.intel.com ([169.254.14.96]) by
 fmsmsx117.amr.corp.intel.com ([169.254.3.91]) with mapi id 14.03.0248.002;
 Fri, 20 Nov 2015 08:32:44 -0800
From: "Wang, Liang-min" <liang-min.wang@intel.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v9 1/3] Remove ABI requirement for external
 library builds.
Thread-Index: AQHRI6lI27Ftahc7DE6olR25IIBikJ6lGZTggAAA6pA=
Date: Fri, 20 Nov 2015 16:32:43 +0000
Message-ID: <B6CB929FEBC10D4FAC4BCA7EF2298E257904ED2B@FMSMSX110.amr.corp.intel.com>
References: <1448033697-32613-1-git-send-email-remy.horton@intel.com>
 <1448033697-32613-2-git-send-email-remy.horton@intel.com>
 <2601191342CEEE43887BDE71AB97725836ACAB5A@irsmsx105.ger.corp.intel.com>
In-Reply-To: <2601191342CEEE43887BDE71AB97725836ACAB5A@irsmsx105.ger.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.1.200.108]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v9 1/3] Remove ABI requirement for
	external	library builds.
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Nov 2015 16:33:03 -0000


> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Remy Horton
> Sent: Friday, November 20, 2015 3:35 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v9 1/3] Remove ABI requirement for external
> library builds.
>=20
> Signed-off-by: Andrew G. Harvey <agh@cisco.com>
> ---
>  mk/rte.extlib.mk | 2 ++
>  mk/rte.lib.mk    | 6 ++++++
>  2 files changed, 8 insertions(+)
>=20
> diff --git a/mk/rte.extlib.mk b/mk/rte.extlib.mk
> index ba066bc..4d459e4 100644
> --- a/mk/rte.extlib.mk
> +++ b/mk/rte.extlib.mk
> @@ -31,6 +31,8 @@
>=20
>  MAKEFLAGS +=3D --no-print-directory
>=20
> +EXTLIB_BUILD :=3D 1
> +
>  # we must create the output dir first and recall the same Makefile
>  # from this directory
>  ifeq ($(NOT_FIRST_CALL),)
> diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk
> index fcc8e20..7262b02 100644
> --- a/mk/rte.lib.mk
> +++ b/mk/rte.lib.mk
> @@ -40,11 +40,13 @@ VPATH +=3D $(SRCDIR)
>=20
>  ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)
>  LIB :=3D $(patsubst %.a,%.so.$(LIBABIVER),$(LIB))
> +ifndef EXTLIB_BUILD
>  ifeq ($(CONFIG_RTE_NEXT_ABI),y)
>  LIB :=3D $(LIB).1
>  endif
>  CPU_LDFLAGS +=3D --version-script=3D$(SRCDIR)/$(EXPORT_MAP)
>  endif
> +endif
>=20
>=20
>  _BUILD =3D $(LIB)
> @@ -174,12 +176,16 @@ $(RTE_OUTPUT)/lib/$(LIB): $(LIB)
>  	@[ -d $(RTE_OUTPUT)/lib ] || mkdir -p $(RTE_OUTPUT)/lib
>  	$(Q)cp -f $(LIB) $(RTE_OUTPUT)/lib
>  ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)
> +ifdef EXTLIB_BUILD
> +	$(Q)ln -s -f $< $(basename $@)
> +else
>  ifeq ($(CONFIG_RTE_NEXT_ABI),y)
>  	$(Q)ln -s -f $< $(basename $(basename $@))
>  else
>  	$(Q)ln -s -f $< $(basename $@)
>  endif
>  endif
> +endif
>=20
>  #
>  # Clean all generated files
> --
> 1.9.3
ACK this patch as it has been reviewed.