From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id B7690201 for ; Tue, 21 Nov 2017 03:17:58 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Nov 2017 18:17:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,431,1505804400"; d="scan'208";a="4626929" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga003.jf.intel.com with ESMTP; 20 Nov 2017 18:17:57 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 20 Nov 2017 18:17:56 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.175]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.218]) with mapi id 14.03.0319.002; Tue, 21 Nov 2017 10:17:54 +0800 From: "Wu, Yanglong" To: "Ananyev, Konstantin" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v4] net/ixgbe: fix l3fwd start failed on PF Thread-Index: AQHTYaj0QnYVnwx69kaBXZTORoDa/KMcj2aAgAF9/zA= Date: Tue, 21 Nov 2017 02:17:54 +0000 Message-ID: References: <20171120022951.151510-1-yanglong.wu@intel.com> <20171120024026.152048-1-yanglong.wu@intel.com> <2601191342CEEE43887BDE71AB9772585FABEAA2@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB9772585FABEAA2@irsmsx105.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjcyMGJjNTAtZTBhZS00MDBjLWFlMTMtZDE0MzNjZDQzZGIwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Imt0ak1GN0Vjb2FHNUlnNFJiancrYzYxY3dJbnR1UWF2VU54RlQ5VEFMSnc9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix l3fwd start failed on PF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 02:17:59 -0000 Hi, Yes, I think so, we can change it. nb_rx_q just means the number of queue u= sed for a port and RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool means max queue can= be used. -----Original Message----- From: Ananyev, Konstantin=20 Sent: Monday, November 20, 2017 6:44 PM To: Wu, Yanglong ; dev@dpdk.org Cc: Wu, Yanglong Subject: RE: [dpdk-dev] [PATCH v4] net/ixgbe: fix l3fwd start failed on PF > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yanglong Wu > Sent: Monday, November 20, 2017 2:40 AM > To: dev@dpdk.org > Cc: Wu, Yanglong > Subject: [dpdk-dev] [PATCH v4] net/ixgbe: fix l3fwd start failed on PF >=20 > L3fwd start failed on PF, for tx_q check failed. > That occurred when the SRIOV is active and tx_q > rx_q. > The tx_q is equal to nb_q_per_pool. The number of nb_q_per_pool should=20 > equeal to max number of queues supported by HW not nb_rx_q. >=20 > Fixes: 27b609cbd1c6 (ethdev: move the multi-queue mode check to=20 > specific drivers) >=20 > Signed-off-by: Yanglong Wu > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c=20 > b/drivers/net/ixgbe/ixgbe_ethdev.c > index ae9c44421..0f0641da1 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -2180,7 +2180,7 @@ ixgbe_check_vf_rss_rxq_num(struct rte_eth_dev *dev,= uint16_t nb_rx_q) > return -EINVAL; > } >=20 > - RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool =3D nb_rx_q; > + RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool =3D 128 /=20 > +RTE_ETH_DEV_SRIOV(dev).active; Please use appropriate macros instead of constants (s/128/IXGBE_MAX_RX_QUEU= E_NUM). > RTE_ETH_DEV_SRIOV(dev).def_pool_q_idx =3D pci_dev->max_vfs * nb_rx_q; Shouldn't we also change that line to: RTE_ETH_DEV_SRIOV(dev).def_pool_q_idx =3D pci_dev->max_vfs * RTE_ETH_DEV_SR= IOV(dev).nb_q_per_pool; ? Konstantin >=20 > return 0; > -- > 2.11.0