From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id D6F62160 for ; Mon, 5 Feb 2018 08:37:04 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Feb 2018 23:37:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,463,1511856000"; d="scan'208";a="15325444" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga007.fm.intel.com with ESMTP; 04 Feb 2018 23:37:02 -0800 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 4 Feb 2018 23:37:02 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 4 Feb 2018 23:37:02 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.124]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.130]) with mapi id 14.03.0319.002; Mon, 5 Feb 2018 15:37:00 +0800 From: "Wu, Yanglong" To: Shahaf Shuler , "dev@dpdk.org" CC: "Lu, Wenzhuo" Thread-Topic: [PATCH v2] app/testpmd:vlan filter fail Thread-Index: AQHTnioad19kfajoY0OyIVyNO4X1pKOUzqYAgACdFIA= Date: Mon, 5 Feb 2018 07:36:59 +0000 Message-ID: References: <20180202050950.64400-1-yanglong.wu@intel.com> <20180205023357.104418-1-yanglong.wu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTQ4NmMyYWUtODU3OS00YWMyLTliZWItNDQzNTJmMTdjNmZhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkEydFh2UDFDNkFtc0k4aWlCZTJHWUUxaW1SVW53SWo1anpheGxqZHU1WEU9In0= x-ctpclassification: CTP_NT x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd:vlan filter fail X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2018 07:37:05 -0000 Thx! I will change it right now -----Original Message----- From: Shahaf Shuler [mailto:shahafs@mellanox.com]=20 Sent: Monday, February 5, 2018 2:14 PM To: Wu, Yanglong ; dev@dpdk.org Cc: Lu, Wenzhuo Subject: RE: [PATCH v2] app/testpmd:vlan filter fail Hi Wu, Few small comment.=20 Monday, February 5, 2018 4:34 AM, Yanglong Wu: > Subject: [PATCH v2] app/testpmd:vlan filter fail The commit title can better describe the patch, something like: "app/testpm= d: fix port DCB configuration" >=20 > This bug is caused by miss port configuration. The above line is not needed.=20 > The port_conf for the DCB configuration should inherit the same=20 > configuration of the port. >=20 > Fix:0074d02fc(convert to new Rx offloads API) It needs to be : Fixes: 0074d02fca21 ("app/testpmd: convert to new Rx offloads API") > Signed-off-by: Yanglong Wu > --- > v2: > changing patch accoding to the review > --- > app/test-pmd/testpmd.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index=20 > 5dc8ccac5..da1d9bd3a 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -2324,6 +2324,9 @@ init_port_dcb_config(portid_t pid, > /* Enter DCB configuration status */ > dcb_config =3D 1; >=20 > + port_conf.rxmode =3D rte_port->dev_conf.rxmode; > + port_conf.txmode =3D rte_port->dev_conf.txmode; > + > /*set configuration of DCB in vt mode and DCB in non-vt mode*/ > retval =3D get_eth_dcb_conf(&port_conf, dcb_mode, num_tcs, pfc_en); > if (retval < 0) > -- Otherwise - Acked-by: Shahaf Shuler > 2.11.0