From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 6AD775921 for ; Fri, 27 Nov 2015 06:38:17 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP; 26 Nov 2015 21:38:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,350,1444719600"; d="scan'208";a="847991304" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga001.fm.intel.com with ESMTP; 26 Nov 2015 21:38:16 -0800 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 26 Nov 2015 21:38:15 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 26 Nov 2015 21:38:15 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.83]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.88]) with mapi id 14.03.0248.002; Fri, 27 Nov 2015 13:38:14 +0800 From: "Wang, Xiao W" To: "Chen, Jing D" , "dev@dpdk.org" Thread-Topic: [PATCH] fm10k: fix wrong Rx func is used Thread-Index: AQHRKLbA/6a3rYxpxkaHi7PCYhqJgp6vV3+w Date: Fri, 27 Nov 2015 05:38:13 +0000 Message-ID: References: <1448589345-16239-1-git-send-email-jing.d.chen@intel.com> In-Reply-To: <1448589345-16239-1-git-send-email-jing.d.chen@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] fm10k: fix wrong Rx func is used X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Nov 2015 05:38:17 -0000 Hi, > -----Original Message----- > From: Chen, Jing D > Sent: Friday, November 27, 2015 9:56 AM > To: dev@dpdk.org > Cc: Wang, Xiao W ; Chen, Jing D > > Subject: [PATCH] fm10k: fix wrong Rx func is used >=20 > From: "Chen Jing D(Mark)" >=20 > Steps to reproduce the bug: > 1. All Rx offloading is disabled and start the device, then > Vector Rx is used. > 2. Stop the device. Re-configure to enable hw_ip_checksum =3D 1, > start the device again. > 3. In this case, assume regular Rx should be used since Vector > Rx doesn't support ip checksum offload. But actually Vector > Rx is used and cause checksum won't be done by hardware. >=20 > The reason is after re-configuring, driver misses an "else" in func > fm10k_set_rx_function(). Then Rx func in last round are used. >=20 > Fixes:77a8ab47("fm10k: select best Rx function") >=20 > Reported-by: Xiao Wang > Signed-off-by: Chen Jing D(Mark) > --- > drivers/net/fm10k/fm10k_ethdev.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) >=20 > diff --git a/drivers/net/fm10k/fm10k_ethdev.c > b/drivers/net/fm10k/fm10k_ethdev.c > index 4f23ce3..e4aed94 100644 > --- a/drivers/net/fm10k/fm10k_ethdev.c > +++ b/drivers/net/fm10k/fm10k_ethdev.c > @@ -2486,6 +2486,8 @@ fm10k_set_rx_function(struct rte_eth_dev *dev) > dev->rx_pkt_burst =3D fm10k_recv_pkts_vec; > } else if (dev->data->scattered_rx) > dev->rx_pkt_burst =3D fm10k_recv_scattered_pkts; > + else > + dev->rx_pkt_burst =3D fm10k_recv_pkts; >=20 > rx_using_sse =3D > (dev->rx_pkt_burst =3D=3D fm10k_recv_scattered_pkts_vec || > -- > 1.7.7.6 Acked-by: Xiao Wang