From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 4FAB88DB4 for ; Wed, 13 Jan 2016 04:01:34 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP; 12 Jan 2016 19:01:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,286,1449561600"; d="scan'208";a="28369387" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga004.fm.intel.com with ESMTP; 12 Jan 2016 19:01:32 -0800 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 12 Jan 2016 19:01:32 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 12 Jan 2016 19:01:26 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.111]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.183]) with mapi id 14.03.0248.002; Wed, 13 Jan 2016 11:01:24 +0800 From: "Wang, Xiao W" To: "Mcnamara, John" , "Chen, Jing D" , "Richardson, Bruce" Thread-Topic: [dpdk-dev] [RFC PATCH 3/3] doc: add introduction for fm10k FTAG based forwarding Thread-Index: AdFNrqPjFa2/VspERP62QGXn5G9hPQ== Date: Wed, 13 Jan 2016 03:01:24 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [RFC PATCH 3/3] doc: add introduction for fm10k FTAG based forwarding X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jan 2016 03:01:35 -0000 Hi, John > -----Original Message----- > From: Mcnamara, John > Sent: Tuesday, January 12, 2016 10:16 PM > To: Wang, Xiao W ; Chen, Jing D > ; Richardson, Bruce > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [RFC PATCH 3/3] doc: add introduction for fm10k > FTAG based forwarding >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wang Xiao W > > Sent: Tuesday, January 5, 2016 12:32 PM > > To: Chen, Jing D; Richardson, Bruce > > Cc: dev@dpdk.org > > Subject: [dpdk-dev] [RFC PATCH 3/3] doc: add introduction for fm10k > > FTAG based forwarding > > > > Add a brief introduction on FTAG, describes what's FTAG and how it > > works in forwarding, introduction on how to run fm10k with FTAG is > > also included. > > > > Signed-off-by: Wang Xiao W > > --- > > doc/guides/nics/fm10k.rst | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/doc/guides/nics/fm10k.rst b/doc/guides/nics/fm10k.rst > > index > > 4206b7f..d82bf41 100644 > > --- a/doc/guides/nics/fm10k.rst > > +++ b/doc/guides/nics/fm10k.rst > > @@ -34,6 +34,19 @@ FM10K Poll Mode Driver The FM10K poll mode driver > > library provides support for the Intel FM10000 > > (FM10K) family of 40GbE/100GbE adapters. > > >=20 > Hi, >=20 > Some very minor comments. >=20 >=20 > > +FTAG Based Forwarding of FM10K > > +------------------------------ >=20 > The Documentation Guidelines say to put a newline after section headers. >=20 > > +FTAG Based Forwarding is a unique feature of FM10K. The FM10K family > > +of NICs support the addition of a Fabric Tag (FTAG) to carry special > > information. > > +The FTAG is placed at the beginning of the frame, it contains > > +information such as where the packet comes from and goes, the vlan tag= . >=20 > s/the vlan tag/and the vlan tag >=20 >=20 > > +In FTAG based forwarding mode, the switch logic forwards packets > > +according to glort (global resource tag) information, other than the >=20 > s/other/rather >=20 >=20 > > +mac and vlan table. Now this feature works only on PF. >=20 > s/Now/Currently >=20 >=20 > > + > > +To enable this feature, turn CONFIG_RTE_LIBRTE_FM10K_FTAG_FWD to y > in >=20 > In general variable and config names should be in fixed width quotes: >=20 > ``CONFIG_RTE_LIBRTE_FM10K_FTAG_FWD`` >=20 >=20 > > +the configuration file. A unit test case fm10k_ftag_autotest is for >=20 > s/for/provided for >=20 > John. > -- >=20 Many thanks for your comments, I'll change accordingly.