From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <xiao.w.wang@intel.com> Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 616143777 for <dev@dpdk.org>; Thu, 21 Jul 2016 11:35:51 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP; 21 Jul 2016 02:35:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,398,1464678000"; d="scan'208";a="143104798" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga004.fm.intel.com with ESMTP; 21 Jul 2016 02:35:47 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 21 Jul 2016 02:35:46 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.8]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.150]) with mapi id 14.03.0248.002; Thu, 21 Jul 2016 17:35:40 +0800 From: "Wang, Xiao W" <xiao.w.wang@intel.com> To: "Chen, Jing D" <jing.d.chen@intel.com>, "dev@dpdk.org" <dev@dpdk.org> CC: "Lin, Xueqin" <xueqin.lin@intel.com> Thread-Topic: [PATCH] net/fm10k: fix RSS hash config Thread-Index: AQHR4ylUUhdHfx9pY0KVveNgV6nZw6AiDN+AgACPlrA= Date: Thu, 21 Jul 2016 09:35:39 +0000 Message-ID: <B7F2E978279D1D49A3034B7786DACF403DC17A43@SHSMSX101.ccr.corp.intel.com> References: <1469089470-5764-1-git-send-email-xiao.w.wang@intel.com> <4341B239C0EFF9468EE453F9E9F4604D044DECE4@shsmsx102.ccr.corp.intel.com> In-Reply-To: <4341B239C0EFF9468EE453F9E9F4604D044DECE4@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2U1YjZkODEtNTExNC00ZDM1LWIyZWQtYzg5NDQ3MTdmZTg2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImZPYWJFbFM5aUtBMTQ5RmFKZ0F1ako5TlBaXC9Jc0V1TGFJaWZzWEdUWWNzPSJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/fm10k: fix RSS hash config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 21 Jul 2016 09:35:51 -0000 Hi Mark, > -----Original Message----- > From: Chen, Jing D > Sent: Thursday, July 21, 2016 4:48 PM > To: Wang, Xiao W <xiao.w.wang@intel.com>; dev@dpdk.org > Cc: Lin, Xueqin <xueqin.lin@intel.com> > Subject: RE: [PATCH] net/fm10k: fix RSS hash config >=20 > Hi, >=20 > > diff --git a/drivers/net/fm10k/fm10k_ethdev.c > > b/drivers/net/fm10k/fm10k_ethdev.c > > index 144b2de..01f4a72 100644 > > --- a/drivers/net/fm10k/fm10k_ethdev.c > > +++ b/drivers/net/fm10k/fm10k_ethdev.c > > @@ -2159,8 +2159,8 @@ fm10k_rss_hash_update(struct rte_eth_dev *dev, > > > > PMD_INIT_FUNC_TRACE(); > > > > - if (rss_conf->rss_key_len < FM10K_RSSRK_SIZE * > > - FM10K_RSSRK_ENTRIES_PER_REG) > > + if (key && (rss_conf->rss_key_len < FM10K_RSSRK_SIZE * > > + FM10K_RSSRK_ENTRIES_PER_REG)) > > return -EINVAL; > > > > if (hf =3D=3D 0) >=20 > It's also possible that app wants to update rss key and not expect to upd= ate hash > function. > Is that indicate we shouldn't return error in case hf =3D=3D 0? >=20 If the app just wants to update RSS key, it needs to read out the RSS confi= g first, then change only the key field. This is what testpmd does for this operation. hf =3D=3D 0 will disable RSS feature, I think we should return error to pro= tect multi-queue. Best Regards, Xiao