From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <xiao.w.wang@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
by dpdk.org (Postfix) with ESMTP id 68C4C567A
for <dev@dpdk.org>; Thu, 22 Sep 2016 17:58:46 +0200 (CEST)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
by orsmga102.jf.intel.com with ESMTP; 22 Sep 2016 08:58:47 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.30,378,1470726000"; d="scan'208";a="12597421"
Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202])
by orsmga004.jf.intel.com with ESMTP; 22 Sep 2016 08:58:45 -0700
Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by
fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS)
id 14.3.248.2; Thu, 22 Sep 2016 08:58:44 -0700
Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by
fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS)
id 14.3.248.2; Thu, 22 Sep 2016 08:58:44 -0700
Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.118]) by
SHSMSX152.ccr.corp.intel.com ([169.254.6.95]) with mapi id 14.03.0248.002;
Thu, 22 Sep 2016 23:58:42 +0800
From: "Wang, Xiao W" <xiao.w.wang@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "Lu, Wenzhuo"
<wenzhuo.lu@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH 01/39] net/ixgbe/base: fix delta check for
setting VFTA
Thread-Index: AQHSAHqA9npdEqzu/E6RC+81rqtBkqCAp6QAgAUo7tA=
Date: Thu, 22 Sep 2016 15:58:41 +0000
Message-ID: <B7F2E978279D1D49A3034B7786DACF406C21F7D1@SHSMSX101.ccr.corp.intel.com>
References: <1472312902-16963-1-git-send-email-xiao.w.wang@intel.com>
<1472312902-16963-2-git-send-email-xiao.w.wang@intel.com>
<9e4205ae-1d41-4956-ad3e-115ef0006c11@intel.com>
In-Reply-To: <9e4205ae-1d41-4956-ad3e-115ef0006c11@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ctpclassification: CTP_PUBLIC
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWVlNjBmMGEtMjI4MS00M2RkLWI1ZDYtNDZhYTk0OWQxYmMzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX1BVQkxJQyJ9XX1dfSwiU3ViamVjdExhYmVscyI6W10sIlRNQ1ZlcnNpb24iOiIxNS45LjYuNiIsIlRydXN0ZWRMYWJlbEhhc2giOiJKbGkranpOcVYwbmR1aGRQdk9QUlYwNUJoOTd5WHpnMHdwTlVLbytOc2VJPSJ9
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH 01/39] net/ixgbe/base: fix delta check for
setting VFTA
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Sep 2016 15:58:47 -0000
Hi Ferruh,
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, September 20, 2016 1:01 AM
> To: Wang, Xiao W <xiao.w.wang@intel.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 01/39] net/ixgbe/base: fix delta check for
> setting VFTA
>=20
> On 8/27/2016 4:47 PM, Xiao Wang wrote:
> > The delta value rather than vfta_delta pointer should be checked.
> >
> > Fixes: b978f7b38c14 ("net/ixgbe/base: simplify VLAN management")
> >
> > Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
> > ---
> > drivers/net/ixgbe/base/ixgbe_82598.c | 6 +++---
> > drivers/net/ixgbe/base/ixgbe_api.c | 7 ++++---
> > drivers/net/ixgbe/base/ixgbe_common.c | 2 +-
> > 3 files changed, 8 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/net/ixgbe/base/ixgbe_82598.c
> b/drivers/net/ixgbe/base/ixgbe_82598.c
> > index db80880..724dcbb 100644
> > --- a/drivers/net/ixgbe/base/ixgbe_82598.c
> > +++ b/drivers/net/ixgbe/base/ixgbe_82598.c
> > @@ -995,19 +995,19 @@ STATIC s32 ixgbe_clear_vmdq_82598(struct
> ixgbe_hw *hw, u32 rar, u32 vmdq)
> > * @vlan: VLAN id to write to VLAN filter
> > * @vind: VMDq output index that maps queue to VLAN id in VFTA
> > * @vlan_on: boolean flag to turn on/off VLAN in VFTA
> > - * @bypass_vlvf: boolean flag - unused
> > + * @vlvf_bypass: boolean flag - unused
>=20
> bypass_vlvf -> vlvf_bypass belongs to different patch
>=20
> > *
> > * Turn on/off specified VLAN in the VLAN filter table.
> > **/
> > s32 ixgbe_set_vfta_82598(struct ixgbe_hw *hw, u32 vlan, u32 vind,
> > - bool vlan_on, bool bypass_vlvf)
> > + bool vlan_on, bool vlvf_bypass)
> > {
> > u32 regindex;
> > u32 bitindex;
> > u32 bits;
> > u32 vftabyte;
> >
> > - UNREFERENCED_1PARAMETER(bypass_vlvf);
> > + UNREFERENCED_1PARAMETER(vlvf_bypass);
> >
> > DEBUGFUNC("ixgbe_set_vfta_82598");
> >
> > diff --git a/drivers/net/ixgbe/base/ixgbe_api.c
> b/drivers/net/ixgbe/base/ixgbe_api.c
> > index 1786867..5b721af 100644
> > --- a/drivers/net/ixgbe/base/ixgbe_api.c
> > +++ b/drivers/net/ixgbe/base/ixgbe_api.c
> > @@ -1090,7 +1090,7 @@ s32 ixgbe_set_vfta(struct ixgbe_hw *hw, u32 vlan,
> u32 vind, bool vlan_on,
> > bool vlvf_bypass)
> > {
> > return ixgbe_call_func(hw, hw->mac.ops.set_vfta, (hw, vlan, vind,
> > - vlan_on, vlvf_bypass),
> IXGBE_NOT_IMPLEMENTED);
> > + vlan_on, vlvf_bypass),
> IXGBE_NOT_IMPLEMENTED);
> > }
> >
> > /**
> > @@ -1100,7 +1100,7 @@ s32 ixgbe_set_vfta(struct ixgbe_hw *hw, u32 vlan,
> u32 vind, bool vlan_on,
> > * @vind: VMDq output index that maps queue to VLAN id in VLVFB
> > * @vlan_on: boolean flag to turn on/off VLAN in VLVF
> > * @vfta_delta: pointer to the difference between the current value o=
f VFTA
> > - * and the desired value
> > + * and the desired value
> > * @vfta: the desired value of the VFTA
> > * @vlvf_bypass: boolean flag indicating updating the default pool is=
okay
> > *
> > @@ -1110,7 +1110,7 @@ s32 ixgbe_set_vlvf(struct ixgbe_hw *hw, u32 vlan,
> u32 vind, bool vlan_on,
> > u32 *vfta_delta, u32 vfta, bool vlvf_bypass)
> > {
> > return ixgbe_call_func(hw, hw->mac.ops.set_vlvf, (hw, vlan, vind,
> > - vlan_on, vfta_delta, vfta, vlvf_bypass),
> > + vlan_on, vfta_delta, vfta, vlvf_bypass),
> > IXGBE_NOT_IMPLEMENTED);
> > }
> >
> > @@ -1659,6 +1659,7 @@ void ixgbe_init_swfw_semaphore(struct ixgbe_hw
> *hw)
> > hw->mac.ops.init_swfw_sync(hw);
> > }
> >
> > +
>=20
> unrelated whitespace modifications
>=20
>=20
> > void ixgbe_disable_rx(struct ixgbe_hw *hw)
> > {
> > if (hw->mac.ops.disable_rx)
> > diff --git a/drivers/net/ixgbe/base/ixgbe_common.c
> b/drivers/net/ixgbe/base/ixgbe_common.c
> > index 811875a..161bf32 100644
> > --- a/drivers/net/ixgbe/base/ixgbe_common.c
> > +++ b/drivers/net/ixgbe/base/ixgbe_common.c
> > @@ -3967,7 +3967,7 @@ s32 ixgbe_set_vlvf_generic(struct ixgbe_hw *hw,
> u32 vlan, u32 vind,
> > * we run the risk of stray packets leaking into
> > * the PF via the default pool
> > */
> > - if (vfta_delta)
> > + if (*vfta_delta)
>=20
> This seems only update mentioned in patch commit log.
>=20
> What about extracting all other clean up modifications into a new patch,
> other patches also have similar fixes, all can go into that cleanup patch=
?
Good advice, I will put all the minor misc modifications into a separate pa=
tch.
Thanks.
>=20
> > IXGBE_WRITE_REG(hw, IXGBE_VFTA(vlan / 32), vfta);
> >
> > /* disable VLVF and clear remaining bit from pool */
> >
>=20