From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id F1FC44D3A for ; Thu, 15 Mar 2018 18:05:45 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Mar 2018 09:49:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,311,1517904000"; d="scan'208";a="25562004" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga008.jf.intel.com with ESMTP; 15 Mar 2018 09:49:45 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 15 Mar 2018 09:49:45 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 15 Mar 2018 09:49:44 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.166]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.129]) with mapi id 14.03.0319.002; Fri, 16 Mar 2018 00:49:42 +0800 From: "Wang, Xiao W" To: =?iso-8859-1?Q?Ga=EBtan_Rivet?= , "Burakov, Anatoly" CC: "dev@dpdk.org" , "Wang, Zhihong" , "maxime.coquelin@redhat.com" , "yliu@fridaylinux.org" , "Liang, Cunming" , "Xu, Rosen" , "Chen, Junjie J" , "Daly, Dan" Thread-Topic: [dpdk-dev] [PATCH 2/3] bus/pci: expose sysfs parsing API Thread-Index: AQHTt7OzLfB2XQzF1kaMiGjT+WmvO6PPFyGAgAAkn4CAAksuEA== Date: Thu, 15 Mar 2018 16:49:41 +0000 Message-ID: References: <20180309230809.63361-1-xiao.w.wang@intel.com> <20180309230809.63361-3-xiao.w.wang@intel.com> <20180314133035.tmqgh2ghdyv3b47e@bidouze.vm.6wind.com> In-Reply-To: <20180314133035.tmqgh2ghdyv3b47e@bidouze.vm.6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWZjYWRjODctYWQyYy00ZGZlLThmZTctYTI2NTgzNWUzODlhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJHVFA5cmRKblNUaWFLVDJiSnlTbDBMTnpYTE4xOFJWeFRNOXZmbWpcL2x2SkpWSzIwb0MwNUhIbkxvOGhISVNcL2UifQ== dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/3] bus/pci: expose sysfs parsing API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Mar 2018 17:05:46 -0000 Hi Rivet, > -----Original Message----- > From: Ga=EBtan Rivet [mailto:gaetan.rivet@6wind.com] > Sent: Wednesday, March 14, 2018 9:31 PM > To: Burakov, Anatoly > Cc: Wang, Xiao W ; dev@dpdk.org; Wang, Zhihong > ; maxime.coquelin@redhat.com; > yliu@fridaylinux.org; Liang, Cunming ; Xu, Rosen > ; Chen, Junjie J ; Daly, Dan > > Subject: Re: [dpdk-dev] [PATCH 2/3] bus/pci: expose sysfs parsing API >=20 > Hi, >=20 > On Wed, Mar 14, 2018 at 11:19:31AM +0000, Burakov, Anatoly wrote: > > On 09-Mar-18 11:08 PM, Xiao Wang wrote: > > > Some existing sysfs parsing functions are helpful for the later vDPA > > > driver, this patch make them global and expose them to shared lib. > > > > > > Signed-off-by: Xiao Wang > > > --- > > > drivers/bus/pci/linux/pci.c | 9 ++++----- > > > drivers/bus/pci/linux/pci_init.h | 8 ++++++++ > > > drivers/bus/pci/rte_bus_pci_version.map | 8 ++++++++ > > > 3 files changed, 20 insertions(+), 5 deletions(-) > > > > > > diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.= c > > > index abde64119..81e5e5650 100644 > > > --- a/drivers/bus/pci/linux/pci.c > > > +++ b/drivers/bus/pci/linux/pci.c > > > @@ -32,7 +32,7 @@ > > > extern struct rte_pci_bus rte_pci_bus; > > > -static int > > > +int > > > pci_get_kernel_driver_by_path(const char *filename, char *dri_name) > > > > Here and in other places - shouldn't this too be prefixed with rte_? > > >=20 > A public PCI function should be prefixed by rte_pci_ yes. OK, will add this prefix. >=20 > Additionally, if this function was to be exposed, then there should be a > BSD implementation as well (shared map file). >=20 > I don't know how BSD works, I'm not sure parsing the filesystem is the > way to get a PCI driver name. If so, maybe the function should be called > another, generic, way, that would work for both linux and BSD (and > ideally, having a real BSD implementation). BSD is not parsing the filesystem, it uses PCIOCGETCONF ioctl to retrieve PCI device information. This function is quite linux, especially for the API name. I'm afraid we ca= n only return err on BSD for this API. BRs, Xiao >=20 > > > > -- > > Thanks, > > Anatoly >=20 > -- > Ga=EBtan Rivet > 6WIND