From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 2E47BAABF for ; Thu, 22 Mar 2018 04:00:31 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Mar 2018 20:00:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,342,1517904000"; d="scan'208";a="210307008" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga005.jf.intel.com with ESMTP; 21 Mar 2018 20:00:30 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 21 Mar 2018 20:00:30 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.166]) by shsmsx102.ccr.corp.intel.com ([169.254.2.80]) with mapi id 14.03.0319.002; Thu, 22 Mar 2018 11:00:29 +0800 From: "Wang, Xiao W" To: =?iso-8859-1?Q?Ga=EBtan_Rivet?= , Thomas Monjalon CC: "Chen, Junjie J" , "dev@dpdk.org" , "maxime.coquelin@redhat.com" , "yliu@fridaylinux.org" , "Wang, Zhihong" , "Bie, Tiwei" , "Xu, Rosen" , "Daly, Dan" , "Liang, Cunming" , "Burakov, Anatoly" Thread-Topic: [dpdk-dev] [PATCH v2 1/3] eal/vfio: add support for multiple container Thread-Index: AQHTwM+2vGqFPrRlAUCnEPGQQnpKs6Pan60AgAASNwCAANzDUA== Date: Thu, 22 Mar 2018 03:00:27 +0000 Message-ID: References: <20180309230809.63361-3-xiao.w.wang@intel.com> <20180321132108.52464-1-xiao.w.wang@intel.com> <20180321132108.52464-2-xiao.w.wang@intel.com> <2126445.Z7b39kXXoB@xps> <20180321213730.iidhaoib6nprr5qq@bidouze.vm.6wind.com> In-Reply-To: <20180321213730.iidhaoib6nprr5qq@bidouze.vm.6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzhjOGY5NTEtYWM3MS00OTljLWFiMTUtYTZhNWMzMDE3YWFhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiIwSVdSTkNZa1Q1THJPRnZSbGZwRXNPdmowK1hsOHdkRHpBUld6MlpoRDhcL0ZIa2VOYUhLc08yMnAycnFtOVlJayJ9 dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/3] eal/vfio: add support for multiple container X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Mar 2018 03:00:32 -0000 Hi Thomas, Rivet, > -----Original Message----- > From: Ga=EBtan Rivet [mailto:gaetan.rivet@6wind.com] > Sent: Thursday, March 22, 2018 5:38 AM > To: Thomas Monjalon > Cc: Wang, Xiao W ; Chen, Junjie J > ; dev@dpdk.org; maxime.coquelin@redhat.com; > yliu@fridaylinux.org; Wang, Zhihong ; Bie, Tiwei > ; Xu, Rosen ; Daly, Dan > ; Liang, Cunming ; Burakov, > Anatoly > Subject: Re: [dpdk-dev] [PATCH v2 1/3] eal/vfio: add support for multiple > container >=20 > On Wed, Mar 21, 2018 at 09:32:18PM +0100, Thomas Monjalon wrote: > > Hi, > > > > 21/03/2018 14:21, Xiao Wang: > > > +#endif /* VFIO_PRESENT */ > > > #endif /* _RTE_VFIO_H_ */ > > > > Please keep the empty line which was present between endif. OK. > > > > > + rte_vfio_create_container; > > > + rte_vfio_destroy_container; > > > + rte_vfio_bind_group_no; > > > + rte_vfio_unbind_group_no; > > > + rte_vfio_dma_map; > > > + rte_vfio_dma_unmap; > > > + rte_vfio_get_group_fd; > > > > Please keep alphabetical order. OK. Will do. > > > > About the naming, I see "no" and "idx" are used. > > Other APIs in DPDK are using "num" and "id". Any strong opinion? >=20 > {bind,unbind}_group is sufficient as a name. > _no is redundant as implicit from the parameter type. {bind,unbind}_group looks very neat. Will remove "_no". For the eal_vfio.c internal API with "_idx" postfix, the return value is an= index of an array. I think "idx" is appropriate. Before this patch, we alr= eady have function get_vfio_group_idx. Thanks for the comments. -Xiao >=20 > -- > Ga=EBtan Rivet > 6WIND