From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 193E75F2A for ; Fri, 23 Mar 2018 11:39:55 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Mar 2018 03:39:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,349,1517904000"; d="scan'208";a="41522944" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 23 Mar 2018 03:39:53 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 23 Mar 2018 03:39:53 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 23 Mar 2018 03:39:52 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.166]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.129]) with mapi id 14.03.0319.002; Fri, 23 Mar 2018 18:39:50 +0800 From: "Wang, Xiao W" To: Thomas Monjalon , "Xu, Rosen" CC: "dev@dpdk.org" , "maxime.coquelin@redhat.com" , "yliu@fridaylinux.org" , "Wang, Zhihong" , "Bie, Tiwei" , "Chen, Junjie J" , "Daly, Dan" , "Liang, Cunming" , "Burakov, Anatoly" , "gaetan.rivet@6wind.com" Thread-Topic: [dpdk-dev] [PATCH v2 3/3] net/ifcvf: add ifcvf driver Thread-Index: AQHTwM++Owzmq9Jb+E6quhCOxIEQxqPapToAgAL/ANA= Date: Fri, 23 Mar 2018 10:39:50 +0000 Message-ID: References: <20180309230809.63361-3-xiao.w.wang@intel.com> <20180321132108.52464-1-xiao.w.wang@intel.com> <20180321132108.52464-4-xiao.w.wang@intel.com> <3903591.iEHhUDiruC@xps> In-Reply-To: <3903591.iEHhUDiruC@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTI2Mjk1MTMtNTMwNS00NTlhLWJmZTItNDEyMmE1MDViZmY2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJvUldvMUkwd1Z4WEtBZjU4dlBTUHBabE1yUUlRYkEzbkY1dTdGa09cL3dVWm5zbE9FZThqNHlOQVBzR09JcHR2SyJ9 dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 3/3] net/ifcvf: add ifcvf driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Mar 2018 10:39:56 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Thursday, March 22, 2018 4:52 AM > To: Wang, Xiao W ; Xu, Rosen > Cc: dev@dpdk.org; maxime.coquelin@redhat.com; yliu@fridaylinux.org; Wang, > Zhihong ; Bie, Tiwei ; Chen, > Junjie J ; Daly, Dan ; Liang= , > Cunming ; Burakov, Anatoly > ; gaetan.rivet@6wind.com > Subject: Re: [dpdk-dev] [PATCH v2 3/3] net/ifcvf: add ifcvf driver >=20 > 21/03/2018 14:21, Xiao Wang: > > ifcvf driver uses vdev as a control domain to manage ifc VFs that belon= g > > to it. It registers vDPA device ops to vhost lib to enable these VFs to= be > > used as vhost data path accelerator. >=20 > Not everybody work at Intel. > Please explain what means ifcvf and what is a control domain. OK, and I will add a document. >=20 > > Live migration feature is supported by ifc VF and this driver enables > > it based on vhost lib. > > > > Because vDPA driver needs to set up MSI-X vector to interrupt the guest= , > > only vfio-pci is supported currently. > > > > Signed-off-by: Xiao Wang > > Signed-off-by: Rosen Xu > > --- > > v2: > > - Rebase on Zhihong's vDPA v3 patch set. > > --- > > config/common_base | 6 + > > config/common_linuxapp | 1 + > > drivers/net/Makefile | 1 + > > drivers/net/ifcvf/Makefile | 40 + > > drivers/net/ifcvf/base/ifcvf.c | 329 ++++++++ > > drivers/net/ifcvf/base/ifcvf.h | 156 ++++ > > drivers/net/ifcvf/base/ifcvf_osdep.h | 52 ++ > > drivers/net/ifcvf/ifcvf_ethdev.c | 1240 > +++++++++++++++++++++++++++++++ > > drivers/net/ifcvf/rte_ifcvf_version.map | 4 + > > mk/rte.app.mk | 1 + >=20 > This feature needs to be explained and documented. > It will be helpful to understand the mechanism and to have a good review. > Please do not merge it until there is a good documentation. >=20 Will add a doc with more details. BRs, Xiao