Re: [dpdk-dev] [PATCH v2 2/2] examples/vdpa: introduce a new sample for vDPA

["Wang, Xiao W" <xiao.w.wang@intel.com>]

Hi Xiaolong,

> -----Original Message-----
> From: Ye, Xiaolong
> Sent: Thursday, September 20, 2018 6:23 AM
> To: Wang, Xiao W <xiao.w.wang@intel.com>
> Cc: dev@dpdk.org; Maxime Coquelin <maxime.coquelin@redhat.com>; Bie,
> Tiwei <tiwei.bie@intel.com>; Wang, Zhihong <zhihong.wang@intel.com>;
> Rami Rosen <roszenrami@gmail.com>; Wang, Haiyue
> <haiyue.wang@intel.com>
> Subject: Re: [PATCH v2 2/2] examples/vdpa: introduce a new sample for vDPA
> 
> On 09/19, Wang, Xiao W wrote:
> >Hi Xiaolong,
> >
> [snip]
> >> +.. note::
> >> +    We need to bind VFIO-pci to VFs before running vdpa sample.
> >
> >Replace "VFIO-pci" with "vfio-pci".
> 
> Got it.
> 
> >
> >> +
> >> +    * modprobe vfio-pci
> >> +    * ./usertools/dpdk-devbind.py -b vfio-pci 06:00.2 06:00.3
> >> +
> >> +Then we can create 2 vdpa ports in interactive cmdline.
> >> +
> >> +.. code-block:: console
> >> +
> >> +        vdpa> list
> >> +        device id       device address
> >> +        0               0000:06:00.2
> >> +        1               0000:06:00.3
> >
> >Could we show out also the device's features and supported queue number?
> 
> Sure, it's a good suggestion.
> 
> [snip]
> >
> >> +	ret = rte_vhost_driver_unregister(socket_path);
> >> +	if (ret != 0)
> >> +		RTE_LOG(ERR, USER1,
> >> +				"Fail to unregister vhost driver for %s.\n",
> >> +				socket_path);
> >> +}
> >> +
> >> +static void
> >> +vdpa_sample_quit(void)
> >> +{
> >> +	int i;
> >> +	for (i = 0; i <  RTE_MIN(MAX_VDPA_SAMPLE_PORTS, dev_total); i++) {
> >
> >Double " ".
> 
> Sorry, not quite understand what's your meaning here.

I mean there are 2 blank spaces after the "<" operator.

BRs,
Xiao