From: "Wang, Xiao W" <xiao.w.wang@intel.com>
To: Kevin Traynor <ktraynor@redhat.com>
Cc: "Ye, Xiaolong" <xiaolong.ye@intel.com>,
"Bie, Tiwei" <tiwei.bie@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/ifc: do not notify before HW ready
Date: Wed, 26 Sep 2018 00:12:40 +0000 [thread overview]
Message-ID: <B7F2E978279D1D49A3034B7786DACF406F9C86C5@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <57299da3-af0a-01a1-d4f5-0fbe8b9ce0be@redhat.com>
Hi,
> -----Original Message-----
> From: Kevin Traynor [mailto:ktraynor@redhat.com]
> Sent: Wednesday, September 26, 2018 1:16 AM
> To: Wang, Xiao W <xiao.w.wang@intel.com>
> Cc: Ye, Xiaolong <xiaolong.ye@intel.com>; Bie, Tiwei <tiwei.bie@intel.com>;
> dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] net/ifc: do not notify before HW ready
>
> On 09/14/2018 02:25 AM, Xiao Wang wrote:
> > If the device is not clearly reset by the previous driver and holds
> > some invalid ring addr, and the relay thread kicks it before HW is
> > properly re-configured, a bad DMA request may happen.
> >
> > Besides, the notify_addr which is used by the relay thread is set in
> > the vdpa_ifcvf_start function, if a kick relay happens before
> > vdpa_ifcvf_start finishes, a null addr is accessed.
> >
> > Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver")
> >
>
> Looks like this should be in stable branch too. Can you confirm?
Yes, they should go also into stable branch, thanks for the notice.
BRs,
Xiao
next prev parent reply other threads:[~2018-09-26 0:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 11:05 [dpdk-dev] [PATCH] " Xiao Wang
2018-09-13 12:55 ` Ye Xiaolong
2018-09-13 7:23 ` Wang, Xiao W
2018-09-13 20:25 ` Ye Xiaolong
2018-09-14 1:25 ` [dpdk-dev] [PATCH v2] " Xiao Wang
2018-09-14 8:41 ` Ye Xiaolong
2018-09-18 14:20 ` Zhang, Qi Z
2018-09-25 17:15 ` Kevin Traynor
2018-09-26 0:12 ` Wang, Xiao W [this message]
2018-09-26 7:53 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B7F2E978279D1D49A3034B7786DACF406F9C86C5@SHSMSX101.ccr.corp.intel.com \
--to=xiao.w.wang@intel.com \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).