From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 59931A05DC for ; Mon, 10 Jun 2019 04:05:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D247A1BDB0; Mon, 10 Jun 2019 04:05:24 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 50B1D1BDAF; Mon, 10 Jun 2019 04:05:22 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jun 2019 19:05:21 -0700 X-ExtLoop1: 1 Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga005.jf.intel.com with ESMTP; 09 Jun 2019 19:05:21 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 9 Jun 2019 19:05:20 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 9 Jun 2019 19:05:20 -0700 Received: from shsmsx106.ccr.corp.intel.com ([169.254.10.113]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.153]) with mapi id 14.03.0415.000; Mon, 10 Jun 2019 10:05:18 +0800 From: "Wang, Xiao W" To: Andrew Rybchenko , "Zhang, Qi Z" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH 05/11] net/fm10k: fix Tx prepare to set positive rte_errno Thread-Index: AQHVG3cTcW/KpH3eI0G07K9gmX4uYKaUKqjw Date: Mon, 10 Jun 2019 02:05:17 +0000 Message-ID: References: <1559722565-25992-1-git-send-email-arybchenko@solarflare.com> <1559722565-25992-6-git-send-email-arybchenko@solarflare.com> In-Reply-To: <1559722565-25992-6-git-send-email-arybchenko@solarflare.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTFlZGVhZDItMWRiZC00ZTFlLThiOGItZDNiZjg4ODVmNzllIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZTZEK3E1bWlVa3lqMmFQUkY3aWJIZGlMdENIK2I4MlhzYlA2OWpSVHpkWEJjd2tSYmFZdzNTTUJKY2x4QUV3YiJ9 dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 05/11] net/fm10k: fix Tx prepare to set positive rte_errno X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Andrew Rybchenko [mailto:arybchenko@solarflare.com] > Sent: Wednesday, June 5, 2019 4:16 PM > To: Zhang, Qi Z ; Wang, Xiao W > > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [PATCH 05/11] net/fm10k: fix Tx prepare to set positive rte_errn= o >=20 > Fixes: 9b134aa39716 ("net/fm10k: add Tx preparation") > Cc: stable@dpdk.org >=20 > Signed-off-by: Andrew Rybchenko > --- > drivers/net/fm10k/fm10k_rxtx.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/net/fm10k/fm10k_rxtx.c b/drivers/net/fm10k/fm10k_rxt= x.c > index cc95f95..2f4dad0 100644 > --- a/drivers/net/fm10k/fm10k_rxtx.c > +++ b/drivers/net/fm10k/fm10k_rxtx.c > @@ -698,25 +698,25 @@ static inline void tx_xmit_pkt(struct > fm10k_tx_queue *q, struct rte_mbuf *mb) >=20 > if ((m->ol_flags & PKT_TX_TCP_SEG) && > (m->tso_segsz < FM10K_TSO_MINMSS)) { > - rte_errno =3D -EINVAL; > + rte_errno =3D EINVAL; > return i; > } >=20 > if (m->ol_flags & FM10K_TX_OFFLOAD_NOTSUP_MASK) { > - rte_errno =3D -ENOTSUP; > + rte_errno =3D ENOTSUP; > return i; > } >=20 > #ifdef RTE_LIBRTE_ETHDEV_DEBUG > ret =3D rte_validate_tx_offload(m); > if (ret !=3D 0) { > - rte_errno =3D ret; > + rte_errno =3D -ret; > return i; > } > #endif > ret =3D rte_net_intel_cksum_prepare(m); > if (ret !=3D 0) { > - rte_errno =3D ret; > + rte_errno =3D -ret; > return i; > } > } > -- > 1.8.3.1 Acked-by: Xiao Wang