From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 7568DA0471
	for <public@inbox.dpdk.org>; Mon, 17 Jun 2019 14:49:29 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 9EEF01BF04;
	Mon, 17 Jun 2019 14:49:28 +0200 (CEST)
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id F2FC71BF02
 for <dev@dpdk.org>; Mon, 17 Jun 2019 14:49:26 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga007.jf.intel.com ([10.7.209.58])
 by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 17 Jun 2019 05:49:26 -0700
X-ExtLoop1: 1
Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202])
 by orsmga007.jf.intel.com with ESMTP; 17 Jun 2019 05:49:25 -0700
Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by
 fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Mon, 17 Jun 2019 05:49:25 -0700
Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by
 FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Mon, 17 Jun 2019 05:49:25 -0700
Received: from shsmsx106.ccr.corp.intel.com ([169.254.10.89]) by
 SHSMSX105.ccr.corp.intel.com ([169.254.11.72]) with mapi id 14.03.0439.000;
 Mon, 17 Jun 2019 20:49:22 +0800
From: "Wang, Xiao W" <xiao.w.wang@intel.com>
To: "Li, Xiaoyun" <xiaoyun.li@intel.com>, "Wu, Jingjing"
 <jingjing.wu@intel.com>, "Wiles, Keith" <keith.wiles@intel.com>, "Liang,
 Cunming" <cunming.liang@intel.com>, "Maslekar, Omkar"
 <omkar.maslekar@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Li, Xiaoyun" <xiaoyun.li@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v5 1/6] raw/ntb: introduce ntb rawdev driver
Thread-Index: AQHVIlfH5iY151LZMk2ve0ZfBUymVqaf0DoA
Date: Mon, 17 Jun 2019 12:49:22 +0000
Message-ID: <B7F2E978279D1D49A3034B7786DACF407AF4776F@SHSMSX106.ccr.corp.intel.com>
References: <20190613075649.67472-1-xiaoyun.li@intel.com>
 <20190614021940.78631-1-xiaoyun.li@intel.com>
 <20190614021940.78631-2-xiaoyun.li@intel.com>
In-Reply-To: <20190614021940.78631-2-xiaoyun.li@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ctpclassification: CTP_NT
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmRmNGYxMzItZDkxZi00NjdmLWJlZjEtN2Q5MTZhYjU4MTBhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoianpueEN0YVdFVFk2MDhCUEp2NnZxejJjNmJhelA2NERzazdhM2w1NEsxZ1M4WGlNdEtTa2c3Q3E4VDNEYjZuOSJ9
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v5 1/6] raw/ntb: introduce ntb rawdev driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xiaoyun Li
> Sent: Friday, June 14, 2019 10:20 AM
> To: Wu, Jingjing <jingjing.wu@intel.com>; Wiles, Keith <keith.wiles@intel=
.com>;
> Liang, Cunming <cunming.liang@intel.com>; Maslekar, Omkar
> <omkar.maslekar@intel.com>
> Cc: dev@dpdk.org; Li, Xiaoyun <xiaoyun.li@intel.com>
> Subject: [dpdk-dev] [PATCH v5 1/6] raw/ntb: introduce ntb rawdev driver
>=20
> Introduce rawdev driver support for NTB (Non-transparent Bridge) which
> can help to connect two separate hosts with each other.
>=20
> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> ---
>  config/common_base                            |   5 +
>  drivers/raw/Makefile                          |   1 +
>  drivers/raw/meson.build                       |   2 +-
>  drivers/raw/ntb_rawdev/Makefile               |  27 +
>  drivers/raw/ntb_rawdev/meson.build            |   7 +
>  drivers/raw/ntb_rawdev/ntb_rawdev.c           | 500 ++++++++++++++++++
>  drivers/raw/ntb_rawdev/ntb_rawdev.h           | 158 ++++++
>  .../ntb_rawdev/rte_pmd_ntb_rawdev_version.map |   4 +
>  mk/rte.app.mk                                 |   1 +
>  9 files changed, 704 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/raw/ntb_rawdev/Makefile
>  create mode 100644 drivers/raw/ntb_rawdev/meson.build
>  create mode 100644 drivers/raw/ntb_rawdev/ntb_rawdev.c
>  create mode 100644 drivers/raw/ntb_rawdev/ntb_rawdev.h
>  create mode 100644
> drivers/raw/ntb_rawdev/rte_pmd_ntb_rawdev_version.map
>=20
> diff --git a/config/common_base b/config/common_base
> index e406e7836..45e403130 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -746,6 +746,11 @@
> CONFIG_RTE_LIBRTE_PMD_DPAA2_QDMA_RAWDEV=3Dn
>  #
>  CONFIG_RTE_LIBRTE_PMD_IFPGA_RAWDEV=3Dy
>=20
> +#
> +# Compile PMD for NTB raw device
> +#
> +CONFIG_RTE_LIBRTE_PMD_NTB_RAWDEV=3Dy
> +
>  #
>  # Compile librte_ring
>  #
> diff --git a/drivers/raw/Makefile b/drivers/raw/Makefile
> index 8e29b4a56..efe61f451 100644
> --- a/drivers/raw/Makefile
> +++ b/drivers/raw/Makefile
> @@ -10,5 +10,6 @@ DIRS-
> $(CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF_RAWDEV) +=3D dpaa2_cmdif
>  DIRS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_QDMA_RAWDEV) +=3D dpaa2_qdma
>  endif
>  DIRS-$(CONFIG_RTE_LIBRTE_PMD_IFPGA_RAWDEV) +=3D ifpga_rawdev
> +DIRS-$(CONFIG_RTE_LIBRTE_PMD_NTB_RAWDEV) +=3D ntb_rawdev
>=20
>  include $(RTE_SDK)/mk/rte.subdir.mk
> diff --git a/drivers/raw/meson.build b/drivers/raw/meson.build
> index a61cdccef..6abf659d0 100644
> --- a/drivers/raw/meson.build
> +++ b/drivers/raw/meson.build
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: BSD-3-Clause
>  # Copyright 2018 NXP
>=20
> -drivers =3D ['skeleton_rawdev', 'dpaa2_cmdif', 'dpaa2_qdma', 'ifpga_rawd=
ev']
> +drivers =3D ['skeleton_rawdev', 'dpaa2_cmdif', 'dpaa2_qdma', 'ifpga_rawd=
ev',
> 'ntb_rawdev']
>  std_deps =3D ['rawdev']
>  config_flag_fmt =3D 'RTE_LIBRTE_PMD_@0@_RAWDEV'
>  driver_name_fmt =3D 'rte_pmd_@0@'
> diff --git a/drivers/raw/ntb_rawdev/Makefile
> b/drivers/raw/ntb_rawdev/Makefile
> new file mode 100644
> index 000000000..fb40204c1
> --- /dev/null
> +++ b/drivers/raw/ntb_rawdev/Makefile
> @@ -0,0 +1,27 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2019 Intel Corporation
> +
> +include $(RTE_SDK)/mk/rte.vars.mk
> +
> +#
> +# library name
> +#
> +LIB =3D librte_pmd_ntb_rawdev.a
> +
> +CFLAGS +=3D -DALLOW_EXPERIMENTAL_API
> +CFLAGS +=3D -O3
> +CFLAGS +=3D $(WERROR_FLAGS)
> +LDLIBS +=3D -lrte_eal -lrte_mbuf -lrte_mempool
> +LDLIBS +=3D -lrte_pci -lrte_bus_pci
> +LDLIBS +=3D -lrte_rawdev
> +
> +EXPORT_MAP :=3D rte_pmd_ntb_rawdev_version.map
> +
> +LIBABIVER :=3D 1
> +
> +#
> +# all source are stored in SRCS-y
> +#
> +SRCS-$(CONFIG_RTE_LIBRTE_PMD_SKELETON_RAWDEV) +=3D ntb_rawdev.c

Is it a typo? I think it should be CONFIG_RTE_LIBRTE_PMD_NTB_RAWDEV

BRs,
Xiao

> +
> +include $(RTE_SDK)/mk/rte.lib.mk
> diff --git a/drivers/raw/ntb_rawdev/meson.build
> b/drivers/raw/ntb_rawdev/meson.build
> new file mode 100644
> index 000000000..ca905049d
[...]