From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E59DAA051C; Tue, 11 Feb 2020 11:31:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4F5182BE9; Tue, 11 Feb 2020 11:31:21 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id C413A2BA2 for ; Tue, 11 Feb 2020 11:31:18 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Feb 2020 02:31:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,428,1574150400"; d="scan'208";a="313027332" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 11 Feb 2020 02:31:17 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 11 Feb 2020 02:31:17 -0800 Received: from shsmsx106.ccr.corp.intel.com ([169.254.10.225]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.222]) with mapi id 14.03.0439.000; Tue, 11 Feb 2020 18:31:14 +0800 From: "Wang, Xiao W" To: Xiaojun Liu CC: "dev@dpdk.org" , "Zhang, Qi Z" , "Kwan, Ngai-mint" , "Fornal, Jakub" , "Keller, Jacob E" , Jeff Zheng , Eyal Cohen Thread-Topic: [PATCH v2 0/7] support switch management Thread-Index: AQHVsAigriNscwtQbUeBgjjdweYzFKf0qTOggAA4zbCAIUVWkA== Date: Tue, 11 Feb 2020 10:31:14 +0000 Message-ID: References: <1576057875-7677-1-git-send-email-xiaojun.liu@silicom.co.il> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 0/7] support switch management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Since this is a big code change, so just some general comments/suggestions = for your next version patch set: - please clean up comments like "XXX" in the code. - It's better to define MACRO for all register addrs and bit shift, please = try to avoid magic number (e.g. in the serdes part). - There're threads created for handling events and timers, we'd better use = pthread_join() to recycle them in fm10k_sm_detach(). - set "tapstop" and "shiftwidth" to 8 in vimrc, then recheck the macros and= keep them aligned. - There're some "printf" for debugging, please use dpdk logging API instead= . Best Regards, Xiao > -----Original Message----- > From: Xiaojun Liu > Sent: Tuesday, January 21, 2020 2:15 PM > To: Wang, Xiao W > Cc: dev@dpdk.org; Zhang, Qi Z ; Kwan, Ngai-mint > ; jakub.fornal@intel.co; Keller, Jacob E > ; Jeff Zheng ; Eyal > Cohen > Subject: RE: [PATCH v2 0/7] support switch management >=20 > Hi Xiao, >=20 > Thank you! I will update the commit log and prepare a document to describ= e > the design and implementation. >=20 > Best regards, > Xiaojun >=20 > -----Original Message----- > From: Wang, Xiao W [mailto:xiao.w.wang@intel.com] > Sent: Tuesday, January 21, 2020 10:53 AM > To: Xiaojun Liu > Cc: dev@dpdk.org; Zhang, Qi Z; Kwan, Ngai-mint; jakub.fornal@intel.co; > Keller, Jacob E > Subject: RE: [PATCH v2 0/7] support switch management >=20 > Hi Xiaojun, >=20 > Could you please help to improve the commit logs of all the 7 patches? Th= ey > look very similar, and info like below is not very helpful for reviewer, = since > we already know which file you are adding. > "To support switch management, add the following files: > Add fm10k/switch/fm10k_debug.h(define log Macros). > Add fm10k/switch/fm10k_regs.h(define all the registers)." >=20 > Please talk more about the design and implementation details in the commi= t > log. Refer to history patches if you need a sample. >=20 > Also please help to address the compile error reported by automation in l= ink > http://patches.dpdk.org/patch/63742/: > "ci/Intel-compilation fail Compilation issues" >=20 > I would look deeper into your change, and you can address above comments > simultaneously. >=20 > Best Regards, > Xiao >=20 > > -----Original Message----- > > From: Xiaojun Liu > > Sent: Wednesday, December 11, 2019 5:52 PM > > To: Wang, Xiao W ; Zhang, Qi Z > > ; Kwan, Ngai-mint ; > > jakub.fornal@intel.co; Keller, Jacob E > > Cc: dev@dpdk.org; Xiaojun Liu > > Subject: [PATCH v2 0/7] support switch management > > > > To avoid configuration for both kernel driver > > and userspace SDK outside DPDK, we add switch > > management in FM10K DPDK PMD driver. > > To enable switch management, you need add > > CONFIG_RTE_FM10K_MANAGEMENT=3Dy in > > config/common_linux when building. > > > > > > Xiaojun Liu (7): > > net/fm10k: add i2c sbus registers definition > > net/fm10k: add some modules of port > > net/fm10k: add config ffu statistics support > > net/fm10k: add flow and switch management > > net/fm10k: add switch initialization > > net/fm10k: add mirror and filter ctrl > > net/fm10k: add dpdk port mapping > > > > drivers/net/fm10k/Makefile | 22 + > > drivers/net/fm10k/fm10k_ethdev.c | 580 +++++- > > drivers/net/fm10k/switch/fm10k_config.c | 855 ++++++++ > > drivers/net/fm10k/switch/fm10k_config.h | 171 ++ > > drivers/net/fm10k/switch/fm10k_debug.h | 19 + > > drivers/net/fm10k/switch/fm10k_ext_port.c | 841 ++++++++ > > drivers/net/fm10k/switch/fm10k_ext_port.h | 136 ++ > > drivers/net/fm10k/switch/fm10k_ffu.c | 1209 +++++++++++ > > drivers/net/fm10k/switch/fm10k_ffu.h | 31 + > > drivers/net/fm10k/switch/fm10k_flow.c | 872 ++++++++ > > drivers/net/fm10k/switch/fm10k_flow.h | 26 + > > drivers/net/fm10k/switch/fm10k_i2c.c | 310 +++ > > drivers/net/fm10k/switch/fm10k_i2c.h | 54 + > > drivers/net/fm10k/switch/fm10k_regs.h | 2202 > ++++++++++++++++++++ > > drivers/net/fm10k/switch/fm10k_sbus.c | 292 +++ > > drivers/net/fm10k/switch/fm10k_sbus.h | 40 + > > drivers/net/fm10k/switch/fm10k_serdes.c | 1886 +++++++++++++++++ > > drivers/net/fm10k/switch/fm10k_serdes.h | 32 + > > drivers/net/fm10k/switch/fm10k_sm.c | 182 ++ > > drivers/net/fm10k/switch/fm10k_sm.h | 78 + > > drivers/net/fm10k/switch/fm10k_spico_code.c | 2966 > > +++++++++++++++++++++++++++ > > drivers/net/fm10k/switch/fm10k_spico_code.h | 21 + > > drivers/net/fm10k/switch/fm10k_stats.c | 1242 +++++++++++ > > drivers/net/fm10k/switch/fm10k_stats.h | 257 +++ > > drivers/net/fm10k/switch/fm10k_switch.c | 2562 > > +++++++++++++++++++++++ > > drivers/net/fm10k/switch/fm10k_switch.h | 336 +++ > > 26 files changed, 17188 insertions(+), 34 deletions(-) > > create mode 100644 drivers/net/fm10k/switch/fm10k_config.c > > create mode 100644 drivers/net/fm10k/switch/fm10k_config.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_debug.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_ext_port.c > > create mode 100644 drivers/net/fm10k/switch/fm10k_ext_port.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_ffu.c > > create mode 100644 drivers/net/fm10k/switch/fm10k_ffu.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_flow.c > > create mode 100644 drivers/net/fm10k/switch/fm10k_flow.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_i2c.c > > create mode 100644 drivers/net/fm10k/switch/fm10k_i2c.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_regs.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_sbus.c > > create mode 100644 drivers/net/fm10k/switch/fm10k_sbus.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_serdes.c > > create mode 100644 drivers/net/fm10k/switch/fm10k_serdes.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_sm.c > > create mode 100644 drivers/net/fm10k/switch/fm10k_sm.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_spico_code.c > > create mode 100644 drivers/net/fm10k/switch/fm10k_spico_code.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_stats.c > > create mode 100644 drivers/net/fm10k/switch/fm10k_stats.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_switch.c > > create mode 100644 drivers/net/fm10k/switch/fm10k_switch.h > > > > -- > > 1.8.3.1