* [dpdk-dev] [PATCH] net/fm10k: fix non-x86 build
@ 2020-02-19 14:16 Ferruh Yigit
2020-02-19 14:31 ` Wang, Xiao W
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2020-02-19 14:16 UTC (permalink / raw)
To: Qi Zhang, Xiao Wang, Chen Jing D(Mark); +Cc: dev, Ferruh Yigit, stable
'fm10k_rxtx_vec.c' is SSE vector instructions implementation and should
be compiled only for x86.
The vector PMD support controlled by
'CONFIG_RTE_LIBRTE_FM10K_INC_VECTOR' config option, but it is enabled by
default, safer to add x86 checks too.
Fixes: 10eb9ce8dccd ("fm10k: allow to disable vector driver")
Cc: stable@dpdk.org
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: jing.d.chen@intel.com
---
drivers/net/fm10k/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/fm10k/Makefile b/drivers/net/fm10k/Makefile
index 0271bcb15..29e659da8 100644
--- a/drivers/net/fm10k/Makefile
+++ b/drivers/net/fm10k/Makefile
@@ -71,6 +71,8 @@ SRCS-$(CONFIG_RTE_LIBRTE_FM10K_PMD) += fm10k_common.c
SRCS-$(CONFIG_RTE_LIBRTE_FM10K_PMD) += fm10k_mbx.c
SRCS-$(CONFIG_RTE_LIBRTE_FM10K_PMD) += fm10k_vf.c
SRCS-$(CONFIG_RTE_LIBRTE_FM10K_PMD) += fm10k_api.c
+ifeq ($(CONFIG_RTE_ARCH_X86), y)
SRCS-$(CONFIG_RTE_LIBRTE_FM10K_INC_VECTOR) += fm10k_rxtx_vec.c
+endif
include $(RTE_SDK)/mk/rte.lib.mk
--
2.24.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/fm10k: fix non-x86 build
2020-02-19 14:16 [dpdk-dev] [PATCH] net/fm10k: fix non-x86 build Ferruh Yigit
@ 2020-02-19 14:31 ` Wang, Xiao W
2020-02-19 17:33 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Wang, Xiao W @ 2020-02-19 14:31 UTC (permalink / raw)
To: Yigit, Ferruh, Zhang, Qi Z; +Cc: dev, stable
Acked-by: Xiao Wang <xiao.w.wang@intel.com>
Thanks,
Xiao
> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yigit@intel.com>
> Sent: Wednesday, February 19, 2020 10:17 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Wang, Xiao W
> <xiao.w.wang@intel.com>; Chen Jing D(Mark) <jing.d.chen@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/fm10k: fix non-x86 build
>
> 'fm10k_rxtx_vec.c' is SSE vector instructions implementation and should
> be compiled only for x86.
>
> The vector PMD support controlled by
> 'CONFIG_RTE_LIBRTE_FM10K_INC_VECTOR' config option, but it is enabled
> by
> default, safer to add x86 checks too.
>
> Fixes: 10eb9ce8dccd ("fm10k: allow to disable vector driver")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: jing.d.chen@intel.com
> ---
> drivers/net/fm10k/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/fm10k/Makefile b/drivers/net/fm10k/Makefile
> index 0271bcb15..29e659da8 100644
> --- a/drivers/net/fm10k/Makefile
> +++ b/drivers/net/fm10k/Makefile
> @@ -71,6 +71,8 @@ SRCS-$(CONFIG_RTE_LIBRTE_FM10K_PMD) +=
> fm10k_common.c
> SRCS-$(CONFIG_RTE_LIBRTE_FM10K_PMD) += fm10k_mbx.c
> SRCS-$(CONFIG_RTE_LIBRTE_FM10K_PMD) += fm10k_vf.c
> SRCS-$(CONFIG_RTE_LIBRTE_FM10K_PMD) += fm10k_api.c
> +ifeq ($(CONFIG_RTE_ARCH_X86), y)
> SRCS-$(CONFIG_RTE_LIBRTE_FM10K_INC_VECTOR) += fm10k_rxtx_vec.c
> +endif
>
> include $(RTE_SDK)/mk/rte.lib.mk
> --
> 2.24.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/fm10k: fix non-x86 build
2020-02-19 14:31 ` Wang, Xiao W
@ 2020-02-19 17:33 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2020-02-19 17:33 UTC (permalink / raw)
To: Wang, Xiao W, Zhang, Qi Z; +Cc: dev, stable
On 2/19/2020 2:31 PM, Wang, Xiao W wrote:
>
>> -----Original Message-----
>> From: Yigit, Ferruh <ferruh.yigit@intel.com>
>> Sent: Wednesday, February 19, 2020 10:17 PM
>> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Wang, Xiao W
>> <xiao.w.wang@intel.com>; Chen Jing D(Mark) <jing.d.chen@intel.com>
>> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; stable@dpdk.org
>> Subject: [PATCH] net/fm10k: fix non-x86 build
>>
>> 'fm10k_rxtx_vec.c' is SSE vector instructions implementation and should
>> be compiled only for x86.
>>
>> The vector PMD support controlled by
>> 'CONFIG_RTE_LIBRTE_FM10K_INC_VECTOR' config option, but it is enabled
>> by
>> default, safer to add x86 checks too.
>>
>> Fixes: 10eb9ce8dccd ("fm10k: allow to disable vector driver")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Acked-by: Xiao Wang <xiao.w.wang@intel.com>
>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-19 17:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-19 14:16 [dpdk-dev] [PATCH] net/fm10k: fix non-x86 build Ferruh Yigit
2020-02-19 14:31 ` Wang, Xiao W
2020-02-19 17:33 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).