From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60047.outbound.protection.outlook.com [40.107.6.47]) by dpdk.org (Postfix) with ESMTP id 698AA4C74; Mon, 6 May 2019 23:47:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5lWw4AY2e3X6sU2sg2MQsE2KQn/JU5F6C+1PHkO7vWE=; b=DyfToPC7BrSf7fz8FnwePgQg3JoyXjLQw357Qc4Y9903jtXCbJVds5/oPj++kLI4J94lQ9hpJo7JZy30vDW2rJezfXH+dHeitQL2X8Mg6pxRxtdd0+rqhjV7yuMTnX9PffT3/iwfTs+UFsyWbDgLwxxq/4/b/MfXyBZdS9OP/Is= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB3948.eurprd05.prod.outlook.com (52.134.72.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.10; Mon, 6 May 2019 21:46:50 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::e8d5:4aff:902d:6e98]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::e8d5:4aff:902d:6e98%5]) with mapi id 15.20.1856.012; Mon, 6 May 2019 21:46:50 +0000 From: Yongseok Koh To: Honnappa Nagarahalli CC: "jerinj@marvell.com" , Thomas Monjalon , "dev@dpdk.org" , "bruce.richardson@intel.com" , "pbhagavatula@marvell.com" , Shahaf Shuler , "Gavin Hu (Arm Technology China)" , "stable@dpdk.org" , Luca Boccassi , nd Thread-Topic: [dpdk-stable] [PATCH v2] build: disable armv8 crypto extension Thread-Index: AQHVAcE0QrExR6+Ct0Sr/Kunjrx6RqZZkgaA//+miQCABW5VAA== Date: Mon, 6 May 2019 21:46:50 +0000 Message-ID: References: <20190502015806.41497-1-yskoh@mellanox.com> <20190503122813.8938-1-yskoh@mellanox.com> <20190503175034.GD2510@mtidpdk.mti.labs.mlnx> In-Reply-To: <20190503175034.GD2510@mtidpdk.mti.labs.mlnx> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 59c805a6-cd90-46ab-8ad4-08d6d26c58c9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:DB3PR0502MB3948; x-ms-traffictypediagnostic: DB3PR0502MB3948: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0029F17A3F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(346002)(376002)(39860400002)(136003)(396003)(189003)(199004)(6512007)(2616005)(102836004)(6506007)(53546011)(478600001)(476003)(6486002)(7416002)(26005)(33656002)(8936002)(7736002)(486006)(81156014)(186003)(81166006)(76176011)(53936002)(6436002)(14454004)(99286004)(305945005)(446003)(8676002)(71190400001)(71200400001)(11346002)(6916009)(82746002)(4744005)(25786009)(4326008)(3846002)(6116002)(83716004)(36756003)(229853002)(316002)(86362001)(66556008)(76116006)(64756008)(91956017)(66446008)(73956011)(66476007)(256004)(66946007)(54906003)(68736007)(66066001)(6246003)(5660300002)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3948; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: CQ1fuabpZV7XCfnyCFqq4KPMRHI+XTo6Bm6n/AGMYQp1o6rl0BjUMw5TijrAuTXci4MW+apf7gdyDnG9I+LXDv7p6d8zU5kjLo1e3p7VHBnmhPSHDZ6LfCGjFiNKpkFwH5ebqYKpLd5lLxwLWG+w4K/Wmsd8FGX1RWhd2ER5lLgULGR0cFMOvBl+bU6swpO+Lw9OhZFomJrHJAy8rsNkfUdSpXz9c6HxX7pkXJ2jSS/hh8P39NwTn4GDDz/KES/uJBTSR/RdWjZAzFT2uwOGXu8D7MoItZTQ/fhPihsRm+TwMN3O6r8JdJEWgQqkEWJERw+ekZXyLFladLhrjgo52HYBl18+flkKe8X2dL482KfCatOwN6RdAhyZPU8So/6PGdEoyvY2WRg3SMte6J1gjHPFhnZb/TdtDiXIC5GFoTA= Content-Type: text/plain; charset="us-ascii" Content-ID: <1F91AA95AD60A94CB36EADC865D1E81A@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 59c805a6-cd90-46ab-8ad4-08d6d26c58c9 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2019 21:46:50.5346 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3948 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] build: disable armv8 crypto extension X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 May 2019 21:47:00 -0000 > On May 3, 2019, at 10:50 AM, Yongseok Koh wrote: >=20 >> I think this change might have an impact on the existing users. Does thi= s >> change need to be documented somewhere (at least in the release notes)? >=20 > Practically, there would be no impact. Even if user's app makes use of cr= ypto > instructions, the build config of the app should have the flag. On IRC, I could see you concerned about the case where user app derives bui= ld flags from DPDK like apps under the examples directory. Yes, that's a valid concern. Thomas/Jerin, where could be the best spot to document it? Just release not= e? I think release note would be fine. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A836CA0096 for ; Mon, 6 May 2019 23:47:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D87574C77; Mon, 6 May 2019 23:47:00 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60047.outbound.protection.outlook.com [40.107.6.47]) by dpdk.org (Postfix) with ESMTP id 698AA4C74; Mon, 6 May 2019 23:47:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5lWw4AY2e3X6sU2sg2MQsE2KQn/JU5F6C+1PHkO7vWE=; b=DyfToPC7BrSf7fz8FnwePgQg3JoyXjLQw357Qc4Y9903jtXCbJVds5/oPj++kLI4J94lQ9hpJo7JZy30vDW2rJezfXH+dHeitQL2X8Mg6pxRxtdd0+rqhjV7yuMTnX9PffT3/iwfTs+UFsyWbDgLwxxq/4/b/MfXyBZdS9OP/Is= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB3948.eurprd05.prod.outlook.com (52.134.72.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.10; Mon, 6 May 2019 21:46:50 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::e8d5:4aff:902d:6e98]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::e8d5:4aff:902d:6e98%5]) with mapi id 15.20.1856.012; Mon, 6 May 2019 21:46:50 +0000 From: Yongseok Koh To: Honnappa Nagarahalli CC: "jerinj@marvell.com" , Thomas Monjalon , "dev@dpdk.org" , "bruce.richardson@intel.com" , "pbhagavatula@marvell.com" , Shahaf Shuler , "Gavin Hu (Arm Technology China)" , "stable@dpdk.org" , Luca Boccassi , nd Thread-Topic: [dpdk-stable] [PATCH v2] build: disable armv8 crypto extension Thread-Index: AQHVAcE0QrExR6+Ct0Sr/Kunjrx6RqZZkgaA//+miQCABW5VAA== Date: Mon, 6 May 2019 21:46:50 +0000 Message-ID: References: <20190502015806.41497-1-yskoh@mellanox.com> <20190503122813.8938-1-yskoh@mellanox.com> <20190503175034.GD2510@mtidpdk.mti.labs.mlnx> In-Reply-To: <20190503175034.GD2510@mtidpdk.mti.labs.mlnx> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 59c805a6-cd90-46ab-8ad4-08d6d26c58c9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:DB3PR0502MB3948; x-ms-traffictypediagnostic: DB3PR0502MB3948: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0029F17A3F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(346002)(376002)(39860400002)(136003)(396003)(189003)(199004)(6512007)(2616005)(102836004)(6506007)(53546011)(478600001)(476003)(6486002)(7416002)(26005)(33656002)(8936002)(7736002)(486006)(81156014)(186003)(81166006)(76176011)(53936002)(6436002)(14454004)(99286004)(305945005)(446003)(8676002)(71190400001)(71200400001)(11346002)(6916009)(82746002)(4744005)(25786009)(4326008)(3846002)(6116002)(83716004)(36756003)(229853002)(316002)(86362001)(66556008)(76116006)(64756008)(91956017)(66446008)(73956011)(66476007)(256004)(66946007)(54906003)(68736007)(66066001)(6246003)(5660300002)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3948; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: CQ1fuabpZV7XCfnyCFqq4KPMRHI+XTo6Bm6n/AGMYQp1o6rl0BjUMw5TijrAuTXci4MW+apf7gdyDnG9I+LXDv7p6d8zU5kjLo1e3p7VHBnmhPSHDZ6LfCGjFiNKpkFwH5ebqYKpLd5lLxwLWG+w4K/Wmsd8FGX1RWhd2ER5lLgULGR0cFMOvBl+bU6swpO+Lw9OhZFomJrHJAy8rsNkfUdSpXz9c6HxX7pkXJ2jSS/hh8P39NwTn4GDDz/KES/uJBTSR/RdWjZAzFT2uwOGXu8D7MoItZTQ/fhPihsRm+TwMN3O6r8JdJEWgQqkEWJERw+ekZXyLFladLhrjgo52HYBl18+flkKe8X2dL482KfCatOwN6RdAhyZPU8So/6PGdEoyvY2WRg3SMte6J1gjHPFhnZb/TdtDiXIC5GFoTA= Content-Type: text/plain; charset="UTF-8" Content-ID: <1F91AA95AD60A94CB36EADC865D1E81A@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 59c805a6-cd90-46ab-8ad4-08d6d26c58c9 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2019 21:46:50.5346 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3948 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] build: disable armv8 crypto extension X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190506214650.LAVv7kch617g1I-TEx7miBWYJHQ5J6bopSAKOCdIhLQ@z> > On May 3, 2019, at 10:50 AM, Yongseok Koh wrote: >=20 >> I think this change might have an impact on the existing users. Does thi= s >> change need to be documented somewhere (at least in the release notes)? >=20 > Practically, there would be no impact. Even if user's app makes use of cr= ypto > instructions, the build config of the app should have the flag. On IRC, I could see you concerned about the case where user app derives bui= ld flags from DPDK like apps under the examples directory. Yes, that's a valid concern. Thomas/Jerin, where could be the best spot to document it? Just release not= e? I think release note would be fine.