From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 6559FA05DC for ; Mon, 10 Jun 2019 03:39:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 845191BD7C; Mon, 10 Jun 2019 03:39:06 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 8CD5F1BD78 for ; Mon, 10 Jun 2019 03:39:04 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jun 2019 18:39:03 -0700 X-ExtLoop1: 1 Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga006.fm.intel.com with ESMTP; 09 Jun 2019 18:39:03 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 9 Jun 2019 18:39:02 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 9 Jun 2019 18:39:02 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.10]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.113]) with mapi id 14.03.0415.000; Mon, 10 Jun 2019 09:39:00 +0800 From: "Li, Xiaoyun" To: "Richardson, Bruce" CC: "Wu, Jingjing" , "Wiles, Keith" , "Liang, Cunming" , "Maslekar, Omkar" , "dev@dpdk.org" , "thomas@monjalon.net" Thread-Topic: [dpdk-dev] [PATCH v2 5/6] usertools/dpdk-devbind.py: add support for ntb Thread-Index: AQHVHDuX1PbfhImz50WD72FlyYKip6aNw6KAgAZdY4A= Date: Mon, 10 Jun 2019 01:38:59 +0000 Message-ID: References: <20190603084611.40931-1-xiaoyun.li@intel.com> <20190606074303.104108-1-xiaoyun.li@intel.com> <20190606074303.104108-6-xiaoyun.li@intel.com> <20190606082323.GA1586@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20190606082323.GA1586@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 5/6] usertools/dpdk-devbind.py: add support for ntb X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Well. Seems a good idea. I don't think there will be too many communication= devices or dma devices anyway. So use misc_devices? I can align with you. > -----Original Message----- > From: Richardson, Bruce > Sent: Thursday, June 6, 2019 16:23 > To: Li, Xiaoyun > Cc: Wu, Jingjing ; Wiles, Keith ; > Liang, Cunming ; Maslekar, Omkar > ; dev@dpdk.org; thomas@monjalon.net > Subject: Re: [dpdk-dev] [PATCH v2 5/6] usertools/dpdk-devbind.py: add sup= port > for ntb >=20 > On Thu, Jun 06, 2019 at 03:43:02PM +0800, Xiaoyun Li wrote: > > In order to allow binding/unbinding of devices for use by the > > ntb_rawdev, we need to update the devbind script to add a new class of > > device, and add device ids for the specific HW instances. And only > > support skx platform right now. > > > > Signed-off-by: Xiaoyun Li > > --- > > usertools/dpdk-devbind.py | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py > > index 9e79f0d28..3f7eafe28 100755 > > --- a/usertools/dpdk-devbind.py > > +++ b/usertools/dpdk-devbind.py > > @@ -36,11 +36,15 @@ > > octeontx2_npa =3D {'Class': '08', 'Vendor': '177d', 'Device': 'a0fb,a0= fc', > > 'SVendor': None, 'SDevice': None} > > > > +intel_ntb_skx =3D {'Class': '06', 'Vendor': '8086', 'Device': '201c', > > + 'SVendor': None, 'SDevice': None} > > + > > network_devices =3D [network_class, cavium_pkx, avp_vnic, ifpga_class] > > crypto_devices =3D [encryption_class, intel_processor_class] > > eventdev_devices =3D [cavium_sso, cavium_tim, octeontx2_sso] > > mempool_devices =3D [cavium_fpa, octeontx2_npa] compress_devices =3D > > [cavium_zip] > > +communication devices =3D [intel_ntb_skx] > > >=20 > Looking at this patch, and my own rawdev set for adding the ioat driver, = I > wonder if it's really a good idea to add new categories for each rawdev d= evice > type. Given we don't know how many device types there will be overall, I > wonder if it's better to just add a "misc" or "other" device type section= , where > we put all raw devices. >=20 > /Bruce