From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D107AA0471 for ; Tue, 18 Jun 2019 03:28:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ACD601BF79; Tue, 18 Jun 2019 03:28:58 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id DE8BA1BF55 for ; Tue, 18 Jun 2019 03:28:56 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jun 2019 18:28:55 -0700 X-ExtLoop1: 1 Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga007.jf.intel.com with ESMTP; 17 Jun 2019 18:28:55 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 17 Jun 2019 18:28:55 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 17 Jun 2019 18:28:55 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.87]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.173]) with mapi id 14.03.0439.000; Tue, 18 Jun 2019 09:28:52 +0800 From: "Li, Xiaoyun" To: "Wang, Xiao W" , "Wu, Jingjing" , "Wiles, Keith" , "Liang, Cunming" , "Maslekar, Omkar" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v5 1/6] raw/ntb: introduce ntb rawdev driver Thread-Index: AQHVIlfDgJa5cyOJMEGFZsnaOsgkH6afS2AAgAFaMhA= Date: Tue, 18 Jun 2019 01:28:52 +0000 Message-ID: References: <20190613075649.67472-1-xiaoyun.li@intel.com> <20190614021940.78631-1-xiaoyun.li@intel.com> <20190614021940.78631-2-xiaoyun.li@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 1/6] raw/ntb: introduce ntb rawdev driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Yes. Thanks for catching that. > -----Original Message----- > From: Wang, Xiao W > Sent: Monday, June 17, 2019 20:49 > To: Li, Xiaoyun ; Wu, Jingjing ; > Wiles, Keith ; Liang, Cunming > ; Maslekar, Omkar > Cc: dev@dpdk.org; Li, Xiaoyun > Subject: RE: [dpdk-dev] [PATCH v5 1/6] raw/ntb: introduce ntb rawdev driv= er >=20 > Hi, >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xiaoyun Li > > Sent: Friday, June 14, 2019 10:20 AM > > To: Wu, Jingjing ; Wiles, Keith > > ; Liang, Cunming ; > > Maslekar, Omkar > > Cc: dev@dpdk.org; Li, Xiaoyun > > Subject: [dpdk-dev] [PATCH v5 1/6] raw/ntb: introduce ntb rawdev > > driver > > > > Introduce rawdev driver support for NTB (Non-transparent Bridge) which > > can help to connect two separate hosts with each other. > > > > Signed-off-by: Xiaoyun Li > > --- > > config/common_base | 5 + > > drivers/raw/Makefile | 1 + > > drivers/raw/meson.build | 2 +- > > drivers/raw/ntb_rawdev/Makefile | 27 + > > drivers/raw/ntb_rawdev/meson.build | 7 + > > drivers/raw/ntb_rawdev/ntb_rawdev.c | 500 ++++++++++++++++++ > > drivers/raw/ntb_rawdev/ntb_rawdev.h | 158 ++++++ > > .../ntb_rawdev/rte_pmd_ntb_rawdev_version.map | 4 + > > mk/rte.app.mk | 1 + > > 9 files changed, 704 insertions(+), 1 deletion(-) create mode 100644 > > drivers/raw/ntb_rawdev/Makefile create mode 100644 > > drivers/raw/ntb_rawdev/meson.build > > create mode 100644 drivers/raw/ntb_rawdev/ntb_rawdev.c > > create mode 100644 drivers/raw/ntb_rawdev/ntb_rawdev.h > > create mode 100644 > > drivers/raw/ntb_rawdev/rte_pmd_ntb_rawdev_version.map > > > > diff --git a/config/common_base b/config/common_base index > > e406e7836..45e403130 100644 > > --- a/config/common_base > > +++ b/config/common_base > > @@ -746,6 +746,11 @@ > > CONFIG_RTE_LIBRTE_PMD_DPAA2_QDMA_RAWDEV=3Dn > > # > > CONFIG_RTE_LIBRTE_PMD_IFPGA_RAWDEV=3Dy > > > > +# > > +# Compile PMD for NTB raw device > > +# > > +CONFIG_RTE_LIBRTE_PMD_NTB_RAWDEV=3Dy > > + > > # > > # Compile librte_ring > > # > > diff --git a/drivers/raw/Makefile b/drivers/raw/Makefile index > > 8e29b4a56..efe61f451 100644 > > --- a/drivers/raw/Makefile > > +++ b/drivers/raw/Makefile > > @@ -10,5 +10,6 @@ DIRS- > > $(CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF_RAWDEV) +=3D dpaa2_cmdif > > DIRS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_QDMA_RAWDEV) +=3D dpaa2_qdma > endif > > DIRS-$(CONFIG_RTE_LIBRTE_PMD_IFPGA_RAWDEV) +=3D ifpga_rawdev > > +DIRS-$(CONFIG_RTE_LIBRTE_PMD_NTB_RAWDEV) +=3D ntb_rawdev > > > > include $(RTE_SDK)/mk/rte.subdir.mk > > diff --git a/drivers/raw/meson.build b/drivers/raw/meson.build index > > a61cdccef..6abf659d0 100644 > > --- a/drivers/raw/meson.build > > +++ b/drivers/raw/meson.build > > @@ -1,7 +1,7 @@ > > # SPDX-License-Identifier: BSD-3-Clause # Copyright 2018 NXP > > > > -drivers =3D ['skeleton_rawdev', 'dpaa2_cmdif', 'dpaa2_qdma', > > 'ifpga_rawdev'] > > +drivers =3D ['skeleton_rawdev', 'dpaa2_cmdif', 'dpaa2_qdma', > > +'ifpga_rawdev', > > 'ntb_rawdev'] > > std_deps =3D ['rawdev'] > > config_flag_fmt =3D 'RTE_LIBRTE_PMD_@0@_RAWDEV' > > driver_name_fmt =3D 'rte_pmd_@0@' > > diff --git a/drivers/raw/ntb_rawdev/Makefile > > b/drivers/raw/ntb_rawdev/Makefile new file mode 100644 index > > 000000000..fb40204c1 > > --- /dev/null > > +++ b/drivers/raw/ntb_rawdev/Makefile > > @@ -0,0 +1,27 @@ > > +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2019 Intel > > +Corporation > > + > > +include $(RTE_SDK)/mk/rte.vars.mk > > + > > +# > > +# library name > > +# > > +LIB =3D librte_pmd_ntb_rawdev.a > > + > > +CFLAGS +=3D -DALLOW_EXPERIMENTAL_API > > +CFLAGS +=3D -O3 > > +CFLAGS +=3D $(WERROR_FLAGS) > > +LDLIBS +=3D -lrte_eal -lrte_mbuf -lrte_mempool LDLIBS +=3D -lrte_pci > > +-lrte_bus_pci LDLIBS +=3D -lrte_rawdev > > + > > +EXPORT_MAP :=3D rte_pmd_ntb_rawdev_version.map > > + > > +LIBABIVER :=3D 1 > > + > > +# > > +# all source are stored in SRCS-y > > +# > > +SRCS-$(CONFIG_RTE_LIBRTE_PMD_SKELETON_RAWDEV) +=3D ntb_rawdev.c >=20 > Is it a typo? I think it should be CONFIG_RTE_LIBRTE_PMD_NTB_RAWDEV >=20 > BRs, > Xiao >=20 > > + > > +include $(RTE_SDK)/mk/rte.lib.mk > > diff --git a/drivers/raw/ntb_rawdev/meson.build > > b/drivers/raw/ntb_rawdev/meson.build > > new file mode 100644 > > index 000000000..ca905049d > [...]