From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 7A446A0487
	for <public@inbox.dpdk.org>; Tue,  2 Jul 2019 03:18:56 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 4115A1B9A3;
	Tue,  2 Jul 2019 03:18:55 +0200 (CEST)
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 27F23F04
 for <dev@dpdk.org>; Tue,  2 Jul 2019 03:18:52 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 01 Jul 2019 18:18:51 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.63,441,1557212400"; d="scan'208";a="190456798"
Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203])
 by fmsmga002.fm.intel.com with ESMTP; 01 Jul 2019 18:18:51 -0700
Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by
 FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Mon, 1 Jul 2019 18:18:50 -0700
Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by
 FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Mon, 1 Jul 2019 18:18:50 -0700
Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.134]) by
 SHSMSX105.ccr.corp.intel.com ([169.254.11.232]) with mapi id 14.03.0439.000;
 Tue, 2 Jul 2019 09:18:48 +0800
From: "Li, Xiaoyun" <xiaoyun.li@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Wu, Jingjing" <jingjing.wu@intel.com>,
 "Wiles, Keith" <keith.wiles@intel.com>, "Liang, Cunming"
 <cunming.liang@intel.com>, "Maslekar, Omkar" <omkar.maslekar@intel.com>,
 "Mcnamara, John" <john.mcnamara@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v9 6/6] doc: update docs for ntb driver
Thread-Index: AQHVLVzjdTiJ0KacRU+1Abzkx75Bjaa1UIqAgAE834A=
Date: Tue, 2 Jul 2019 01:18:48 +0000
Message-ID: <B9E724F4CB7543449049E7AE7669D82F0B27B608@SHSMSX101.ccr.corp.intel.com>
References: <20190626071224.4819-1-xiaoyun.li@intel.com>
 <20190628025346.31312-1-xiaoyun.li@intel.com>
 <20190628025346.31312-7-xiaoyun.li@intel.com> <1786606.cqeaev8LP1@xps>
In-Reply-To: <1786606.cqeaev8LP1@xps>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v9 6/6] doc: update docs for ntb driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Got it. Thanks.

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Monday, July 1, 2019 22:24
> To: Li, Xiaoyun <xiaoyun.li@intel.com>
> Cc: dev@dpdk.org; Wu, Jingjing <jingjing.wu@intel.com>; Wiles, Keith
> <keith.wiles@intel.com>; Liang, Cunming <cunming.liang@intel.com>; Maslek=
ar,
> Omkar <omkar.maslekar@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v9 6/6] doc: update docs for ntb driver
>=20
> 28/06/2019 04:53, Xiaoyun Li:
> > +NTB Rawdev
> > +M: Xiaoyun Li <xiaoyun.li@intel.com>
> > +M: Jingjing Wu <jingjing.wu@intel.com>
> > +F: drivers/raw/ntb_rawdev/
> > +F: doc/guides/rawdevs/ntb_rawdev.rst
>=20
> Please update MAINTAINERS while introducing files in previous patches.
>=20
> > +++ b/doc/guides/rawdevs/ntb_rawdev.rst
> > +And this PMD only supports intel skylake platform.
>=20
> I guess the platform name require some uppercase or other characters.
> Please request a full review of the doc by Intel colleagues.
>=20
> > --- a/doc/guides/rel_notes/release_19_08.rst
> > +++ b/doc/guides/rel_notes/release_19_08.rst
> > +* **Introduced NTB PMD.**
> > +
> > +  The PMD provided a non-transparent bridge between two separate
> > + hosts so  that they can communicate with each other. Thus, many user
> > + cases can  benefit from this, such as fault tolerance and visual acce=
leration.
> > +
> > +  This PMD implemented the following features:
> > +  * Handshake for device start and stop between two hosts.
> > +  * Memory allocation for the peer to access and read/write allocated
> > +    memory from peer.
> > +  * Use doorbell registers to notify the peer and share some informati=
on
> > +    by using scratchpad registers.
> > +
> > +  But the PMD hasn't implemented FIFO. The FIFO will come in 19.11 rel=
ease.
> > +  And this PMD only supports intel skylake platform.
>=20
> You don't need to repeat the full doc in the release notes.
> Please make it shorter.
> And please update the release notes in the same patch as the code.
>=20
> Thanks
>=20