Re: [dpdk-dev] [PATCH v2] examples/tep_termination: resolve unchecked return value

["Li, Xiaoyun" <xiaoyun.li@intel.com>]

> -----Original Message-----
> From: T D, Shashank
> Sent: Wednesday, November 27, 2019 12:04
> To: dev@dpdk.org
> Cc: Li, Xiaoyun <xiaoyun.li@intel.com>
> Subject: [PATCH v2] examples/tep_termination: resolve unchecked return value
> 
> This patch checked the return value of rte_eth_dev_info_get function.
> Coverity issue: 349922
> 
> Signed-off-by: Shashank T D <shashank.t.d@intel.com>
> ---
>  examples/tep_termination/vxlan_setup.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/examples/tep_termination/vxlan_setup.c
> b/examples/tep_termination/vxlan_setup.c
> index eca119a72..384b3167e 100644
> --- a/examples/tep_termination/vxlan_setup.c
> +++ b/examples/tep_termination/vxlan_setup.c
> @@ -195,7 +195,12 @@ vxlan_port_init(uint16_t port, struct rte_mempool
> *mbuf_pool)
> 
>  	if (tso_segsz != 0) {
>  		struct rte_eth_dev_info dev_info;
> -		rte_eth_dev_info_get(port, &dev_info);
> +		retval = rte_eth_dev_info_get(port, &dev_info);
> +		if (retval != 0)
> +			rte_exit(EXIT_FAILURE,
> +
> 	"Error during getting device (port %u) info: %s\n",
> +				port, strerror(-retval));
> +
>  		if ((dev_info.tx_offload_capa & DEV_TX_OFFLOAD_TCP_TSO)
> == 0)
>  			RTE_LOG(WARNING, PORT,
>  				"hardware TSO offload is not supported\n");
> --
> 2.17.1

Acked-by: Xiaoyun Li <Xiaoyun.li@intel.com>