From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 95B5810BD for ; Tue, 18 Sep 2018 03:28:24 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Sep 2018 18:28:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,387,1531810800"; d="scan'208";a="86968277" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 17 Sep 2018 18:28:22 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 17 Sep 2018 18:28:22 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 17 Sep 2018 18:28:22 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.205]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.143]) with mapi id 14.03.0319.002; Tue, 18 Sep 2018 09:28:20 +0800 From: "Li, Xiaoyun" To: Thomas Monjalon , "Yigit, Ferruh" CC: "Xing, Beilei" , "Zhang, Qi Z" , "dev@dpdk.org" , "Yang, Zhiyong" , "Richardson, Bruce" Thread-Topic: [PATCH v6] net/i40e: add interface to use latest vec path Thread-Index: AQHUTm64snTzymvKskaedRr4W2vF86Tz/qiAgAAGPgCAATvJcA== Date: Tue, 18 Sep 2018 01:28:19 +0000 Message-ID: References: <1535595399-430873-1-git-send-email-xiaoyun.li@intel.com> <20180917095807.14421-1-xiaoyun.li@intel.com> <5f583daf-cd66-e675-667f-dc7dabbae97b@intel.com> <1809280.mxVWNlHP3Y@xps> In-Reply-To: <1809280.mxVWNlHP3Y@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6] net/i40e: add interface to use latest vec path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Sep 2018 01:28:25 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Monday, September 17, 2018 22:37 > To: Yigit, Ferruh > Cc: Li, Xiaoyun ; Xing, Beilei ; > Zhang, Qi Z ; dev@dpdk.org; Yang, Zhiyong > ; Richardson, Bruce > Subject: Re: [PATCH v6] net/i40e: add interface to use latest vec path >=20 > 17/09/2018 16:14, Ferruh Yigit: > > On 9/17/2018 10:58 AM, Xiaoyun Li wrote: > > > @@ -1078,6 +1078,9 @@ struct i40e_adapter { > > > uint64_t pctypes_tbl[I40E_FLOW_TYPE_MAX] > __rte_cache_min_aligned; > > > uint64_t flow_types_mask; > > > uint64_t pctypes_mask; > > > + > > > + /* For devargs */ > > > + bool use_latest_vec; > > > > For this one checkpatch is giving following warning: > > > > CHECK:BOOL_MEMBER: Avoid using bool structure members because of > > possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 > > > > The comment in the link seems valid. What do you think using a basic > > storage type for the variable, like uint8_t? > > > > > > And overall is there any objection to follow this new convention? >=20 > I agree with avoiding bool in structs. >=20 OK. Thanks!