Re: [dpdk-dev] [PATCH] ethdev: get rxq interrupt fd

["Li, Xiaoyun" <xiaoyun.li@intel.com>]

OK. Thanks.

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Friday, September 28, 2018 16:33
> To: Li, Xiaoyun <xiaoyun.li@intel.com>; thomas@monjalon.net; Zhang, Helin
> <helin.zhang@intel.com>; damarion@cisco.com; Kinsella, Ray
> <ray.kinsella@intel.com>; dev@dpdk.org
> Subject: Re: [PATCH] ethdev: get rxq interrupt fd
> 
> On 9/28/2018 4:43 AM, Xiaoyun Li wrote:
> > Some users want to use their own epoll instances to control both DPDK
> > rxq interrupt fds and their own other fds. So added a function to get
> > rxq interrupt fd based on port id and queue id.
> >
> > Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> 
> <...>
> 
> > @@ -2719,6 +2719,9 @@ int rte_eth_dev_rx_intr_ctl(uint16_t port_id,
> > int epfd, int op, void *data);  int rte_eth_dev_rx_intr_ctl_q(uint16_t
> port_id, uint16_t queue_id,
> >  			      int epfd, int op, void *data);
> >
> > +int rte_eth_dev_rx_intr_ctl_q_get_fd(uint16_t port_id, uint16_t
> queue_id,
> > +				     int *fd);
> 
> 
> Hi Xiaoyun,
> 
> API is missing documentation, please add doxygen comments.
> 
> New APIs need to be experimental, at least for one release.
> Also can you please add it to .map file otherwise shared lib build will fail