From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 547935F35 for ; Sat, 29 Sep 2018 10:41:14 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Sep 2018 01:41:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,319,1534834800"; d="scan'208";a="266996109" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga005.fm.intel.com with ESMTP; 29 Sep 2018 01:41:00 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 29 Sep 2018 01:41:00 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 29 Sep 2018 01:41:00 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.220]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.27]) with mapi id 14.03.0319.002; Sat, 29 Sep 2018 16:40:58 +0800 From: "Li, Xiaoyun" To: "Xing, Beilei" , "Zhang, Qi Z" , "Yigit, Ferruh" CC: "dev@dpdk.org" Thread-Topic: [PATCH v2] net/i40e: select fdir config automatically Thread-Index: AQHUVxwUsD1mcAAtd0q/0QaNY/m8JqUGateAgACG6cA= Date: Sat, 29 Sep 2018 08:40:58 +0000 Message-ID: References: <20180928072453.6348-1-xiaoyun.li@intel.com> <20180928110303.90561-1-xiaoyun.li@intel.com> <94479800C636CB44BD422CB454846E013224C3C2@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <94479800C636CB44BD422CB454846E013224C3C2@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: select fdir config automatically X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Sep 2018 08:41:14 -0000 > -----Original Message----- > From: Xing, Beilei > Sent: Saturday, September 29, 2018 16:37 > To: Li, Xiaoyun ; Zhang, Qi Z ; > Yigit, Ferruh > Cc: dev@dpdk.org > Subject: RE: [PATCH v2] net/i40e: select fdir config automatically >=20 >=20 >=20 > > -----Original Message----- > > From: Li, Xiaoyun > > Sent: Friday, September 28, 2018 7:03 PM > > To: Xing, Beilei ; Zhang, Qi Z > > ; Yigit, Ferruh > > Cc: dev@dpdk.org; Li, Xiaoyun > > Subject: [PATCH v2] net/i40e: select fdir config automatically > > > > I40e driver needed users to config exact fdir mode to create rte_flow > > rules but it shouldn't. This patch allows users to create rte_flow > > rules without configuring fdir mode and let the driver select the > > config automatically. And remove the workaround in flow_filtering > example. > > > > Signed-off-by: Xiaoyun Li > > --- > > v2: > > * Added fdir teardown in i40e_flow_flush_fdir_filter. > > * Replace TAILQ_FIRST with TAILQ_EMPTY which is more intuitive. > > * Remove the workaround in flow_filtering example since the driver > > will > > * set the fdir config automatically. > > + > > + /* If the last flow is destroyed, disable fdir. */ > > + if (!ret && !TAILQ_EMPTY(&pf->fdir.fdir_list)) { >=20 > Should be if (!ret && TAILQ_EMPTY(&pf->fdir.fdir_list)) here? Yes. Sorry about that. Will correct it. >=20 > > -- > > 2.17.1