Re: [dpdk-dev] [PATCH v6 00/10] vhost: support inflight share memory protocol feature

["Yu, Jin" <jin.yu@intel.com>]

> -----Original Message-----
> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> Sent: Saturday, September 7, 2019 12:36 AM
> To: Yu, Jin <jin.yu@intel.com>; dev@dpdk.org
> Cc: Liu, Changpeng <changpeng.liu@intel.com>; Bie, Tiwei
> <tiwei.bie@intel.com>; Wang, Zhihong <zhihong.wang@intel.com>
> Subject: Re: [PATCH v6 00/10] vhost: support inflight share memory protocol
> feature
> 
> 
> 
> On 8/29/19 4:12 PM, JinYu wrote:
> > This patches introduces two new messages
> VHOST_USER_GET_INFLIGHT_FD
> > and VHOST_USER_SET_INFLIGHT_FD to support transferring a shared
> buffer
> > between qemu and backend for backend reconnection.
> > Now It can both support split and packed ring. The example code show
> > how these APIs work. The test has passed.
> >
> > How to test the example:
> > 1, Qemu need a patch.
> > https://patchwork.kernel.org/patch/10861411/
> > it also needs some manual modifications:
> > we should confirm that before we send get inflight we have already
> > sent the set features but it seems Qemu didn't do like this. So we
> > manually revise this, we can add below code in vhost_dev_get_inflight
> >     int r;
> >
> >     r = vhost_dev_set_features(dev, dev->log_enabled);
> >     if (r < 0) {
> >         return -errno;
> >     }
> 
> Are you working on fixing that upstream?
> What happens if we don't do these modifications and apply your series?
> Would it be considered as a regression?
Hi  Maxime,
	Actually I didn't fix the upstream.
	Without these modifications, get_inflight_fd and set_inflight_fd can't confirm the dev packet format.
	So the inflight ring format may always be split.
Thanks.