From: "Zhang, Tianfei" <tianfei.zhang@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Pattan, Reshma" <reshma.pattan@intel.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Shreyansh Jain <shreyansh.jain@nxp.com>,
Ashish Gupta <ashish.gupta@cavium.com>,
"Trahe, Fiona" <fiona.trahe@intel.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
Akhil Goyal <akhil.goyal@nxp.com>,
"Doherty, Declan" <declan.doherty@intel.com>,
"Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
Jerin Jacob <jerin.jacob@caviumnetworks.com>,
Chas Williams <chas3@att.com>,
"Rahul Lakkireddy" <rahul.lakkireddy@chelsio.com>,
John Daley <johndale@cisco.com>,
Hyong Youb Kim <hyonkim@cisco.com>,
Gaetan Rivet <gaetan.rivet@6wind.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Wang, Xiao W" <xiao.w.wang@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
Rasesh Mody <rasesh.mody@cavium.com>,
Harish Patil <harish.patil@cavium.com>,
"Shahed Shaikh" <shahed.shaikh@cavium.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
"Singh, Jasvinder" <jasvinder.singh@intel.com>,
"Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
"Wiles, Keith" <keith.wiles@intel.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
"Bie, Tiwei" <tiwei.bie@intel.com>,
"Wang, Zhihong" <zhihong.wang@intel.com>,
Nipun Gupta <nipun.gupta@nxp.com>,
"Xu, Rosen" <rosen.xu@intel.com>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
"Rao, Nikhil" <nikhil.rao@intel.com>,
Olivier Matz <olivier.matz@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] fix static variables
Date: Wed, 10 Oct 2018 06:23:14 +0000 [thread overview]
Message-ID: <BA6F50564D52C24884F9840E07E32DEC4DF57B44@CDSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20181004034047.26824-1-ferruh.yigit@intel.com>
> diff --git a/drivers/raw/ifpga_rawdev/base/ifpga_enumerate.c
> b/drivers/raw/ifpga_rawdev/base/ifpga_enumerate.c
> index f0939dc32..848e5183a 100644
> --- a/drivers/raw/ifpga_rawdev/base/ifpga_enumerate.c
> +++ b/drivers/raw/ifpga_rawdev/base/ifpga_enumerate.c
> @@ -104,14 +104,14 @@ static struct feature_info port_features[] = {
> .resource_size = sizeof(struct feature_port_header),
> .feature_index = PORT_FEATURE_ID_HEADER,
> .revision_id = PORT_HEADER_REVISION,
> - .ops = &port_hdr_ops,
> + .ops = &ifpga_rawdev_port_hdr_ops,
> },
> {
> .name = PORT_FEATURE_ERR,
> .resource_size = sizeof(struct feature_port_error),
> .feature_index = PORT_FEATURE_ID_ERROR,
> .revision_id = PORT_ERR_REVISION,
> - .ops = &port_error_ops,
> + .ops = &ifpga_rawdev_port_error_ops,
> },
> {
> .name = PORT_FEATURE_UMSG,
> @@ -124,14 +124,14 @@ static struct feature_info port_features[] = {
> .resource_size = sizeof(struct feature_port_uint),
> .feature_index = PORT_FEATURE_ID_UINT,
> .revision_id = PORT_UINT_REVISION,
> - .ops = &port_uint_ops,
> + .ops = &ifpga_rawdev_port_uint_ops,
> },
> {
> .name = PORT_FEATURE_STP,
> .resource_size = PORT_FEATURE_STP_REGION_SIZE,
> .feature_index = PORT_FEATURE_ID_STP,
> .revision_id = PORT_STP_REVISION,
> - .ops = &port_stp_ops,
> + .ops = &ifpga_rawdev_port_stp_ops,
> },
> {
> .name = PORT_FEATURE_UAFU,
> diff --git a/drivers/raw/ifpga_rawdev/base/ifpga_feature_dev.h
> b/drivers/raw/ifpga_rawdev/base/ifpga_feature_dev.h
> index 7a39a580c..4391f2fdf 100644
> --- a/drivers/raw/ifpga_rawdev/base/ifpga_feature_dev.h
> +++ b/drivers/raw/ifpga_rawdev/base/ifpga_feature_dev.h
> @@ -156,10 +156,10 @@ struct fpga_uafu_irq_set {
>
> int port_set_irq(struct ifpga_port_hw *port, u32 feature_id, void *irq_set);
>
> -extern struct feature_ops port_hdr_ops;
> -extern struct feature_ops port_error_ops;
> -extern struct feature_ops port_stp_ops;
> -extern struct feature_ops port_uint_ops;
> +extern struct feature_ops ifpga_rawdev_port_hdr_ops;
> +extern struct feature_ops ifpga_rawdev_port_error_ops;
> +extern struct feature_ops ifpga_rawdev_port_stp_ops;
> +extern struct feature_ops ifpga_rawdev_port_uint_ops;
>
> /* help functions for feature ops */
> int fpga_msix_set_block(struct feature *feature, unsigned int start,
> diff --git a/drivers/raw/ifpga_rawdev/base/ifpga_port.c
> b/drivers/raw/ifpga_rawdev/base/ifpga_port.c
> index a962f5b45..8b5668d49 100644
> --- a/drivers/raw/ifpga_rawdev/base/ifpga_port.c
> +++ b/drivers/raw/ifpga_rawdev/base/ifpga_port.c
> @@ -326,7 +326,7 @@ static int port_hdr_set_prop(struct feature *feature,
> struct feature_prop *prop)
> return -ENOENT;
> }
>
> -struct feature_ops port_hdr_ops = {
> +struct feature_ops ifpga_rawdev_port_hdr_ops = {
> .init = port_hdr_init,
> .uinit = port_hdr_uinit,
> .get_prop = port_hdr_get_prop,
> @@ -354,7 +354,7 @@ static void port_stp_uinit(struct feature *feature)
> dev_info(NULL, "port stp uinit.\n");
> }
>
> -struct feature_ops port_stp_ops = {
> +struct feature_ops ifpga_rawdev_port_stp_ops = {
> .init = port_stp_init,
> .uinit = port_stp_uinit,
> };
> @@ -382,7 +382,7 @@ static void port_uint_uinit(struct feature *feature)
> dev_info(NULL, "PORT UINT UInit.\n");
> }
>
> -struct feature_ops port_uint_ops = {
> +struct feature_ops ifpga_rawdev_port_uint_ops = {
> .init = port_uint_init,
> .uinit = port_uint_uinit,
> };
> diff --git a/drivers/raw/ifpga_rawdev/base/ifpga_port_error.c
> b/drivers/raw/ifpga_rawdev/base/ifpga_port_error.c
> index 23db562b8..9dd1cf590 100644
> --- a/drivers/raw/ifpga_rawdev/base/ifpga_port_error.c
> +++ b/drivers/raw/ifpga_rawdev/base/ifpga_port_error.c
> @@ -136,7 +136,7 @@ static int port_error_set_prop(struct feature
> *feature,
> return -ENOENT;
> }
>
> -struct feature_ops port_error_ops = {
> +struct feature_ops ifpga_rawdev_port_error_ops = {
> .init = port_error_init,
> .uinit = port_error_uinit,
> .get_prop = port_error_get_prop,
This patch is the same as " [PATCH v2 2/4] drivers: prefix global variables with module name ",
I have acked at that patch.
next prev parent reply other threads:[~2018-10-10 6:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 3:40 Ferruh Yigit
2018-10-05 8:38 ` Rao, Nikhil
2018-10-05 16:26 ` [dpdk-dev] [PATCH v2 1/4] add missing static keyword to globals Ferruh Yigit
2018-10-05 15:55 ` Andrew Rybchenko
2018-10-28 11:04 ` Thomas Monjalon
2018-10-05 16:26 ` [dpdk-dev] [PATCH v2 2/4] drivers: prefix global variables with module name Ferruh Yigit
2018-10-05 16:27 ` Maxime Coquelin
2018-10-08 12:18 ` Shreyansh Jain
2018-10-10 5:56 ` Zhang, Tianfei
2018-10-05 16:26 ` [dpdk-dev] [PATCH v2 3/4] fix global variable issues Ferruh Yigit
2018-10-07 12:21 ` Jerin Jacob
2018-10-05 16:26 ` [dpdk-dev] [PATCH v2 4/4] lib: reduce global variable usage Ferruh Yigit
2018-10-07 12:22 ` Jerin Jacob
2018-10-08 8:45 ` Shreyansh Jain
2018-10-08 9:11 ` Ferruh Yigit
2018-10-08 9:27 ` Shreyansh Jain
2018-10-07 12:18 ` [dpdk-dev] [PATCH v2 1/4] add missing static keyword to globals Jerin Jacob
2018-10-08 9:43 ` Shreyansh Jain
2018-10-28 23:57 ` [dpdk-dev] [PATCH v3 " Ferruh Yigit
2018-10-28 23:57 ` [dpdk-dev] [PATCH v3 2/4] drivers: prefix global variables with module name Ferruh Yigit
2018-10-28 23:57 ` [dpdk-dev] [PATCH v3 3/4] fix global variable issues Ferruh Yigit
2018-10-29 6:57 ` Hyong Youb Kim
2018-10-28 23:57 ` [dpdk-dev] [PATCH v3 4/4] lib: reduce global variable usage Ferruh Yigit
2018-10-29 1:35 ` Thomas Monjalon
2018-10-10 6:23 ` Zhang, Tianfei [this message]
2018-10-11 6:56 ` [dpdk-dev] [PATCH] fix static variables Xing, Beilei
2018-11-02 10:58 ` [dpdk-dev] " Tomasz Cel
2018-11-02 11:09 ` Cel, TomaszX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BA6F50564D52C24884F9840E07E32DEC4DF57B44@CDSMSX104.ccr.corp.intel.com \
--to=tianfei.zhang@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=anatoly.burakov@intel.com \
--cc=arybchenko@solarflare.com \
--cc=ashish.gupta@cavium.com \
--cc=beilei.xing@intel.com \
--cc=chas3@att.com \
--cc=cristian.dumitrescu@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=fiona.trahe@intel.com \
--cc=gaetan.rivet@6wind.com \
--cc=harish.patil@cavium.com \
--cc=hemant.agrawal@nxp.com \
--cc=hyonkim@cisco.com \
--cc=jasvinder.singh@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=johndale@cisco.com \
--cc=keith.wiles@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=nikhil.rao@intel.com \
--cc=nipun.gupta@nxp.com \
--cc=olivier.matz@6wind.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=rasesh.mody@cavium.com \
--cc=reshma.pattan@intel.com \
--cc=rosen.xu@intel.com \
--cc=roy.fan.zhang@intel.com \
--cc=shahed.shaikh@cavium.com \
--cc=shreyansh.jain@nxp.com \
--cc=thomas@monjalon.net \
--cc=tiwei.bie@intel.com \
--cc=wenzhuo.lu@intel.com \
--cc=xiao.w.wang@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).