From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 3FE6B2BD7 for ; Thu, 24 Mar 2016 09:40:31 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP; 24 Mar 2016 01:40:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,384,1455004800"; d="scan'208";a="770481400" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga003.jf.intel.com with ESMTP; 24 Mar 2016 01:40:15 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.157]) by IRSMSX103.ger.corp.intel.com ([169.254.3.239]) with mapi id 14.03.0248.002; Thu, 24 Mar 2016 08:40:13 +0000 From: "Fischetti, Antonio" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "De Lara Guarch, Pablo" Thread-Topic: [dpdk-dev] [PATCH v2] ixgbe: add check for tx queue number Thread-Index: AQHRhRjN4uB6cX9800mWdLo0lMdWvp9oRm/A Date: Thu, 24 Mar 2016 08:40:12 +0000 Message-ID: References: <1458634121-1808-1-git-send-email-wenzhuo.lu@intel.com> <1458746929-87915-1-git-send-email-pablo.de.lara.guarch@intel.com> In-Reply-To: <1458746929-87915-1-git-send-email-pablo.de.lara.guarch@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDQ0Yzk1ZWMtNjY2MC00ZTliLTk3OTYtNGNmYTQ4MWQ3NjZjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InZuSG9RekZaVmtMYlRyTG5xZzJ3cFVQb1VcL0hObjNleGdKXC8xOXB4bWpZdz0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: add check for tx queue number X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Mar 2016 08:40:31 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara > Sent: Wednesday, March 23, 2016 3:29 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; De Lara Guarch, Pablo > > Subject: [dpdk-dev] [PATCH v2] ixgbe: add check for tx queue number >=20 > IXGBE supports 128 TX queues. However, the full 128 queues > are only available in VT and DCB mode. > In normal default "none" mode (VT/DCB off) the maximum number > of available queues is only 64. > IXGBE doesn't check the mode when reporting the available > number of queues. If a queue larger than 64 is used in default mode, > the TX packets will be dropped silently. >=20 > This change adds a check to forbid using a queue number larger than 64 > during device configuration (in default mode), so that the problem is > reported as early as possible. > It also changes the order of where the dev_conf parameters are copied > into the dev structure so that the correct maximum number of queues > is reported for the correct mode. >=20 > Signed-off-by: Wenzhuo Lu > Signed-off-by: Pablo de Lara Tested-by: Antonio Fischetti