From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id A83E15A54 for ; Sat, 26 Mar 2016 10:11:03 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 26 Mar 2016 02:11:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,395,1455004800"; d="scan'208";a="941863156" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga002.jf.intel.com with ESMTP; 26 Mar 2016 02:11:03 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX153.ger.corp.intel.com (163.33.192.75) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sat, 26 Mar 2016 09:11:01 +0000 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.157]) by irsmsx155.ger.corp.intel.com ([169.254.14.201]) with mapi id 14.03.0248.002; Sat, 26 Mar 2016 09:11:00 +0000 From: "Fischetti, Antonio" To: "Mcnamara, John" , "De Lara Guarch, Pablo" , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Richardson, Bruce" , "De Lara Guarch, Pablo" Thread-Topic: [dpdk-dev] [PATCH v4 3/3] ixgbe: fix incorrect max tx queue number Thread-Index: AQHRheEQaRr/VUrajE6uJOlDJlMHsp9o0PAAgAKhqsA= Date: Sat, 26 Mar 2016 09:10:59 +0000 Message-ID: References: <1458832675-666-1-git-send-email-pablo.de.lara.guarch@intel.com> <1458832924-1489-1-git-send-email-pablo.de.lara.guarch@intel.com> <1458832924-1489-4-git-send-email-pablo.de.lara.guarch@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODcxMzc2ZDMtZTcyMi00MzQzLWJmOGYtZTRmY2IyZWUxZWViIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkNrM00rYVRIMXI2OUdKVDBjVHRlelM1U0o5SzdlYVhVcWc3VlV4NWdDYUU9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 3/3] ixgbe: fix incorrect max tx queue number X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Mar 2016 09:11:04 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mcnamara, John > Sent: Thursday, March 24, 2016 4:58 PM > To: De Lara Guarch, Pablo ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Richardson, Bruce > ; De Lara Guarch, Pablo > > Subject: Re: [dpdk-dev] [PATCH v4 3/3] ixgbe: fix incorrect max tx queue > number >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara > > Sent: Thursday, March 24, 2016 3:22 PM > > To: dev@dpdk.org > > Cc: Lu, Wenzhuo ; Richardson, Bruce > > ; De Lara Guarch, Pablo > > > > Subject: [dpdk-dev] [PATCH v4 3/3] ixgbe: fix incorrect max tx queue > > number > > > > From: Wenzhuo Lu > > > > IXGBE supports 128 TX queues. However, the full 128 queues are only > > available in VT and DCB mode. > > In normal default "none" mode (VT/DCB off) the maximum number of > available > > queues is only 64. > > IXGBE doesn't check the mode when reporting the available number of > > queues. If a queue larger than 64 is used in default mode, the TX packe= ts > > will be dropped silently. > > > > This change adds a check to forbid using a queue number larger than 64 > > during device configuration (in default mode), so that the problem is > > reported as early as possible. > > > > Signed-off-by: Wenzhuo Lu > > Signed-off-by: Pablo de Lara >=20 > Acked-by: John McNamara Tested-by: Antonio Fischetti