From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id ED61B235 for ; Fri, 7 Jul 2017 19:01:24 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jul 2017 10:01:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,323,1496127600"; d="scan'208";a="284263977" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 07 Jul 2017 10:00:24 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 7 Jul 2017 10:00:24 -0700 Received: from fmsmsx115.amr.corp.intel.com ([169.254.4.195]) by fmsmsx123.amr.corp.intel.com ([169.254.7.80]) with mapi id 14.03.0319.002; Fri, 7 Jul 2017 10:00:24 -0700 From: "Carrillo, Erik G" To: "Mcnamara, John" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] doc: add new targets to "make help" output Thread-Index: AQHS3uQI/3jm+1FVK0KpcuaMyh/tMqI33BWAgBDqoDA= Date: Fri, 7 Jul 2017 17:00:23 +0000 Message-ID: References: <1496699017-98327-1-git-send-email-erik.g.carrillo@intel.com> <1496767364-19421-1-git-send-email-erik.g.carrillo@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzY1MTE5MjUtYzNlNC00ZGY5LWJkYmUtMzYzMmNmNWExMDU4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImxjSWdXOERzSGg4d000Nkt6VDJKdGY3SXJFMUx3dExRdXlGcDhQU2xhdGs9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.107] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] doc: add new targets to "make help" output X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jul 2017 17:01:25 -0000 Response in-line: > -----Original Message----- > From: Mcnamara, John > Sent: Monday, June 26, 2017 10:38 AM > To: Carrillo, Erik G ; thomas@monjalon.net > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] doc: add new targets to "make help" > output >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Gabriel Carrillo > > Sent: Tuesday, June 6, 2017 5:43 PM > > To: thomas@monjalon.net > > Cc: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH v2] doc: add new targets to "make help" > > output > > > > Commit aafaea3d3b70 ("devtools: add tags and cscope index generation") > > introduced new make targets. This change updates the help target > > output to reflect the additions. > > > > Signed-off-by: Gabriel Carrillo > > --- > > doc/build-sdk-quick.txt | 21 +++++++++++---------- > > 1 file changed, 11 insertions(+), 10 deletions(-) > > > > diff --git a/doc/build-sdk-quick.txt b/doc/build-sdk-quick.txt index > > 8d41052..8ed9d80 100644 > > --- a/doc/build-sdk-quick.txt > > +++ b/doc/build-sdk-quick.txt > > @@ -1,16 +1,17 @@ > > Basic build > > make config T=3Dx86_64-native-linuxapp-gcc && make Build > commands > > - config get configuration from target template (T=3D) > > - all same as build (default rule) > > - build build in a configured directory > > - clean remove files but keep configuration > > - install T=3D configure, build and install a target in DESTDIR > > - install install optionally staged in DESTDIR > > - examples build examples for given targets (T=3D) > > - examples_clean clean examples for given targets (T=3D) > > - test compile tests and run basic unit tests > > - test-* run specific subset of unit tests > > + config get configuration from target template (T=3D) > > + all same as build (default rule) > > + build build in a configured directory > > + clean remove files but keep configuration > > + install T=3D configure, build and install a target in DESTDIR > > + install install optionally staged in DESTDIR > > + examples build examples for given targets (T=3D) > > + examples_clean clean examples for given targets (T=3D) > > + test compile tests and run basic unit tests > > + test-* run specific subset of unit tests > > + tags|gtags|cscope [T=3D] generate tags or cscope index > > Build variables > > EXTRA_CPPFLAGS preprocessor options > > EXTRA_CFLAGS compiler options > > -- >=20 > Hi, >=20 > Thanks for this. Unfortunately there is a mix of tabs and spaces used for= the > alignment so the output cat look funny depending on tab settings. >=20 > I know that Thomas commented that the previous version was too verbose > but it looked better to me. Maybe we could compromise on: >=20 > tags|gtags T=3D generate tags/gtags for given targets (T=3D) > cscope T=3D generate cscope database for given targets (T=3D) >=20 > John >=20 Thanks for the feedback, John. I'll submit an updated patch. Regards, Gabriel