From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 7A50D1B235 for ; Mon, 9 Oct 2017 22:30:37 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Oct 2017 13:30:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,501,1500966000"; d="scan'208";a="1228882930" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga002.fm.intel.com with ESMTP; 09 Oct 2017 13:30:36 -0700 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 9 Oct 2017 13:30:36 -0700 Received: from fmsmsx115.amr.corp.intel.com ([169.254.4.50]) by FMSMSX125.amr.corp.intel.com ([169.254.2.126]) with mapi id 14.03.0319.002; Mon, 9 Oct 2017 13:30:36 -0700 From: "Carrillo, Erik G" To: Jerin Jacob CC: "dev@dpdk.org" , "Richardson, Bruce" , "Van Haaren, Harry" , "hemant.agrawal@nxp.com" , "nipun.gupta@nxp.com" , "Vangati, Narender" , "Rao, Nikhil" , "pbhagavatula@caviumnetworks.com" , "Eads, Gage" Thread-Topic: [RFC PATCH v2 0/1] eventtimer: introduce event timer adapter Thread-Index: AQHTPFU9hJTRCPtWNUuCjLI3ncbr+qLcAGiA Date: Mon, 9 Oct 2017 20:30:35 +0000 Message-ID: References: <20170817161104.24293-1-jerin.jacob@caviumnetworks.com> <1506093431-57588-1-git-send-email-erik.g.carrillo@intel.com> <20171003143723.GB10493@jerin> In-Reply-To: <20171003143723.GB10493@jerin> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjAzODdhNTgtYjA1MC00MTk2LTk2YTYtMWYxMzRhOWZkNGI5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJcL3R3XC9Od1E0RzZFQmRGOW5HNVRqZnpCNzc3N2M5U1FlRVZVek05V2l1Yys1KzVxUGd6TFRGNXpDVHRXVkRLRXcifQ== x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.107] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC PATCH v2 0/1] eventtimer: introduce event timer adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Oct 2017 20:30:38 -0000 > > > > The second big change is to replace API parameters specifying pointer > > to rte_event_timer_adapter with ids, which seems more common > > throughout DPDK. > > > > Other changes include: > > - removed rte_event_timer_adapter_lookup() function, since APIs no > longer > > accept pointer to rte_event_timer_adapter >=20 > There is one difference between ethdev rx adapter, where we have > rte_event_timer_arm_burst(), rte_event_timer_arm_tmo_tick_burst(), > rte_event_timer_cancel_burst(), > APIs in fastpath. So any multi process scheme where resolving the fastpat= h > API functions in _one_ or zero redirection is fine. I see, makes sense. >=20 > I guess in we may need 2 or 3 indirection to resolve the fastpath functio= ns > with id scheme. Please choose scheme with one 1 or no redirection. > I think, > - By allocating adapter memory from the heap and Just to check, are you talking about the heap (e.g., rte_malloc) in hugepag= e memory? > - adapter hold the function pointers for multi process and > - mempool kind of pointer object scheme without id and lookup() Can > resolve function pointers without any indirection. >=20 Can you elaborate here? In the mempool implementation, it looks like there= 's a per-process array of ops objects, and each mempool instance has an ind= ex into the array that it uses to select the ops object to call through. S= ince the ops structures are initialized per-process, they get function poin= ters valid in that process - which relates to the second point above. If th= e adapter holds function pointers for a primary process (for example), they= 'll be invalid in the secondary. Am I missing something? Thanks, Gabriel > So please analyze on those lines as well. >=20 >=20