From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <erik.g.carrillo@intel.com> Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id BF9F01B1A1 for <dev@dpdk.org>; Fri, 1 Dec 2017 00:56:23 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Nov 2017 15:56:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,343,1508828400"; d="scan'208";a="11659576" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga001.jf.intel.com with ESMTP; 30 Nov 2017 15:56:21 -0800 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 30 Nov 2017 15:56:20 -0800 Received: from fmsmsx115.amr.corp.intel.com ([169.254.4.116]) by FMSMSX157.amr.corp.intel.com ([169.254.14.69]) with mapi id 14.03.0319.002; Thu, 30 Nov 2017 15:56:20 -0800 From: "Carrillo, Erik G" <erik.g.carrillo@intel.com> To: Pavan Nikhilesh Bhagavatula <pbhagavatula@caviumnetworks.com> CC: "dev@dpdk.org" <dev@dpdk.org>, "nipun.gupta@nxp.com" <nipun.gupta@nxp.com>, "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, "Rao, Nikhil" <nikhil.rao@intel.com>, "jerin.jacobkollanukkaran@cavium.com" <jerin.jacobkollanukkaran@cavium.com> Thread-Topic: [RFC PATCH v4 3/4] eventtimer: add default software implementation stub Thread-Index: AQHTaP26HFbzSLteD02lCQSHQb0lP6MtjS1g Date: Thu, 30 Nov 2017 23:56:20 +0000 Message-ID: <BE54F058557D9A4FAC1D84E2FC6D87570ED7E9A5@fmsmsx115.amr.corp.intel.com> References: <1511217333-142455-1-git-send-email-erik.g.carrillo@intel.com> <1511890808-6072-1-git-send-email-erik.g.carrillo@intel.com> <1511890808-6072-4-git-send-email-erik.g.carrillo@intel.com> <20171129103446.4mvnuvalk5wn2tfg@Pavan-LT> In-Reply-To: <20171129103446.4mvnuvalk5wn2tfg@Pavan-LT> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDVkZTYwMTAtNDc0YS00OTBlLWJmNGMtYzkwMjgwN2JhYzU1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiI0ajVYTEsyZU9QaFZEamRXbythYlNvVXc0aWc1bnFCaTFWVWtIZGVXTzlqaDYyd3hVWmo3NUNWMGdIN1ZXenhNIn0= x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.106] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC PATCH v4 3/4] eventtimer: add default software implementation stub X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 30 Nov 2017 23:56:24 -0000 Hi Pavan, Response in-line: > -----Original Message----- > From: Pavan Nikhilesh Bhagavatula > [mailto:pbhagavatula@caviumnetworks.com] > Sent: Wednesday, November 29, 2017 4:35 AM > To: Carrillo, Erik G <erik.g.carrillo@intel.com> > Cc: dev@dpdk.org; nipun.gupta@nxp.com; hemant.agrawal@nxp.com; Rao, > Nikhil <nikhil.rao@intel.com>; jerin.jacobkollanukkaran@cavium.com > Subject: Re: [RFC PATCH v4 3/4] eventtimer: add default software > implementation stub >=20 > On Tue, Nov 28, 2017 at 11:40:07AM -0600, Erik Gabriel Carrillo wrote: > > If an eventdev PMD does not wish to provide event timer adapter ops > > definitions, the library will fall back to a default software > > implementation whose entry points are added by this commit. > > >=20 > I do agree with having sw driver in lib/librte_eventdev as it doesn't fit > anywhere else, but it seems out of place maybe it would be better to > merged it with rte_event_timer_adapter_driver.h or in > rte_event_timer_adapter.c as done by eth_rx_adapter. >=20 > Thoughts? I had also considered merging the SW driver with rte_event_timer_adapter.c = but then thought it would be cleaner to separate it into its own module. =20 But I'll make the change so that it's more like the eth rx adapter, and if = the file gets too messy when we flesh out the SW driver, we can break it ba= ck out. Thanks, Gabriel > -Pavan >=20 > > Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com> > > --- > > lib/librte_eventdev/Makefile | 1 + > > lib/librte_eventdev/rte_event_timer_adapter.c | 14 +++ > > lib/librte_eventdev/sw_event_timer_adapter.c | 123 > > ++++++++++++++++++++++++++ > > 3 files changed, 138 insertions(+) > > create mode 100644 lib/librte_eventdev/sw_event_timer_adapter.c