From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id E75F029CA for ; Wed, 6 Dec 2017 17:23:49 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Dec 2017 08:23:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,368,1508828400"; d="scan'208";a="11105964" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga001.fm.intel.com with ESMTP; 06 Dec 2017 08:23:40 -0800 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 6 Dec 2017 08:23:39 -0800 Received: from fmsmsx115.amr.corp.intel.com ([169.254.4.116]) by fmsmsx121.amr.corp.intel.com ([169.254.6.85]) with mapi id 14.03.0319.002; Wed, 6 Dec 2017 08:23:39 -0800 From: "Carrillo, Erik G" To: Jerin Jacob CC: "pbhagavatula@caviumnetworks.com" , "dev@dpdk.org" , "nipun.gupta@nxp.com" , "hemant.agrawal@nxp.com" Thread-Topic: [RFC PATCH v5 1/5] eventtimer: introduce event timer adapter Thread-Index: AQHTbqVzm2BuYZpmnU20YHUFlo4Xz6M2fivw Date: Wed, 6 Dec 2017 16:23:38 +0000 Message-ID: References: <1511890148-22295-1-git-send-email-erik.g.carrillo@intel.com> <1512158458-22661-1-git-send-email-erik.g.carrillo@intel.com> <1512158458-22661-2-git-send-email-erik.g.carrillo@intel.com> <20171206151734.GA1591@jerin> In-Reply-To: <20171206151734.GA1591@jerin> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjQ1YzNhNDktOTcwNC00NmMzLTg5YjAtOWUyMGUwODcyMDIzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJBMytmeERuVHZ5MzVUaHZJM3lZK1hIaFdyaG0xSjE5blcrRjR2RjYyT2pxZEVtZTRicjkxd1wvdWNPdFlkQlhITyJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.106] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC PATCH v5 1/5] eventtimer: introduce event timer adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Dec 2017 16:23:50 -0000 > -----Original Message----- > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Wednesday, December 6, 2017 9:18 AM > To: Carrillo, Erik G > Cc: pbhagavatula@caviumnetworks.com; dev@dpdk.org; > nipun.gupta@nxp.com; hemant.agrawal@nxp.com > Subject: Re: [RFC PATCH v5 1/5] eventtimer: introduce event timer adapter >=20 > -----Original Message----- > > Date: Fri, 1 Dec 2017 14:00:54 -0600 > > From: Erik Gabriel Carrillo > > To: pbhagavatula@caviumnetworks.com > > CC: dev@dpdk.org, jerin.jacob@caviumnetworks.com, > nipun.gupta@nxp.com, > > hemant.agrawal@nxp.com > > Subject: [RFC PATCH v5 1/5] eventtimer: introduce event timer adapter > > X-Mailer: git-send-email 1.7.10 > > > > Signed-off-by: Erik Gabriel Carrillo >=20 > Feel free to add my Signed-off-by as this patch is mostly based on initia= l RFC. Ok, thanks. Pavan, I'll add yours back as well... if you'd rather I don't,= just let me know. >=20 > > --- > > doc/api/doxy-api-index.md | 1 + > > lib/librte_eventdev/Makefile | 1 + > > lib/librte_eventdev/rte_event_timer_adapter.h | 518 > ++++++++++++++++++++++++++ > > lib/librte_eventdev/rte_eventdev.h | 4 +- > > 4 files changed, 522 insertions(+), 2 deletions(-) create mode > > 100644 lib/librte_eventdev/rte_event_timer_adapter.h > > > > + * Event timer state. > > + */ > > +enum rte_event_timer_state { > > + RTE_EVENT_TIMER_NOT_ARMED =3D 0, > > + /**< Event timer is in not armed state.*/ > > + RTE_EVENT_TIMER_ARMED =3D 1, > > + /**< Event timer successfully armed.*/ >=20 > How about adding a state called RTE_EVENT_TIMER_CANCELED?, Which will > updated by the driver on rte_event_timer_arm_burst(). > This will enable application to get the state of the rte_event_timer obje= ct in > latter time. Good catch - I didn't realize that state had been dropped. I'll add it bac= k in. Thanks, Gabriel >=20 > > + RTE_EVENT_TIMER_ERROR =3D -1, > > + /**< Generic event timer error.*/ > > + RTE_EVENT_TIMER_ERROR_TOOEARLY =3D -2, > > + /**< Event timer timeout tick is too little to add to the adapter. */ > > + RTE_EVENT_TIMER_ERROR_TOOLATE =3D -3, > > + /**< Event timer timeout tick is greater than the maximum > timeout.*/ > > +}; > > + > > +/**