From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 85B36726F for ; Fri, 12 Jan 2018 00:09:46 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jan 2018 15:09:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,346,1511856000"; d="scan'208";a="194195707" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 11 Jan 2018 15:09:45 -0800 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 11 Jan 2018 15:09:45 -0800 Received: from fmsmsx115.amr.corp.intel.com ([169.254.4.132]) by FMSMSX112.amr.corp.intel.com ([10.18.116.6]) with mapi id 14.03.0319.002; Thu, 11 Jan 2018 15:09:44 -0800 From: "Carrillo, Erik G" To: Aaron Conole CC: "pbhagavatula@caviumnetworks.com" , "Van Haaren, Harry" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/1] eal: return true or false from lcore role check function Thread-Index: AQHTiWkuJfHfIcWf5U+mYAbsU74gsKNvSDTA Date: Thu, 11 Jan 2018 23:09:43 +0000 Message-ID: References: <1515005015-31990-1-git-send-email-erik.g.carrillo@intel.com> <1515005015-31990-2-git-send-email-erik.g.carrillo@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWU2Y2Y4ODgtMGEzMC00ZTY0LWE3MTItNWZkYWNiYjg2YzkxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiIrK1piWm9rS1ZFRzFyOFZmblwvUzhJUWJ1Skc0SGU1cWE4elJrcWFWNWpENFBOTWhZWmpYd3hzXC9jQld0RjViUWMifQ== x-ctpclassification: CTP_NT x-originating-ip: [10.1.200.107] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/1] eal: return true or false from lcore role check function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jan 2018 23:09:46 -0000 Hi Aaron, > -----Original Message----- > From: Aaron Conole [mailto:aconole@redhat.com] > Sent: Tuesday, January 9, 2018 10:45 AM > To: Carrillo, Erik G > Cc: pbhagavatula@caviumnetworks.com; Van Haaren, Harry > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/1] eal: return true or false from lcore = role > check function >=20 > Hi Erik, >=20 > Erik Gabriel Carrillo writes: >=20 > > Update rte_lcore_has_role() so that it returns true/false instead of > > success/failure. > > > > Fixes: 78666372fa2b ("eal: add function to check lcore role") > > > > Signed-off-by: Erik Gabriel Carrillo > > --- >=20 > I believe this breaks the published abi - Success is now 'true', and fail= ure is > 'false'; previously success would be 0 =3D=3D false. You'll need to inv= ert the test, > or note that the abi is breaking (since semantically any caller will need= to > invert the test). Good point. Though it seems like an API change rather than an ABI change t= o me, would it still be handled the same way in terms of notice? Also, th= e ABI policy states, "ABI breakage due to changes such as reorganizing publ= ic structure fields for aesthetic or readability purposes should be avoided= ." Perhaps I should go with an alternate patch that fixes the caller. Thanks, Erik