From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 4734116E for ; Fri, 12 Jan 2018 19:01:54 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jan 2018 10:01:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,350,1511856000"; d="scan'208";a="19633446" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 12 Jan 2018 10:01:52 -0800 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 12 Jan 2018 10:01:52 -0800 Received: from fmsmsx115.amr.corp.intel.com ([169.254.4.132]) by fmsmsx156.amr.corp.intel.com ([10.18.116.74]) with mapi id 14.03.0319.002; Fri, 12 Jan 2018 10:01:52 -0800 From: "Carrillo, Erik G" To: Thomas Monjalon CC: "dev@dpdk.org" , Aaron Conole , "pbhagavatula@caviumnetworks.com" Thread-Topic: [dpdk-dev] [PATCH 1/1] eal: return true or false from lcore role check function Thread-Index: AQHTiWkuJfHfIcWf5U+mYAbsU74gsKNvSDTAgACPrICAALO2AA== Date: Fri, 12 Jan 2018 18:01:51 +0000 Message-ID: References: <1515005015-31990-1-git-send-email-erik.g.carrillo@intel.com> <1713856.qAfyk3hvam@xps> In-Reply-To: <1713856.qAfyk3hvam@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGNhMzBhZTUtNmUzNy00YTAzLTlhOTAtNmE5NWM4NzJlY2Y2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJNYW5XZHAzdElPS3hpV3dISVVrVHRHSzdrdzE2d2U0VzA4dGlJbVwvYmMxNzYyODcyMjZ2dnRJeVpualdJQXBDRSJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.1.200.106] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/1] eal: return true or false from lcore role check function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jan 2018 18:01:54 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Thursday, January 11, 2018 5:17 PM > To: Carrillo, Erik G > Cc: dev@dpdk.org; Aaron Conole ; > pbhagavatula@caviumnetworks.com; Van Haaren, Harry > > Subject: Re: [dpdk-dev] [PATCH 1/1] eal: return true or false from lcore = role > check function >=20 > 12/01/2018 00:09, Carrillo, Erik G: > > Hi Aaron, > > > > From: Aaron Conole [mailto:aconole@redhat.com] > > > > > > Hi Erik, > > > > > > Erik Gabriel Carrillo writes: > > > > > > > Update rte_lcore_has_role() so that it returns true/false instead > > > > of success/failure. > > > > > > > > Fixes: 78666372fa2b ("eal: add function to check lcore role") > > > > > > > > Signed-off-by: Erik Gabriel Carrillo > > > > --- > > > > > > I believe this breaks the published abi - Success is now 'true', and > > > failure is 'false'; previously success would be 0 =3D=3D false. You= 'll > > > need to invert the test, or note that the abi is breaking (since > > > semantically any caller will need to invert the test). > > > > Good point. Though it seems like an API change rather than an ABI chan= ge > to me, would it still be handled the same way in terms of notice? Also, = the > ABI policy states, "ABI breakage due to changes such as reorganizing publ= ic > structure fields for aesthetic or readability purposes should be avoided.= " > Perhaps I should go with an alternate patch that fixes the caller. >=20 > Most of the times, an API change is an ABI change. > Please make a deprecation notice. Ok, thanks Thomas - will do. Should I mark the above patch as "deferred" f= or the time being?