From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id B22E61B2EB for ; Fri, 19 Jan 2018 00:07:55 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jan 2018 15:07:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,378,1511856000"; d="scan'208";a="10872682" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga007.jf.intel.com with ESMTP; 18 Jan 2018 15:07:53 -0800 Received: from fmsmsx115.amr.corp.intel.com ([169.254.4.132]) by fmsmsx107.amr.corp.intel.com ([169.254.6.59]) with mapi id 14.03.0319.002; Thu, 18 Jan 2018 15:07:53 -0800 From: "Carrillo, Erik G" To: Pavan Nikhilesh , "jerin.jacob@caviumnetworks.com" CC: "dev@dpdk.org" Thread-Topic: [PATCH v6 15/23] eventtimer: add buffering of timer expiry events Thread-Index: AQHTitZYi+IfGpTSS0C33m8luhzz3aN6RuSg Date: Thu, 18 Jan 2018 23:07:52 +0000 Message-ID: References: <1512158458-22661-1-git-send-email-erik.g.carrillo@intel.com> <1515630074-29020-1-git-send-email-erik.g.carrillo@intel.com> <1515630074-29020-16-git-send-email-erik.g.carrillo@intel.com> <20180111121831.j2ea6urzhf5zkoup@Pavan-LT> In-Reply-To: <20180111121831.j2ea6urzhf5zkoup@Pavan-LT> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGE3M2IxMjctMTUzZi00NDI4LWFjNTctMTgyZmYyYTU2NzVlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJNcytvTXdxdm1jNXhIaVBnamlGeUVtWnNBOGtnWVFEMWdFaHNOeTdlbnpiUU9JN0RoRzBGQ1wvbFFobWZtVzJsQSJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.1.200.106] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 15/23] eventtimer: add buffering of timer expiry events X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jan 2018 23:07:56 -0000 > -----Original Message----- > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com] > Sent: Thursday, January 11, 2018 6:19 AM > To: Carrillo, Erik G ; > jerin.jacob@caviumnetworks.com; nipun.gupta@nxp.com; > hemant.agrawal@nxp.com > Cc: dev@dpdk.org > Subject: Re: [PATCH v6 15/23] eventtimer: add buffering of timer expiry > events >=20 > On Wed, Jan 10, 2018 at 06:21:06PM -0600, Erik Gabriel Carrillo wrote: > > Buffer timer expiry events generated while walking a "run list" > > in rte_timer_manage, and burst enqueue them to an event device to the > > extent possible. > > >=20 > IMO in some cases this adds a lot of delay between expiries and events be= ing > published to event dev. For example, having long expiry interval (default= 300 > seconds for mac expiry) the expired entries would remain in the buffer ti= ll 32 > other entries expire. >=20 The service function invokes rte_timer_manage to handle expired timers, and= as it does so, the buffer will be flushed under two conditions: the buffe= r is full of expired timer events, or the buffer is not full but there are = no more expired timers to handle for this iteration of the service. The la= tter condition will flush the buffer even if only one event has been buffer= ed after walking the list of expired rte_timers. =20 So, there could be some delay for the events that got buffered earliest, bu= t it seems like the throughput benefit outweighs the small delay there. Th= oughts? We could also make the buffer size configurable. =20 >=20 > > Signed-off-by: Erik Gabriel Carrillo > > --- > > lib/librte_eventdev/rte_event_timer_adapter.c | 118 > > +++++++++++++++++++++++--- > > 1 file changed, 108 insertions(+), 10 deletions(-) > > >