From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 417A55F17 for ; Fri, 23 Feb 2018 21:17:10 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Feb 2018 12:17:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,383,1515484800"; d="scan'208";a="206494872" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga005.fm.intel.com with ESMTP; 23 Feb 2018 12:17:08 -0800 Received: from fmsmsx115.amr.corp.intel.com ([169.254.4.14]) by FMSMSX105.amr.corp.intel.com ([169.254.4.164]) with mapi id 14.03.0319.002; Fri, 23 Feb 2018 12:17:08 -0800 From: "Carrillo, Erik G" To: Pavan Nikhilesh , "jerin.jacob@caviumnetworks.com" , "santosh.shukla@caviumnetworks.com" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 08/10] event/octeontx: add option to use fpavf as chunk pool Thread-Index: AQHTp25pmGmzVpD3JkSvsC3EkGAALaOydjwA Date: Fri, 23 Feb 2018 20:17:07 +0000 Message-ID: References: <20180216213700.3415-1-pbhagavatula@caviumnetworks.com> <20180216213700.3415-9-pbhagavatula@caviumnetworks.com> In-Reply-To: <20180216213700.3415-9-pbhagavatula@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWM2YzZmNmQtNTNjZS00YWRmLTljOWYtYzRjYzgyOGRkZGIzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiIrN25kYTcySkpaVGNwOVwva0xHUGp4ZHBWSzdIaHM1bEZjb1VCeGtuWUJpejZlV0w0MlArakpzdUR4a2YrZTZ6cyJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.1.200.108] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 08/10] event/octeontx: add option to use fpavf as chunk pool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Feb 2018 20:17:11 -0000 Hi Pavan, > -----Original Message----- > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com] > Sent: Friday, February 16, 2018 3:37 PM > To: jerin.jacob@caviumnetworks.com; > santosh.shukla@caviumnetworks.com; Carrillo, Erik G > > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH 08/10] event/octeontx: add option to use fpavf > as chunk pool >=20 > Add compile-time configurable option to force TIMvf to use Octeontx FPAvf > pool manager as its chunk pool. > When FPAvf is used as pool manager the TIMvf automatically frees the > chunks to FPAvf through gpool-id. >=20 > Signed-off-by: Pavan Nikhilesh > --- <...snipped...> > @@ -241,7 +243,16 @@ timvf_add_entry_brst(struct timvf_ring *timr, const > uint16_t rel_bkt, > bkt->first_chunk =3D (uint64_t) chunk; > } > } else { > +#ifndef RTE_PMD_OCTEONTX_TIMVF_USE_FPAVF > chunk =3D timr_clr_bkt(timr, bkt); > +#else > + if (unlikely(rte_mempool_get(timr- > >meta.chunk_pool, > + (void **)&chunk))) { > + timr_bkt_set_rem(bkt, 0); > + tim[index]->state =3D > RTE_EVENT_TIMER_ERROR; > + return -ENOMEM; You return a negative errno value here, but in this case the caller was exp= ecting the number that succeeded. Regards, Gabriel > + } > +#endif > bkt->first_chunk =3D (uint64_t) chunk; > } > *(uint64_t *)(chunk + nb_chunk_slots) =3D 0; @@ -355,7 > +366,18 @@ timvf_add_entry_sp(struct timvf_ring *timr, const uint32_t <...snipped...>