From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 585465F25 for ; Mon, 12 Mar 2018 22:20:19 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Mar 2018 14:20:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,463,1515484800"; d="scan'208";a="33253727" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 12 Mar 2018 14:20:16 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 12 Mar 2018 14:20:15 -0700 Received: from fmsmsx115.amr.corp.intel.com ([169.254.4.147]) by FMSMSX151.amr.corp.intel.com ([169.254.7.150]) with mapi id 14.03.0319.002; Mon, 12 Mar 2018 14:20:15 -0700 From: "Carrillo, Erik G" To: Jerin Jacob CC: "pbhagavatula@caviumnetworks.com" , "dev@dpdk.org" Thread-Topic: [PATCH v7 3/7] eventtimer: add default software driver Thread-Index: AQHTud6fSPX8ix1nQ06roMcJm9CyW6PNGdtg Date: Mon, 12 Mar 2018 21:20:14 +0000 Message-ID: References: <1515630074-29020-1-git-send-email-erik.g.carrillo@intel.com> <1520546046-6973-1-git-send-email-erik.g.carrillo@intel.com> <1520546046-6973-4-git-send-email-erik.g.carrillo@intel.com> <20180312084539.GC7119@jerin> In-Reply-To: <20180312084539.GC7119@jerin> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzg0YTJhOWUtZjE1MC00MzE1LWIxNjctNzE4NjcxZDU1MmM0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJobTVLQ1AzTHJCTjNadVNhTkU0MTVrblBDc2REeTVYQVJDakpvRXJcL0xCK01BdFgrejJOYkVMWDNlWUlRdzlPVSJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.1.200.107] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 3/7] eventtimer: add default software driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Mar 2018 21:20:20 -0000 Hi Jerin, Response in-line: > -----Original Message----- > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Monday, March 12, 2018 3:46 AM > To: Carrillo, Erik G > Cc: pbhagavatula@caviumnetworks.com; dev@dpdk.org; > nipun.gupta@nxp.com; hemant.agrawal@nxp.com > Subject: Re: [PATCH v7 3/7] eventtimer: add default software driver >=20 > -----Original Message----- > > Date: Thu, 8 Mar 2018 15:54:02 -0600 > > From: Erik Gabriel Carrillo > > To: pbhagavatula@caviumnetworks.com > > CC: dev@dpdk.org, jerin.jacob@caviumnetworks.com, > nipun.gupta@nxp.com, > > hemant.agrawal@nxp.com > > Subject: [PATCH v7 3/7] eventtimer: add default software driver > > X-Mailer: git-send-email 1.7.10 > > > > If an eventdev PMD does not wish to provide event timer adapter ops > > definitions, the library will fall back to a default software > > implementation whose entry points are added by this commit. > > <... snipped ...> > > --- a/mk/rte.app.mk > > +++ b/mk/rte.app.mk > > @@ -80,7 +80,6 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_BITRATE) +=3D - > lrte_bitratestats > > _LDLIBS-$(CONFIG_RTE_LIBRTE_LATENCY_STATS) +=3D -lrte_latencystats > > _LDLIBS-$(CONFIG_RTE_LIBRTE_POWER) +=3D -lrte_power > > > > -_LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER) +=3D -lrte_timer >=20 > Any specific reason for this change, if yes, Please create a separate pat= ch for > the common code change, This will help to review Yes, I needed to move the rte_timer lib past the eventdev lib in order for = the=20 static build to complete (since the event timer adapter references symbols = from the=20 rte_timer lib). I'll separate that change out in the next series. Thanks, Gabriel >=20 > > _LDLIBS-$(CONFIG_RTE_LIBRTE_EFD) +=3D -lrte_efd > > > > _LDLIBS-y +=3D --whole-archive > > @@ -98,6 +97,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) +=3D - > lrte_cryptodev > > _LDLIBS-$(CONFIG_RTE_LIBRTE_SECURITY) +=3D -lrte_security > > _LDLIBS-$(CONFIG_RTE_LIBRTE_EVENTDEV) +=3D -lrte_eventdev > > _LDLIBS-$(CONFIG_RTE_LIBRTE_RAWDEV) +=3D -lrte_rawdev > > +_LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER) +=3D -lrte_timer > > _LDLIBS-$(CONFIG_RTE_LIBRTE_MEMPOOL) +=3D -lrte_mempool > > _LDLIBS-$(CONFIG_RTE_DRIVER_MEMPOOL_RING) +=3D - > lrte_mempool_ring > > _LDLIBS-$(CONFIG_RTE_LIBRTE_RING) +=3D -lrte_ring > > -- > > 2.6.4 > >