From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id BCF861B841 for ; Tue, 3 Apr 2018 20:32:20 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Apr 2018 11:32:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,402,1517904000"; d="scan'208";a="188369397" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga004.jf.intel.com with ESMTP; 03 Apr 2018 11:32:18 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 3 Apr 2018 11:32:16 -0700 Received: from fmsmsx115.amr.corp.intel.com ([169.254.4.26]) by fmsmsx111.amr.corp.intel.com ([169.254.12.79]) with mapi id 14.03.0319.002; Tue, 3 Apr 2018 11:32:16 -0700 From: "Carrillo, Erik G" To: Jerin Jacob CC: "dev@dpdk.org" Thread-Topic: [PATCH v9 0/9] eventtimer: introduce event timer adapter Thread-Index: AQHTytkktHAqfbgO7Ui3SvbgxqQZRKPvE/qggAB3/YD//9EbwA== Date: Tue, 3 Apr 2018 18:32:15 +0000 Message-ID: References: <1522358852-3630-1-git-send-email-erik.g.carrillo@intel.com> <1522697994-22515-1-git-send-email-erik.g.carrillo@intel.com> <20180402231906.GA31895@jerin> <20180403141459.GA9612@jerin> In-Reply-To: <20180403141459.GA9612@jerin> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDkyNDZkMTMtMjExYS00ZjhkLThiYjItNzNkMzJkMzc2ZDQ4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJzUVVrODc3Znpxd05xa1JpS25JZklQNmFRSTdlUm9OXC92YVc4cWdsWXBkWGxjOVF3SjJmZjRvendGYm5ZMDJQMyJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.1.200.106] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v9 0/9] eventtimer: introduce event timer adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Apr 2018 18:32:23 -0000 > -----Original Message----- > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Tuesday, April 3, 2018 9:15 AM > To: Carrillo, Erik G > Cc: dev@dpdk.org > Subject: Re: [PATCH v9 0/9] eventtimer: introduce event timer adapter >=20 > -----Original Message----- > > Date: Tue, 3 Apr 2018 14:09:22 +0000 > > From: "Carrillo, Erik G" > > To: Jerin Jacob > > CC: "dev@dpdk.org" > > Subject: RE: [PATCH v9 0/9] eventtimer: introduce event timer adapter > > > > Hi Jerin, >=20 >=20 > Hi Carrillo, >=20 > > > > Question in-line: > > > > > 1) Please fix following check-patch warnings: > > > > > > ### eventtimer: introduce event timer adapter > > > > > > ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar" > > > #273: FILE: lib/librte_eventdev/rte_event_timer_adapter.h:238: > > > +struct rte_event_timer_adapter * __rte_experimental > > > > > > ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar" > > > #303: FILE: lib/librte_eventdev/rte_event_timer_adapter.h:268: > > > +struct rte_event_timer_adapter * __rte_experimenta > > > > > > > I was aware that checkpatch was complaining here, but the style I used > > is consistent with almost all the existing DPDK code that uses the > > __rte_experimental tag. Should I fix the warning if the style will dif= fer from > existing code? >=20 > Probably, We could fix the checkpatch. May be for short term we could liv= e > with those warnings. Ok. I looked at the other warnings too and checkpatch complains if there's= no space after the comma, and it also complains if there's a space between the comma and t= he closing paren. Since it complains either way, I propose to leave it as the style is consis= tent with other uses of RTE_FMT_HEAD() and RTE_FMT_TAIL() throughout the codebase. =20 >=20 > > > > Thanks, > > Gabriel > >