From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 909CD8D3C for ; Thu, 26 Apr 2018 16:44:09 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Apr 2018 07:44:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,330,1520924400"; d="scan'208";a="44809682" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 26 Apr 2018 07:44:08 -0700 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 26 Apr 2018 07:44:07 -0700 Received: from fmsmsx115.amr.corp.intel.com ([169.254.4.201]) by fmsmsx121.amr.corp.intel.com ([169.254.6.78]) with mapi id 14.03.0319.002; Thu, 26 Apr 2018 07:44:07 -0700 From: "Carrillo, Erik G" To: Thomas Monjalon , "Burakov, Anatoly" CC: "dev@dpdk.org" , Neil Horman , "Mcnamara, John" , "Kovacevic, Marko" , Robert Sanford , "olivier.matz@6wind.com" , "shreyansh.jain@nxp.com" Thread-Topic: [dpdk-dev] [PATCH] lcore: make semantics of lcore role function more intuitive Thread-Index: AQHT3WR02IN4gHYfukqOyJVV0tWiUqQTkN8A//+MD3A= Date: Thu, 26 Apr 2018 14:44:06 +0000 Message-ID: References: <2584582.pWCQVUZt55@xps> In-Reply-To: <2584582.pWCQVUZt55@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDdjYzEwMDYtNTNkYi00Mjc2LWI2NWItMzQ4NWFjMTdhMDU1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJSa0tvdU53bzV0bzJRNFVvMG90aEg3ZldRcjZkMEJiQzhOVzBvUkd2WlFydDhKVk82MmI1UXNqZU1RUlR1cjZiIn0= x-ctpclassification: CTP_NT x-originating-ip: [10.1.200.106] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] lcore: make semantics of lcore role function more intuitive X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Apr 2018 14:44:10 -0000 Thanks, Anatoly and Thomas. I had also considered the following chunk for= the release notes: diff --git a/doc/guides/rel_notes/release_18_05.rst b/doc/guides/rel_notes/= release_18_05.rst index 04ff4fe..127a7e2 100644 = =20 --- a/doc/guides/rel_notes/release_18_05.rst = =20 +++ b/doc/guides/rel_notes/release_18_05.rst = =20 @@ -72,6 +72,11 @@ API Changes = =20 Also, make sure to start the actual text at the margin. = =20 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D =20 = =20 +* **rte_lcore_has_role() return values changed** = =20 + = =20 + This function now returns 1 or 0 for true or false, respectively, rather= =20 + than 0 or <0 for success or failure to make use of the function more = =20 + intuitive. = =20 = =20 ABI Changes = =20 ----------- Do we want this note? Also, it looks like the Doxygen documentation of the= function in the header file didn't get updated. Regards, Erik > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Thursday, April 26, 2018 9:31 AM > To: Burakov, Anatoly > Cc: dev@dpdk.org; Neil Horman ; Mcnamara, > John ; Kovacevic, Marko > ; Robert Sanford ; > Carrillo, Erik G ; olivier.matz@6wind.com; > shreyansh.jain@nxp.com > Subject: Re: [dpdk-dev] [PATCH] lcore: make semantics of lcore role funct= ion > more intuitive >=20 > 26/04/2018 15:42, Anatoly Burakov: > > rte_lcore_has_role() returns 0 if role of lcore matches requested > > role. The return value of the API is confusing, and this is a known > > problem with a deprecation notice announcing the change to more > > intuitive semantics: > > > > Commit 064518f68d48 ("doc: announce EAL API change to lcore role > > function") > > Cc: erik.g.carrillo@intel.com > > > > Implement changes announced in the deprecation notice, and remove it. > > Also, fix usages of this API to reflect the change. Control thread > > patches expected new behavior and were broken before, now they are > fixed as well. > > > > Fixes: d651ee4919cd ("eal: set affinity for control threads") > > Cc: olivier.matz@6wind.com > > > > Signed-off-by: Anatoly Burakov >=20 > Applied, thanks >=20 >=20