From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id EB7178D97 for ; Thu, 26 Apr 2018 16:56:24 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Apr 2018 07:56:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,330,1520924400"; d="scan'208";a="36377093" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga007.jf.intel.com with ESMTP; 26 Apr 2018 07:56:23 -0700 Received: from fmsmsx115.amr.corp.intel.com ([169.254.4.201]) by fmsmsx107.amr.corp.intel.com ([169.254.6.41]) with mapi id 14.03.0319.002; Thu, 26 Apr 2018 07:56:21 -0700 From: "Carrillo, Erik G" To: Thomas Monjalon CC: "Burakov, Anatoly" , "dev@dpdk.org" , Neil Horman , "Mcnamara, John" , "Kovacevic, Marko" , Robert Sanford , "olivier.matz@6wind.com" , "shreyansh.jain@nxp.com" Thread-Topic: [dpdk-dev] [PATCH] lcore: make semantics of lcore role function more intuitive Thread-Index: AQHT3WR02IN4gHYfukqOyJVV0tWiUqQTkN8A//+MD3CAAHqlAP//iv/Q Date: Thu, 26 Apr 2018 14:56:19 +0000 Message-ID: References: <2584582.pWCQVUZt55@xps> <5414097.qiRGovPonW@xps> In-Reply-To: <5414097.qiRGovPonW@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTU1MmU2MTAtMTZkNS00YWJkLWJiMDMtOWFkOTMxMzc1ZmUwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJQN0dsS2ZSTUt0ODVVYVpsSjZNS0RuQUhPNk9OK0JmMFlZdFpaNUtNbEx2RkV0WnZpbnd0dUdXUzVXTHNJMTFVIn0= x-ctpclassification: CTP_NT x-originating-ip: [10.1.200.106] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] lcore: make semantics of lcore role function more intuitive X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Apr 2018 14:56:25 -0000 Great, thanks Thomas. > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Thursday, April 26, 2018 9:55 AM > To: Carrillo, Erik G > Cc: Burakov, Anatoly ; dev@dpdk.org; Neil > Horman ; Mcnamara, John > ; Kovacevic, Marko > ; Robert Sanford ; > olivier.matz@6wind.com; shreyansh.jain@nxp.com > Subject: Re: [dpdk-dev] [PATCH] lcore: make semantics of lcore role funct= ion > more intuitive >=20 > 26/04/2018 16:44, Carrillo, Erik G: > > Thanks, Anatoly and Thomas. I had also considered the following chunk= for > the release notes: > > > > diff --git a/doc/guides/rel_notes/release_18_05.rst > b/doc/guides/rel_notes/release_18_05.rst > > index 04ff4fe..127a7e2 100644 > > --- a/doc/guides/rel_notes/release_18_05.rst > > +++ b/doc/guides/rel_notes/release_18_05.rst > > @@ -72,6 +72,11 @@ API Changes > > Also, make sure to start the actual text at the margin. > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D > > > > +* **rte_lcore_has_role() return values changed** > > + > > + This function now returns 1 or 0 for true or false, respectively, ra= ther > > + than 0 or <0 for success or failure to make use of the function more > > + intuitive. > > > > ABI Changes > > ----------- > > > > Do we want this note? Also, it looks like the Doxygen documentation of > the function in the header file didn't get updated. >=20 >=20 > Oh, you are right, this patch is not complete. > I've fixed it: >=20 > --- a/doc/guides/rel_notes/release_18_05.rst > +++ b/doc/guides/rel_notes/release_18_05.rst > @@ -161,6 +161,12 @@ API Changes > announced at least one release before the ABI change is made. There ar= e > no > ABI breaking changes planned. >=20 > +* eal: ``rte_lcore_has_role()`` return value changed. > + > + This function now returns true or false, respectively, rather than 0 > + or <0 for success or failure. > + It makes use of the function more intuitive. > + > * mempool: capability flags and related functions have been removed. >=20 > Flags ``MEMPOOL_F_CAPA_PHYS_CONTIG`` and diff --git > a/lib/librte_eal/common/include/rte_lcore.h > b/lib/librte_eal/common/include/rte_lcore.h > index 334a0629e..1a2f37eaa 100644 > --- a/lib/librte_eal/common/include/rte_lcore.h > +++ b/lib/librte_eal/common/include/rte_lcore.h > @@ -311,7 +311,7 @@ rte_ctrl_thread_create(pthread_t *thread, const char > *name, > * @param role > * The role to be checked against. > * @return > - * On success, return 0; otherwise return a negative value. > + * Boolean value: positive if test is true; otherwise returns 0. > */ >=20 > Thanks Erik! >=20