From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id DD2181B5C6 for ; Fri, 30 Nov 2018 20:07:26 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Nov 2018 11:07:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,299,1539673200"; d="scan'208";a="109023976" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by FMSMGA003.fm.intel.com with ESMTP; 30 Nov 2018 11:07:26 -0800 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 30 Nov 2018 11:07:25 -0800 Received: from fmsmsx115.amr.corp.intel.com ([169.254.4.121]) by fmsmsx120.amr.corp.intel.com ([169.254.15.78]) with mapi id 14.03.0415.000; Fri, 30 Nov 2018 11:07:25 -0800 From: "Carrillo, Erik G" To: Pavan Nikhilesh , "Jacob, Jerin" , "rsanford@akamai.com" CC: "stephen@networkplumber.org" , "dev@dpdk.org" Thread-Topic: [PATCH 0/3] new software event timer adapter Thread-Index: AQHUiH4EmmPO1+getkSxz7zqeCcwIaVorigg Date: Fri, 30 Nov 2018 19:07:25 +0000 Message-ID: References: <1543534514-183766-1-git-send-email-erik.g.carrillo@intel.com> <20181130072610.GA26551@ltp-pvn> In-Reply-To: <20181130072610.GA26551@ltp-pvn> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGZmZWIxMmEtNDdjMy00NWQ5LThiYzItZTUxM2MyNzVlZjAxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUGdyVStrZ2ppQ0tpVTRUcklkdlc1eGxyT0pJVllxS0xLemViaUNjUTdySWVnK2lIZmdKN29mS3BLZE0zNFwvTHoifQ== x-ctpclassification: CTP_NT x-originating-ip: [10.1.200.106] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 0/3] new software event timer adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Nov 2018 19:07:27 -0000 Hi Pavan, Thanks for the feedback. Response inline: > -----Original Message----- > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com] > Sent: Friday, November 30, 2018 1:26 AM > To: Carrillo, Erik G ; Jacob, Jerin > ; rsanford@akamai.com > Cc: stephen@networkplumber.org; dev@dpdk.org > Subject: Re: [PATCH 0/3] new software event timer adapter >=20 > Hi Eric, >=20 > I think we may need to address the librte_timer and event_timer patches i= n > separate series as we are modifying common code for the sake of > sw_event_timer PMD and the series title implies that only the PMD has bee= n > modified. >=20 > Also, I think we need to profile and report the performance regression > (timer_perf_autotest,) if any of the rte_timer library with the new patch= es > as it is also used as a standalone library. >=20 Makes sense. I'll separate the series and check for a performance regressi= on=20 in the timer library for the next iteration. Thanks, Erik > On Thu, Nov 29, 2018 at 05:35:11PM -0600, Erik Gabriel Carrillo wrote: > > This patch series introduces a new version of the event timer adapter > > software PMD [1]. In the original design, timer event producer lcores > > in the primary and secondary processes enqueued event timers into a > > ring, and a service core in the primary process dequeued them and > > processed them further. To improve performance, this version does > > away with the ring and lets the lcores in both primary and secondary > > processes insert timers into directly into the timer skiplist data > > structures; the service core directly accesses the lists as well. > > To achieve this, however, modifications to the timer library [2] are > > required to enable the timer skiplists to be created and accessed in > > shared memory. New APIs are introduced in the timer library to enable > > selecting from multiple instances of the timer skiplists. Instances of > > the event timer adapter, as well as the original APIs of the timer > > library, can then each access distinct timer lists. > > > > Future versions of this series will hopefully improve the names used > > for the data structures and APIs in the timer library. > > > > This series depends on the following patch: > > https://patches.dpdk.org/patch/48417/ > > > > [1] https://doc.dpdk.org/guides/prog_guide/event_timer_adapter.html > > [2] https://doc.dpdk.org/guides/prog_guide/timer_lib.html > > > > Erik Gabriel Carrillo (3): > > timer: allow timer management in shared memory > > timer: add function to stop all timers in a list > > eventdev: add new software event timer adapter > > > > lib/librte_eventdev/rte_event_timer_adapter.c | 687 +++++++++++------- > -------- > > lib/librte_timer/Makefile | 1 + > > lib/librte_timer/rte_timer.c | 579 ++++++++++++++++++= ---- > > lib/librte_timer/rte_timer.h | 200 +++++++- > > lib/librte_timer/rte_timer_version.map | 22 +- > > 5 files changed, 972 insertions(+), 517 deletions(-) > > > > -- > > 2.6.4 > >