From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 796E22BF2; Tue, 5 Mar 2019 23:41:53 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Mar 2019 14:41:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,445,1544515200"; d="scan'208";a="121284195" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga006.jf.intel.com with ESMTP; 05 Mar 2019 14:41:52 -0800 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 5 Mar 2019 14:41:51 -0800 Received: from fmsmsx115.amr.corp.intel.com ([169.254.4.119]) by fmsmsx116.amr.corp.intel.com ([169.254.2.2]) with mapi id 14.03.0415.000; Tue, 5 Mar 2019 14:41:50 -0800 From: "Carrillo, Erik G" To: "rsanford@akamai.com" CC: "dev@dpdk.org" , "techboard@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 0/2] Timer library changes Thread-Index: AQHUkzMJvS49N+XKUUSapNqGtbhbKaX+GovQ Date: Tue, 5 Mar 2019 22:41:50 +0000 Message-ID: References: <1544205180-31546-1-git-send-email-erik.g.carrillo@intel.com> <1544739996-26011-1-git-send-email-erik.g.carrillo@intel.com> In-Reply-To: <1544739996-26011-1-git-send-email-erik.g.carrillo@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWYxZmEzMGQtY2YyMS00YjhhLWFjNWMtNzM2MTM3Yjc0YjgwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTURjRnBHQ05ySjByNFwvbXZ6SzZxYkp4dnZFWE5pRzl3WnJDWnlkVWJNekM5bUdqSEtYSTRBRksyNGZ4R3hKZGIifQ== x-ctpclassification: CTP_NT x-originating-ip: [10.1.200.106] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 0/2] Timer library changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Mar 2019 22:41:54 -0000 Hi all, I'd like to bring this patch proposal up again and see if I can get any mor= e feedback from the maintainer or others. I need to update the map file to reflect the next release, so I'll add thos= e changes in if any other modifications are suggested. Thanks, Erik ML: https://mails.dpdk.org/archives/dev/2018-December/120864.html Patchwork: https://patches.dpdk.org/project/dpdk/list/?series=3D2767 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Erik Gabriel Carrill= o > Sent: Thursday, December 13, 2018 4:27 PM > To: rsanford@akamai.com > Cc: stephen@networkplumber.org; jerin.jacob@caviumnetworks.com; > pbhagavatula@caviumnetworks.com; dev@dpdk.org > Subject: [dpdk-dev] [PATCH v3 0/2] Timer library changes >=20 > This patch series modifies the timer library in such a way that structure= s that > used to be statically allocated in a process's data segment are now alloc= ated > in shared memory. As these structures contain lists of timers, new APIs = are > introduced that allow a caller to specify the particular structure instan= ce into > which a timer should be inserted or from which a timer should be removed. > This enables primary and secondary processes to modify the same timer lis= t, > which enables some multi-process use cases that were not previously > possible; e.g. a secondary process can start a timer whose expiration is > detected in a primary process running a new flavor of timer_manage(). >=20 > The original library API is mostly unchanged, though implementations are > updated to call into newly added functions with a default structure insta= nce > ID that provides the original behavior. New functions are introduced to > enable applications to allocate structure instances to house timer lists,= and to > reference them with an identifier when starting and stopping timers, and > finally, to manage the timer lists referenced with an identifier. >=20 > My initial performance testing with the "timer_perf_autotest" test shows = no > performance regression or improvement, and inspection of the generated > optimized code shows that the extra function call gets inlined in the fun= ctions > that now have an extra function call. >=20 > Depends on: https://patches.dpdk.org/patch/48417/ >=20 > Changes in v3: > - remove C++ style comment in first patch in series (Stephen) >=20 > Changes in v2: > - split these changes out into their own series > - version the symbols where the existing ABI was updated, and > provide alternate implementation with behavior equivalent to original > behavior. Validated ABI compatibility with validate-abi.sh > - refactor changes to simplify patches >=20 > Erik Gabriel Carrillo (2): > timer: allow timer management in shared memory > timer: add function to stop all timers in a list >=20 > lib/librte_timer/Makefile | 1 + > lib/librte_timer/rte_timer.c | 558 > ++++++++++++++++++++++++++++++--- > lib/librte_timer/rte_timer.h | 258 ++++++++++++++- > lib/librte_timer/rte_timer_version.map | 23 ++ > 4 files changed, 795 insertions(+), 45 deletions(-) >=20 > -- > 2.6.4