From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <erik.g.carrillo@intel.com>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
by dpdk.org (Postfix) with ESMTP id B5B793977
for <dev@dpdk.org>; Thu, 9 May 2019 23:19:27 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga001.jf.intel.com ([10.7.209.18])
by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
09 May 2019 14:19:26 -0700
X-ExtLoop1: 1
Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203])
by orsmga001.jf.intel.com with ESMTP; 09 May 2019 14:19:26 -0700
Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by
FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS)
id 14.3.408.0; Thu, 9 May 2019 14:19:26 -0700
Received: from fmsmsx115.amr.corp.intel.com ([169.254.4.68]) by
fmsmsx117.amr.corp.intel.com ([169.254.3.26]) with mapi id 14.03.0415.000;
Thu, 9 May 2019 14:19:25 -0700
From: "Carrillo, Erik G" <erik.g.carrillo@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
CC: "Burakov, Anatoly" <anatoly.burakov@intel.com>, "rsanford@akamai.com"
<rsanford@akamai.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH v2] timer: allow first subsystem init from secondary
Thread-Index: AQHVBqCfSlnHvdjvQES/JSTw6J1eL6ZjNvgAgAB4OAD//4sbQA==
Date: Thu, 9 May 2019 21:19:25 +0000
Message-ID: <BE54F058557D9A4FAC1D84E2FC6D875723407B8A@fmsmsx115.amr.corp.intel.com>
References: <1557353861-31997-1-git-send-email-erik.g.carrillo@intel.com>
<7268235.EfLeTirqVG@xps>
<BE54F058557D9A4FAC1D84E2FC6D875723407ADF@fmsmsx115.amr.corp.intel.com>
<5432120.ZjB8uZtkDB@xps>
In-Reply-To: <5432120.ZjB8uZtkDB@xps>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
dlp-product: dlpe-windows
dlp-version: 11.0.600.7
dlp-reaction: no-action
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTY0NjIwZWMtZmIzMS00MGQ5LWJiMjQtM2JhZjM5NzdhZjcyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiM0xiKzJmOUJrTjZlUFI1UVhmbkYyVlR1TEFSUDlPQWxBZlZnREZEM2lsWVVJdWljRHY5ek9DbzNCTVd4M0RFVyJ9
x-ctpclassification: CTP_NT
x-originating-ip: [10.1.200.107]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2] timer: allow first subsystem init from
secondary
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 09 May 2019 21:19:28 -0000
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Thursday, May 9, 2019 3:13 PM
> To: Carrillo, Erik G <erik.g.carrillo@intel.com>
> Cc: Burakov, Anatoly <anatoly.burakov@intel.com>; rsanford@akamai.com;
> dev@dpdk.org
> Subject: Re: [PATCH v2] timer: allow first subsystem init from secondary
>=20
> 09/05/2019 22:08, Carrillo, Erik G:
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > > 09/05/2019 21:39, Erik Gabriel Carrillo:
> > > > Since memzones can be reserved from secondary processes as well as
> > > > primary processes, if the first call to the timer subsystem init
> > > > function occurs in a secondary process, we should allow it to succe=
ed.
> > > >
> > > > Fixes: c0749f7096c7 ("timer: allow management in shared memory")
> > > >
> > > > Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> > >
> > > I think this patch is too big for -rc4.
> > > And it doesn't look so critical.
> > > Do you agree to wait 19.08?
> > >
> >
> > The very last hunk of the patch should at least be applied, as it fixes=
an
> issue in the finalize() function. The rest of it is just to make sure th=
e behavior
> is the same as the prior release with respect to the secondary.
> >
> > I'd prefer if the whole patch was applied, but I can break out the last=
hunk
> for a very small patch if that's what you think we should do.
>=20
> It's a pity it comes so late.
>=20
> Can you tell how much you think it won't bring any regression?
> Are you available everyday until Monday to fix it quickly if something go=
es
> wrong?
>=20
I'm fairly sure there won't be a regression; I just did some more testing o=
n the secondary side. But I will be available to fix it if something does =
go wrong.
Thanks,
Erik
From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id 1B0B8A0096
for <public@inbox.dpdk.org>; Thu, 9 May 2019 23:19:30 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 50F1C49E0;
Thu, 9 May 2019 23:19:29 +0200 (CEST)
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
by dpdk.org (Postfix) with ESMTP id B5B793977
for <dev@dpdk.org>; Thu, 9 May 2019 23:19:27 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga001.jf.intel.com ([10.7.209.18])
by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
09 May 2019 14:19:26 -0700
X-ExtLoop1: 1
Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203])
by orsmga001.jf.intel.com with ESMTP; 09 May 2019 14:19:26 -0700
Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by
FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS)
id 14.3.408.0; Thu, 9 May 2019 14:19:26 -0700
Received: from fmsmsx115.amr.corp.intel.com ([169.254.4.68]) by
fmsmsx117.amr.corp.intel.com ([169.254.3.26]) with mapi id 14.03.0415.000;
Thu, 9 May 2019 14:19:25 -0700
From: "Carrillo, Erik G" <erik.g.carrillo@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
CC: "Burakov, Anatoly" <anatoly.burakov@intel.com>, "rsanford@akamai.com"
<rsanford@akamai.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH v2] timer: allow first subsystem init from secondary
Thread-Index: AQHVBqCfSlnHvdjvQES/JSTw6J1eL6ZjNvgAgAB4OAD//4sbQA==
Date: Thu, 9 May 2019 21:19:25 +0000
Message-ID:
<BE54F058557D9A4FAC1D84E2FC6D875723407B8A@fmsmsx115.amr.corp.intel.com>
References: <1557353861-31997-1-git-send-email-erik.g.carrillo@intel.com>
<7268235.EfLeTirqVG@xps>
<BE54F058557D9A4FAC1D84E2FC6D875723407ADF@fmsmsx115.amr.corp.intel.com>
<5432120.ZjB8uZtkDB@xps>
In-Reply-To: <5432120.ZjB8uZtkDB@xps>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
dlp-product: dlpe-windows
dlp-version: 11.0.600.7
dlp-reaction: no-action
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTY0NjIwZWMtZmIzMS00MGQ5LWJiMjQtM2JhZjM5NzdhZjcyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiM0xiKzJmOUJrTjZlUFI1UVhmbkYyVlR1TEFSUDlPQWxBZlZnREZEM2lsWVVJdWljRHY5ek9DbzNCTVd4M0RFVyJ9
x-ctpclassification: CTP_NT
x-originating-ip: [10.1.200.107]
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2] timer: allow first subsystem init from
secondary
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190509211925.um4OGZMNpc-Fxp7GsD1xGNtIO4nVQdmTSVSzAmmB64Q@z>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Thursday, May 9, 2019 3:13 PM
> To: Carrillo, Erik G <erik.g.carrillo@intel.com>
> Cc: Burakov, Anatoly <anatoly.burakov@intel.com>; rsanford@akamai.com;
> dev@dpdk.org
> Subject: Re: [PATCH v2] timer: allow first subsystem init from secondary
>=20
> 09/05/2019 22:08, Carrillo, Erik G:
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > > 09/05/2019 21:39, Erik Gabriel Carrillo:
> > > > Since memzones can be reserved from secondary processes as well as
> > > > primary processes, if the first call to the timer subsystem init
> > > > function occurs in a secondary process, we should allow it to succe=
ed.
> > > >
> > > > Fixes: c0749f7096c7 ("timer: allow management in shared memory")
> > > >
> > > > Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> > >
> > > I think this patch is too big for -rc4.
> > > And it doesn't look so critical.
> > > Do you agree to wait 19.08?
> > >
> >
> > The very last hunk of the patch should at least be applied, as it fixes=
an
> issue in the finalize() function. The rest of it is just to make sure th=
e behavior
> is the same as the prior release with respect to the secondary.
> >
> > I'd prefer if the whole patch was applied, but I can break out the last=
hunk
> for a very small patch if that's what you think we should do.
>=20
> It's a pity it comes so late.
>=20
> Can you tell how much you think it won't bring any regression?
> Are you available everyday until Monday to fix it quickly if something go=
es
> wrong?
>=20
I'm fairly sure there won't be a regression; I just did some more testing o=
n the secondary side. But I will be available to fix it if something does =
go wrong.
Thanks,
Erik