From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82C7F41CC8; Sat, 18 Feb 2023 07:29:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 162EE40223; Sat, 18 Feb 2023 07:29:04 +0100 (CET) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mails.dpdk.org (Postfix) with ESMTP id 7640E400EF for ; Sat, 18 Feb 2023 07:29:02 +0100 (CET) Received: by mail-wr1-f49.google.com with SMTP id c12so75260wrx.12 for ; Fri, 17 Feb 2023 22:29:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=r6VvbEDiy3cXdsRI8LgVyXK1FYtS3q1MJ70IuwFwg80=; b=FKxezFMMfRFYXf30SeJGCEAXgZcbi0fkaMyJlsfnb0D56UwfSZK9BNabwDrcJ4LglE VWGqHmUL0Y4Rdt2T2u6fw5I8GhnRg+DzOgmp1pW+m26cuwPmUpDNsCz1zcnxr53t8igm DsGigGbeuF9yqFVDsJWFvPZs0J6UWXcUiVCBoQVrYvf2zKEq4LSKHw5ow2VIjIF0v2XY RqX/E+Y5lVtE8hxOE0xP+OUn8jTEzbOhABMU0fAWF1VMhagx3mtdp0MFSBeWpu/asX3U z8RkCE2F/OcEfl4uLIYIhShVfN7pG+7cJTXpudJAoTmkCC1EGpdb228o9fXs7NNEKm/N 1FJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=r6VvbEDiy3cXdsRI8LgVyXK1FYtS3q1MJ70IuwFwg80=; b=QEE4mBLkB2+bo8oq5Y423JqmPhLShYtRPImNWQwJyp6rRVoIZSvTDwxdNIugbT1pSX ye/lQj9bVWQfHismcqh9QM5kpSX6Q0xyrhw/yVL2jgkiAjRtF9UNsoD+btesg/Z0AkA4 ipxphkQbWBHsXZmafO4kYaH9UUk6vfOgBzJ650vUeltt3TXTZ3+ylDFsmh4z1zwHq0q2 s6IzWhMNMJEP7wwvNxqcMIrdy4UlcRsV3LqqxAAygAevZCZeR+S+sospaYK5wvGQ3pSd fesGbBmZ7/k7fhhtX2W/i3BEGYq96EebNBWTgyTheQWeGBymYcW4apdhtVqmifUfRsRA OKdQ== X-Gm-Message-State: AO0yUKWFFB3rmEChlh4IKBAMsz/e6yeywRvSKSXcJVyYXtmBQIlaCKlp AaqgHbrMOFj+qhOrziag60k= X-Google-Smtp-Source: AK7set9sVoXSJjX86HsS05o3rTAmcas6YbHA0gAml0kndtzLwhSXxPfP8BbWWVMFSp7c2+qWEF5E7g== X-Received: by 2002:a5d:5191:0:b0:2c5:a6d4:1398 with SMTP id k17-20020a5d5191000000b002c5a6d41398mr4470610wrv.70.1676701741911; Fri, 17 Feb 2023 22:29:01 -0800 (PST) Received: from smtpclient.apple ([176.41.28.141]) by smtp.gmail.com with ESMTPSA id y12-20020adfe6cc000000b002c3dc4131f5sm5979324wrm.18.2023.02.17.22.28.59 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Feb 2023 22:29:01 -0800 (PST) From: Levend Sayar Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_58F10A6D-4E67-4FCB-A861-C2FB1B808EF7" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Subject: Re: [PATCH v2 1/4] net/gve: change offloading capability Date: Sat, 18 Feb 2023 09:28:48 +0300 In-Reply-To: Cc: "Guo, Junfeng" , dev@dpdk.org To: Ferruh Yigit References: <20230216181025.23485-1-levendsayar@gmail.com> X-Mailer: Apple Mail (2.3731.300.101.1.3) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --Apple-Mail=_58F10A6D-4E67-4FCB-A861-C2FB1B808EF7 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hi Ferruh, Thanks for your comments. Yes, you=E2=80=99re right. After I sent v2 of my patches, I got an error mail saying unable to = merge. New patches from Junfeng pushed to the repo for net/gve. Anyway I have done requested on patchwork and superseded these v2 patch = set. Sorry for the inconvenience. Best, Levend > On 17 Feb 2023, at 15:43, Ferruh Yigit wrote: >=20 > On 2/16/2023 6:10 PM, Levend Sayar wrote: >> Google Virtual NIC is not doing IPv4 checksummimg. >> Removed that capability from PMD. >>=20 >> Signed-off-by: Levend Sayar >> --- >> drivers/net/gve/gve_ethdev.c | 1 - >> 1 file changed, 1 deletion(-) >>=20 >> diff --git a/drivers/net/gve/gve_ethdev.c = b/drivers/net/gve/gve_ethdev.c >> index 97781f0ed3..e357f16e16 100644 >> --- a/drivers/net/gve/gve_ethdev.c >> +++ b/drivers/net/gve/gve_ethdev.c >> @@ -282,7 +282,6 @@ gve_dev_info_get(struct rte_eth_dev *dev, struct = rte_eth_dev_info *dev_info) >> dev_info->rx_offload_capa =3D 0; >> dev_info->tx_offload_capa =3D >> RTE_ETH_TX_OFFLOAD_MULTI_SEGS | >> - RTE_ETH_TX_OFFLOAD_IPV4_CKSUM | >> RTE_ETH_TX_OFFLOAD_UDP_CKSUM | >> RTE_ETH_TX_OFFLOAD_TCP_CKSUM | >> RTE_ETH_TX_OFFLOAD_SCTP_CKSUM | >=20 > Hi Levend, >=20 >=20 > there are multiple version of same patch, it is confusing for = reviewers > and maintainers. >=20 > Can you please: >=20 > - User versions tag, and keep increasing it. Like this one has v2, = which > is good, but next one sent after this doesn't have any version tag. >=20 > - Use git send-email '--in-reply-to' parameter to keep all versions in > same email thread. More details on documentation: > https://doc.dpdk.org/guides/contributing/patches.html#sending-patches >=20 > - Clean patchwork after a new version sent by marking old version > appropriately (most of times as 'superseded') > https://patches.dpdk.org/project/dpdk/list/?submitter=3D1813 >=20 >=20 > Thanks, > ferruh --Apple-Mail=_58F10A6D-4E67-4FCB-A861-C2FB1B808EF7 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
Hi = Ferruh,

Thanks for your comments.
Yes, = you=E2=80=99re right.
After I sent v2 of my patches, I got an = error mail saying unable to merge.
New patches from Junfeng = pushed to the repo for net/gve.
Anyway I have done requested = on patchwork and superseded these v2 patch set.
Sorry for the = inconvenience.

Best,
Levend
On 17 Feb 2023, at 15:43, Ferruh Yigit = <ferruh.yigit@amd.com> wrote:

On = 2/16/2023 6:10 PM, Levend Sayar wrote:
Google Virtual = NIC is not doing IPv4 checksummimg.
Removed that capability from = PMD.

Signed-off-by: Levend Sayar = <levendsayar@gmail.com>
---
drivers/net/gve/gve_ethdev.c | 1 = -
1 file changed, 1 deletion(-)

diff --git = a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c
index = 97781f0ed3..e357f16e16 100644
--- = a/drivers/net/gve/gve_ethdev.c
+++ = b/drivers/net/gve/gve_ethdev.c
@@ -282,7 +282,6 @@ = gve_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info = *dev_info)
dev_info->rx_offload_capa =3D 0;
= dev_info->tx_offload_capa =3D
= RTE_ETH_TX_OFFLOAD_MULTI_SEGS |
- = RTE_ETH_TX_OFFLOAD_IPV4_CKSUM |
RTE_ETH_TX_OFFLOAD_UDP_CKSUM = |
= = RTE_ETH_TX_OFFLOAD_TCP_CKSUM |
= RTE_ETH_TX_OFFLOAD_SCTP_CKSUM |

Hi Levend,


there = are multiple version of same patch, it is confusing for = reviewers
and = maintainers.

Can you = please:

- User versions tag, and = keep increasing it. Like this one has v2, which
is good, but next one sent after this = doesn't have any version tag.

- Use = git send-email '--in-reply-to' parameter to keep all versions = in
same email thread. More = details on documentation:
https://doc.dpdk.org/guides/contributing/patches.html#sending-patche= s

- Clean patchwork after = a new version sent by marking old version
appropriately (most of times as 'superseded')
https://patches.dpdk.org/project/dpdk/list/?submitter=3D1813


Thanks,
ferruh

= = --Apple-Mail=_58F10A6D-4E67-4FCB-A861-C2FB1B808EF7--