[dpdk-dev] Pktgen rate issue

[dpdk-dev] Pktgen rate issue

[Iñaki Murillo]

Hello

I have been using pktgen for a while and I released that there is no 
possibility to set a rate between  two whole numbers.

  I looked up the source code and I found out that the rate is stored in 
a uint8_t. So, I made a quick-and-dirty change just to check if it is 
possible to get a speed between two hole numbers. It seemed to work 
properly.

  Is there a reason to use an uint8_t instead of a float, for example?

Thank you,

Iñaki Murillo

Re: [dpdk-dev] Pktgen rate issue

[Wiles, Keith]

>Hello
>
>I have been using pktgen for a while and I released that there is no 
>possibility to set a rate between  two whole numbers.
>
>  I looked up the source code and I found out that the rate is stored in 
>a uint8_t. So, I made a quick-and-dirty change just to check if it is 
>possible to get a speed between two hole numbers. It seemed to work 
>properly.
>
>  Is there a reason to use an uint8_t instead of a float, for example?

The uint8_t was easier then using floats :-)

If you have a patch for this change please send it along and I will look at adding the support.

>
>Thank you,
>
>Iñaki Murillo
>


Regards,
Keith

Re: [dpdk-dev] Pktgen rate issue

[Iñaki Murillo]

Hello Keith,

I have done a patch to the pktgen, but I not sure how to submit it. I 
would be very grateful if you give me some advice on how to contribute.

Thank you,

     Iñaki Murillo

El 12/04/16 a las 14:55, Wiles, Keith escribió:
>> Hello
>>
>> I have been using pktgen for a while and I released that there is no
>> possibility to set a rate between  two whole numbers.
>>
>>   I looked up the source code and I found out that the rate is stored in
>> a uint8_t. So, I made a quick-and-dirty change just to check if it is
>> possible to get a speed between two hole numbers. It seemed to work
>> properly.
>>
>>   Is there a reason to use an uint8_t instead of a float, for example?
> The uint8_t was easier then using floats :-)
>
> If you have a patch for this change please send it along and I will look at adding the support.
>
>> Thank you,
>>
>> Iñaki Murillo
>>
>
> Regards,
> Keith
>
>
>
>

Re: [dpdk-dev] Pktgen rate issue

[Wiles, Keith]

>Hello Keith,
>
>I have done a patch to the pktgen, but I not sure how to submit it. I 
>would be very grateful if you give me some advice on how to contribute.

Please have a look at the DPDK.org page on development : http://dpdk.org/dev

You could send me the patch on the current Pktgen and I can review the changes.

>
>Thank you,
>
>     Iñaki Murillo
>
>El 12/04/16 a las 14:55, Wiles, Keith escribió:
>>> Hello
>>>
>>> I have been using pktgen for a while and I released that there is no
>>> possibility to set a rate between  two whole numbers.
>>>
>>>   I looked up the source code and I found out that the rate is stored in
>>> a uint8_t. So, I made a quick-and-dirty change just to check if it is
>>> possible to get a speed between two hole numbers. It seemed to work
>>> properly.
>>>
>>>   Is there a reason to use an uint8_t instead of a float, for example?
>> The uint8_t was easier then using floats :-)
>>
>> If you have a patch for this change please send it along and I will look at adding the support.
>>
>>> Thank you,
>>>
>>> Iñaki Murillo
>>>
>>
>> Regards,
>> Keith
>>
>>
>>
>>
>
>


Regards,
Keith

Re: [dpdk-dev] Pktgen rate issue

[Iñaki Murillo]

Hello Keith,

I sent the patch as it is described in http://dpdk.org/dev but I got 
confused and I did not put that it was a patch for Pktgen. I hope it 
does not make anyone get confused.

Thank you,

     Iñaki Murillo

El 21/04/16 a las 16:28, Wiles, Keith escribió:
>> Hello Keith,
>>
>> I have done a patch to the pktgen, but I not sure how to submit it. I
>> would be very grateful if you give me some advice on how to contribute.
> Please have a look at the DPDK.org page on development : http://dpdk.org/dev
>
> You could send me the patch on the current Pktgen and I can review the changes.
>
>> Thank you,
>>
>>      Iñaki Murillo
>>
>> El 12/04/16 a las 14:55, Wiles, Keith escribió:
>>>> Hello
>>>>
>>>> I have been using pktgen for a while and I released that there is no
>>>> possibility to set a rate between  two whole numbers.
>>>>
>>>>    I looked up the source code and I found out that the rate is stored in
>>>> a uint8_t. So, I made a quick-and-dirty change just to check if it is
>>>> possible to get a speed between two hole numbers. It seemed to work
>>>> properly.
>>>>
>>>>    Is there a reason to use an uint8_t instead of a float, for example?
>>> The uint8_t was easier then using floats :-)
>>>
>>> If you have a patch for this change please send it along and I will look at adding the support.
>>>
>>>> Thank you,
>>>>
>>>> Iñaki Murillo
>>>>
>>> Regards,
>>> Keith
>>>
>>>
>>>
>>>
>>
>
> Regards,
> Keith
>
>
>
>