From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13F4EA0C45; Mon, 13 Sep 2021 16:09:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E58B740E28; Mon, 13 Sep 2021 16:09:48 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id E097F40E28 for ; Mon, 13 Sep 2021 16:09:47 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10105"; a="208786010" X-IronPort-AV: E=Sophos;i="5.85,290,1624345200"; d="scan'208";a="208786010" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2021 07:09:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,290,1624345200"; d="scan'208";a="471566393" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga007.jf.intel.com with ESMTP; 13 Sep 2021 07:09:46 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 13 Sep 2021 07:09:46 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 13 Sep 2021 07:09:45 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 13 Sep 2021 07:09:45 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 13 Sep 2021 07:09:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GS1ZNnRAo00G+8lko0+PWp3mWd5f8ZhS5tFebO+vg7/bGdZfHgyJDf+hQD59vADIIknksAfOivGEDHuLXGCONsCbcX7wRU6AoEBm75i8xn7loZgUbyWTbMDAQyzH4ctyIVY7P+XQ7NkzxnlLlwLezRfQ2J1E7MCTvJmwSIND4mG2Hp0uPFHNjySrAvY8R7wO4mz8geolly4zmq8Bm3P1cP0IQ92g6zg9MGrfdyv5Jrsoim9dKPQFDQGg8f/KqcPNMjo9l1nz/vMGIaF9BtOSvpOuz4BLN5Da/1+fWBMTABhxuzhfQv/poQatq/ppJw8M3Z/wrqve7J3sgwHN3VWvWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=iTWs+yJdhhaxW34VFq5ergZ9IIId27P77/ilqYQStME=; b=T8dbit4NK4K3rc6eljcfeuBqNqmwn+e3ZLCkUQnmsr7Ia/yk0h4rnd/FRt2QpX8q4xGL2WNWhaV1tfc4Vx57zxxHDQ9JeMQdNnOwp272viRbCbzoZDPIlF85hl/t/RimGwHarQEIkVZzp9Gg9UJ6mzvZQk+KZbNpVgIG2Nhj7VqAJycIzRXjNffCAsMWAq6zLWTfTY6JCVA1+W4mQ//7k1YHpY6QEIdPNaq9aUvZuxYwwYQmgIQrYiy41GkAiv/xl8KXbweRK8SMM0tFOG3i0CQ3Mzk/xMIek0z6qrDvPPagP/RGk904FdwSOspbfn0LvUgtHx0GEnsoYMWfXyl2tg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iTWs+yJdhhaxW34VFq5ergZ9IIId27P77/ilqYQStME=; b=QHPI9rtpxP1pcxlSdMzRtf8uG9pQdKi6MfHRqLrCyEECY7EuMkDFKR1/BUb0EJGVHy166RpQm9sEC1wlC4WDeClScxIGJxFwCfpFP6DTOOqnQYxjsfE3IA6+9VTckEHv5Ajp7JNR1t9B2jsz754qjdAhwMkSQOMo1HmH9uWzrAA= Received: from BL0PR11MB3043.namprd11.prod.outlook.com (2603:10b6:208:33::19) by BL1PR11MB5237.namprd11.prod.outlook.com (2603:10b6:208:310::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.16; Mon, 13 Sep 2021 14:09:41 +0000 Received: from BL0PR11MB3043.namprd11.prod.outlook.com ([fe80::216d:c732:345c:3a00]) by BL0PR11MB3043.namprd11.prod.outlook.com ([fe80::216d:c732:345c:3a00%6]) with mapi id 15.20.4500.019; Mon, 13 Sep 2021 14:09:41 +0000 From: "Zhang, Roy Fan" To: Akhil Goyal , "dev@dpdk.org" CC: "anoobj@marvell.com" , "Nicolau, Radu" , "Doherty, Declan" , "hemant.agrawal@nxp.com" , "matan@nvidia.com" , "Ananyev, Konstantin" , "thomas@monjalon.net" , "asomalap@amd.com" , "ruifeng.wang@arm.com" , "ajit.khaparde@broadcom.com" , "De Lara Guarch, Pablo" , "Trahe, Fiona" , "adwivedi@marvell.com" , "michaelsh@marvell.com" , "rnagadheeraj@marvell.com" , "jianjay.zhou@huawei.com" , "jerinj@marvell.com" Thread-Topic: [PATCH 0/8] cryptodev: hide internal strutures Thread-Index: AQHXnNSw7RY8aWzsZk2MW06cN5evJKuiGAhQ Date: Mon, 13 Sep 2021 14:09:41 +0000 Message-ID: References: <20210829125139.2173235-1-gakhil@marvell.com> In-Reply-To: <20210829125139.2173235-1-gakhil@marvell.com> Accept-Language: zh-Hans-HK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.0.76 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a64eeec1-a2b0-4ae6-2fcd-08d976c02161 x-ms-traffictypediagnostic: BL1PR11MB5237: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PkA4u1pfE+sbFP5N4e1O3wyBp393utVgKvYJqI8zpQDFtYesyg97AFihDKhrjlj5q7oj0O8gJkzkXgEfFoQxNinMkfnvhaXwKoR18qRSF8p4kTk4paWWyzMZR9pC+bUbX2qJQGFItpvXNwpE6MqfgWLSz3A29q8SRKWl04F8CPNMZa9mXRUT4jXop/geSfW/RbQNSemMtsGg/MrvXG5UUyVUbvYc89UonUb3lhuRI2kZtcycXEqghOaMaqGcLwdQb+iWEo1CQ9hDGbCtuxWTl7B+JesVAaUhRiN3CsUZ3hOe+CiXeTLBZ7UPbNA44AcpDrf5xiHl0gnbQN9BxJcheMyqfj011DG1TV1eSKHw4xbdWcKvRV9PSROmC+kVdeIdnWMlDlfa8hu//Cos0q/j/yJHumLHJXJ4FSWl7qPpj6IamCvxqJw6kQoo3QmYAYITBKcl92+GpAX1+M2A8K63Db2oYCMDbQBL10iHfksPVR/QsAOHt1+B/Jd0jxdHGxz49VZSvZdyvyltBVZqrUkjQxG4v+FAb0tkOlSNrU8kl/+9BrSeLyCJxOvUrvUrpgn76ZFoM27LHfJ9JyW0hcr7yDFB6Cqf7zfTrBNU4tz0nM7WYLQeTyuF8pVgWXSKyKN5d7DjjBo39MpLITst9KCW1h/8taCQn2npxnzVLFK3/nah5G2f6S0/15jWJMpMTJKHYZGr4kNQNPzti9tc+4Wjn9gZ4WSa6Eb91En5E6DoROYpC4ZaQXasOGdtl/g4jERB1MXrszxyPSmht2p2VIi9+Ufp9mHm1lVr6FUJGjvBFdeSfqg5uKe5S+iXwI2aAs9OIQg/Ej1H/qhERNSqMLm/8A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR11MB3043.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(366004)(39860400002)(376002)(396003)(136003)(2906002)(8676002)(7696005)(26005)(33656002)(9686003)(4326008)(55016002)(38100700002)(7416002)(122000001)(76116006)(66476007)(53546011)(66446008)(64756008)(66556008)(186003)(38070700005)(66946007)(83380400001)(6506007)(316002)(966005)(71200400001)(86362001)(8936002)(110136005)(54906003)(478600001)(52536014)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?jXk1qsPBtS4cULT5U84lmbM7CvNT9VkOlTdCHpsC9XnOSNFeKOI4YlPP?= =?Windows-1252?Q?vn5V8IIr8h1OFcRuKDTUP1KHpi7ztK6/raFzlAHqk2/Z3iDLqkthMgc9?= =?Windows-1252?Q?ziXlNovfjip/lvfvOZakyRji67P2XlUir2KXS50s7KzGxGzEk2+qW/c0?= =?Windows-1252?Q?XgDx8HouFSmEJj3bpbF6O6kKJFgF+tKP2lUq84IxHPVRnonuVG7pv6Uh?= =?Windows-1252?Q?/6VCsA9l2joWgKy70RK/Nm4BcS7xzGe+Jk0D9QXKy5LRqmcd8R1OLaB+?= =?Windows-1252?Q?QnLLbs58ZbFtBq2MKCS7/R2bvpiBMwDn0jTeAgaIo2VvFkGk653RgB8O?= =?Windows-1252?Q?f3+HjrCFvWsZZNZCWMfE3yB0bV3hkAgPdWJQSKUtRGtzrhhNdVjO1b3/?= =?Windows-1252?Q?eXCOAkAs4IXxFPLe914OoXP2IpdzrTkjf3CBbD91mCnHrNhpV5aSvcxz?= =?Windows-1252?Q?JZmhx573SRGIY1vcsKarOv5C4LWPjMoHQdojXgvQyXlDuD7DQwsiXkEm?= =?Windows-1252?Q?59E+kVDyHiJ9QLCb+K1v89sDA/I5ZeTa9O24svkJ1IA3YQk/Vb9Kigcv?= =?Windows-1252?Q?VpasOTE6dUYExEx2pMr0yavT3Nf5JUDxuKIZflREtFNU5PKd59ztInyq?= =?Windows-1252?Q?Pc/5JXWX8SViFlKucYl1/Zo3NqFiiI25zmvedoFgNdDKndQeXAgUtATf?= =?Windows-1252?Q?efg25CUSEPzMngbEBWqUqFY5hfEiLBTotXRc/KjNEmy6hJ+d4dcsk2Je?= =?Windows-1252?Q?ikbVUQ/NKo2amx3ctCkdld6swTwq8b8FW9969ZGzxUAPh4Y3dg6C0w9p?= =?Windows-1252?Q?iGtzrE0l1V/Lgd95wyEnVd0sUL6k7poWopdhBD9KutQBNTcotiXhp3oZ?= =?Windows-1252?Q?Gh1dLHZv9uMY6ESi0nXmgoHinFDAOaNvVOw7FzPrC/qy8U6Skfs+0Mq6?= =?Windows-1252?Q?8OnQvkuKwnaxjxurmmJzSLarkb4Xmusb8jnPM5DiQWqq+BtJWI/k10Ef?= =?Windows-1252?Q?VD+iqwbMMXEGIYJG/4bDytrfr76zrZ9h/1CvyYyp6LKXAm9IcA57fbEr?= =?Windows-1252?Q?/SePPzzTib98o+G8CuRtuSUZ1yZfZgli5in1FxcdhtVabSpJTsbo9wzi?= =?Windows-1252?Q?qptAuv2SHVnznRcuudT6jE+idMi06LlUExsuyBWEHlOkjcakOZbQ8Lud?= =?Windows-1252?Q?WhH4cdz0okMfoX29SB4Ht/74LHBwg6cHSB5QoYntpQt1yY5JgH5ty+kB?= =?Windows-1252?Q?ifETurrQfJ7pX/INZnzkWJwVzIkpc5RNCwFe77Rw5psT9Z96yYtv92ko?= =?Windows-1252?Q?9RsxEk+oNtO3uMJItd3VFNo41uXDg6qJIMukktQBVXVJpNsowicTWb7H?= =?Windows-1252?Q?N2QH97Y9grcOkGRG/b0ww92aM2M+D7m4JmiORF+UN2VH+kOnCGWC6icl?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3043.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a64eeec1-a2b0-4ae6-2fcd-08d976c02161 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Sep 2021 14:09:41.4172 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lPPwyb5lHyVIq/iC194FfmM4bYRwdNjptPUepeMGf7RJ7ehK2SADYNhT2QSKhhW+IOQj+iu+8olUZbHjsY3LcQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5237 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 0/8] cryptodev: hide internal strutures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Akhil Goyal > Sent: Sunday, August 29, 2021 1:52 PM > To: dev@dpdk.org > Cc: anoobj@marvell.com; Nicolau, Radu ; Doherty, > Declan ; hemant.agrawal@nxp.com; > matan@nvidia.com; Ananyev, Konstantin ; > thomas@monjalon.net; Zhang, Roy Fan ; > asomalap@amd.com; ruifeng.wang@arm.com; > ajit.khaparde@broadcom.com; De Lara Guarch, Pablo > ; Trahe, Fiona ; > adwivedi@marvell.com; michaelsh@marvell.com; > rnagadheeraj@marvell.com; jianjay.zhou@huawei.com; jerinj@marvell.com; > Akhil Goyal > Subject: [PATCH 0/8] cryptodev: hide internal strutures >=20 > Structures rte_cryptodev and rte_cryptodev_data are not > supposed to be directly used by the application. These > are made public as they are used by inline datapath > public APIs. > This patchset, creates a new rte_cryptodev_core.h file > which helps in defining a data structure to hold datapath > APIs in a flat array based on the device identifier which > is filled by the PMD. > The patchset updates all crypto PMDs to use the new > framework and hence the internal structs are made hidden. >=20 > Similar series for ethdev and eventdev are also floated on ML. > http://patches.dpdk.org/project/dpdk/list/?series=3D18382 > http://patches.dpdk.org/project/dpdk/list/?series=3D18422 >=20 >=20 > Akhil Goyal (8): > cryptodev: separate out internal structures > cryptodev: move inline APIs into separate structure > cryptodev: add helper functions for new datapath interface > cryptodev: use new API for datapath functions > drivers/crypto: use new framework for datapath > crypto/scheduler: rename enq-deq functions > crypto/scheduler: update for new datapath framework > cryptodev: move device specific structures >=20 > drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 10 +- > drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 11 +- > drivers/crypto/armv8/rte_armv8_pmd.c | 11 +- > drivers/crypto/bcmfs/bcmfs_sym_pmd.c | 11 +- > drivers/crypto/caam_jr/caam_jr.c | 11 +- > drivers/crypto/ccp/ccp_dev.c | 1 + > drivers/crypto/ccp/rte_ccp_pmd.c | 11 +- > drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 8 +- > drivers/crypto/cnxk/cn10k_cryptodev_ops.h | 3 + > drivers/crypto/cnxk/cn10k_ipsec.c | 1 + > drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 9 +- > drivers/crypto/cnxk/cn9k_cryptodev_ops.h | 3 + > .../crypto/cnxk/cnxk_cryptodev_capabilities.c | 1 + > drivers/crypto/cnxk/cnxk_cryptodev_sec.c | 1 + > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 12 +- > drivers/crypto/dpaa_sec/dpaa_sec.c | 11 +- > drivers/crypto/kasumi/rte_kasumi_pmd.c | 11 +- > drivers/crypto/mlx5/mlx5_crypto.c | 11 +- > drivers/crypto/mvsam/rte_mrvl_pmd.c | 11 +- > drivers/crypto/nitrox/nitrox_sym.c | 11 +- > drivers/crypto/nitrox/nitrox_sym_reqmgr.c | 1 + > drivers/crypto/null/null_crypto_pmd.c | 11 +- > .../crypto/octeontx/otx_cryptodev_hw_access.c | 1 + > drivers/crypto/octeontx/otx_cryptodev_ops.c | 16 +- > drivers/crypto/octeontx/otx_cryptodev_ops.h | 5 + > .../crypto/octeontx2/otx2_cryptodev_mbox.c | 1 + > drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 11 +- > drivers/crypto/openssl/rte_openssl_pmd.c | 11 +- > drivers/crypto/qat/qat_asym_pmd.c | 11 +- > drivers/crypto/qat/qat_sym_pmd.c | 10 +- > drivers/crypto/scheduler/scheduler_failover.c | 35 +- > .../crypto/scheduler/scheduler_multicore.c | 32 +- > .../scheduler/scheduler_pkt_size_distr.c | 34 +- > .../crypto/scheduler/scheduler_roundrobin.c | 34 +- > drivers/crypto/snow3g/rte_snow3g_pmd.c | 11 +- > drivers/crypto/virtio/virtio_cryptodev.c | 10 +- > drivers/crypto/virtio/virtio_cryptodev.h | 2 + > drivers/crypto/virtio/virtio_rxtx.c | 2 + > drivers/crypto/zuc/rte_zuc_pmd.c | 11 +- > lib/cryptodev/cryptodev_pmd.c | 33 ++ > lib/cryptodev/cryptodev_pmd.h | 323 +++++++++++++++++- > lib/cryptodev/meson.build | 4 +- > lib/cryptodev/rte_cryptodev.c | 43 ++- > lib/cryptodev/rte_cryptodev.h | 308 +++++------------ > lib/cryptodev/rte_cryptodev_core.h | 43 +++ > lib/cryptodev/version.map | 8 + > 46 files changed, 854 insertions(+), 316 deletions(-) > create mode 100644 lib/cryptodev/rte_cryptodev_core.h >=20 > -- > 2.25.1 Series-tested-by: Rebecca Troy Series-acked-by: Fan Zhang