From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9656A0A0E; Mon, 10 May 2021 13:41:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 41DAE40140; Mon, 10 May 2021 13:41:57 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 11B3B4003E for ; Mon, 10 May 2021 13:41:54 +0200 (CEST) IronPort-SDR: cGlWjibrxll0XXaT4loRi/OwsG4Wd6n7Aib8PXvtW2W3HGT4cjW3xZFP+LjNslKFLAkO+dG0DB pLISrEpfb9iQ== X-IronPort-AV: E=McAfee;i="6200,9189,9979"; a="186620914" X-IronPort-AV: E=Sophos;i="5.82,287,1613462400"; d="scan'208";a="186620914" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2021 04:41:53 -0700 IronPort-SDR: PtZR1FUcf47gSRKOKpxQkQqZds/EZzCyS6J8ABb5JSQ5eZI+2i+2XUKnk4YTL6WRvJUJZUQd2a NQZ8fQ9jzDmA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,287,1613462400"; d="scan'208";a="436108885" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga008.jf.intel.com with ESMTP; 10 May 2021 04:41:53 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 10 May 2021 04:41:52 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 10 May 2021 04:41:52 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Mon, 10 May 2021 04:41:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W9hBu9cgSIGyNguDynSj3dYsChe/vNfeTTVdHNBdfcLSYTHCFJvOwIcH40w5Y+QCln98WOp7RtdVEp/56WO34cfleqeeaFMKDaoGNSC0PfLYSL0ieQ5g26ozSsV/v4Cr/lcPv2J7BxvboTBqulyQ3vUA5njj+D+BQpwGYNr1ZgaSiLI6y3X4cH0OlbW8I7+zCs6qcpnNJsvQ6YQg7cjUBt4N+pNxgGJajg/MMKmzLTF7IUo/h11pJ+COAsbenfBL6uSrTh07MlpuC7nJq19OyDGtEnlbPnNhvJEArfhalLNUleO7WU/wLPPI0FZQqpC5uLFU4XyyldguIqm1rjtdxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1iNxjAmuUU4pnTfAKAqgPj3KZJm6VY3I4VYpxeGNUWs=; b=dQULEsKyvnh/GuhW8wOYHFgL3gYShKCn1PvLWDZPeR4IwTNiqz0OxD0iisw1imY2KxcdpmcFgtQbNedRLM9SDimsUcsbHFYc5YFqHE2irnSgoXLf3fCt5wKvONS17wDVwNXAuv2lE+GECIZaSb2Y8iRXxhKyVA069lI7HAtBJ/fmj6bcgz0+/YbCKzqaKzOKIKEWxKQ55ecS8YnIREfzT01UwykZQNLyV9hBbeLt63G5XqQk2pqpmkqeunzmAfaJcqDlxIKeATAhBa7VYfe/Ww6Fc0q9eWdkpUOlUuL2zu8mFt/gPnMt/t1O4fJNBRsxVkPKWee+oxVIDcglukV39Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1iNxjAmuUU4pnTfAKAqgPj3KZJm6VY3I4VYpxeGNUWs=; b=b8f9VhPRrLoBtoA8kCrWTKzX/bv0/JhnO8blf7XfJok4RmGc7Y3hW0Nc034nwsZ23b964agt1mHIA8yHuWu0WjJpUbtJI42JpyDNNabz0SScDp6q0o0ce+IBuGPb061leLicaYF+Wfws0cCYrd+wYt3deC5ktNnld1qs/oA1FQ4= Received: from BL0PR11MB3043.namprd11.prod.outlook.com (2603:10b6:208:33::19) by MN2PR11MB4349.namprd11.prod.outlook.com (2603:10b6:208:195::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.26; Mon, 10 May 2021 11:41:49 +0000 Received: from BL0PR11MB3043.namprd11.prod.outlook.com ([fe80::65ad:d905:ad68:5b34]) by BL0PR11MB3043.namprd11.prod.outlook.com ([fe80::65ad:d905:ad68:5b34%5]) with mapi id 15.20.4108.031; Mon, 10 May 2021 11:41:49 +0000 From: "Zhang, Roy Fan" To: "Dybkowski, AdamX" , "dev@dpdk.org" , "Kusztal, ArkadiuszX" , "gakhil@marvell.com" Thread-Topic: [PATCH] crypto/qat: fix NULL authentication request Thread-Index: AQHXRYYdTCNE77KXzEeKHckFJ5aK66rcl2lg Date: Mon, 10 May 2021 11:41:49 +0000 Message-ID: References: <20210510102011.44343-1-adamx.dybkowski@intel.com> In-Reply-To: <20210510102011.44343-1-adamx.dybkowski@intel.com> Accept-Language: zh-Hans-HK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.0.76 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [95.44.220.85] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1af2d1d8-1ac8-4260-84af-08d913a89939 x-ms-traffictypediagnostic: MN2PR11MB4349: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1751; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Lks//gOvs5aSI4rkgaW8w+ouauLWukzcfIwG8NKkk0DZ+XC/gweznG55MA8WQKGVkuXT9madi16B6gAieZhdEgW9DE3rDyw02sJZMBWCuXfSdcfzcYQ978+cKYHGDyc/jZFdxD2AB5ZNKjr5AXe1lIQrIqhGd6wiAqq+9T5AQwLLRa03a4KVGF6yi7BNZsmFjiVZYo5CXo29KmCat145+cQ9ptU6QvKa7oHgDNsfU0Ke2Y1Uvt64Welj1vhPqCRhCHYO8G63VE5wcQjMnHl3I+xPQbEFnKtH/QDKG0kWoJPEwW+hoHclnSSUni1QIJ+NRcpZ+IG+yd4uMlBb+L67QoAGl7BkIWd4XoFsboGzdtJjvbk+HwglZUGAyDT3niptGNKIhBDaY0o+EmUtTE8QyWNCR1NWLeLx3gS3ZoSZRI/rt+B4gSYjtplBmMmy2LJVcDTzFyybIqem3vDtO52+dCJUDZ1zhpbxxriavBbFL7p9IEpzuG+wPeX5DQ7XMZNb+1HrAygQpRiRCqXi+DvrMiXu66hBZfGwbCKGNbjC/50/VUoG+fi1FyLh+l/S7iQth+eMKymWDmsbbSIpg1Q6o/ifZlQrMMtf0FO1c2Td0lc= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR11MB3043.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(396003)(376002)(39860400002)(366004)(136003)(346002)(83380400001)(2906002)(8936002)(8676002)(478600001)(110136005)(316002)(33656002)(66476007)(186003)(9686003)(66446008)(66946007)(76116006)(64756008)(66556008)(86362001)(5660300002)(71200400001)(55016002)(6506007)(38100700002)(26005)(53546011)(7696005)(122000001)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?Windows-1252?Q?WyM3DNNiS/NrHlcl9bIlclQfaNYp6Id0NkYv5CbdR7cyvLorYjVb+m5f?= =?Windows-1252?Q?LLk0P5ls+NF/n/q8TnkMSLtf5LwtxkL8fu6vly/68HZyUEh8OoeVWfli?= =?Windows-1252?Q?MUBq/Sjhqfuhrom3wzCF43aZHcLghEGgvAwXWQanxQEyY2wbrqR7nbTs?= =?Windows-1252?Q?i4q37IzAOZYBTyz+HfYqSsKzabFlXcfEeHGkxuOy0C2PAeufoLD8YGUY?= =?Windows-1252?Q?I+RlqlXV1lgNawAI6V7RTCYbxyWVkGfU0Ek8O5wX6j5P28oghvVyU9Nw?= =?Windows-1252?Q?EnJ9HjUtzVi9s3YL3UIaILZZn5w+QYTvM3FZgYNpgco4sPDxUr/hF19C?= =?Windows-1252?Q?JHMP82jJalc7LWY1uWI3xE16q3Dlq3Y7UXRbuOroYAzSK/MsdIYmXccV?= =?Windows-1252?Q?9fteBRyQlDK0Qo/IrV8XIyxi6cg+Qs19jrVPbQy1Cy1/zWqW1clRjXG0?= =?Windows-1252?Q?DDzjwF9m01PERSLrv4HCYjQpHORTfVGYXTSQq/32zo2XbyXwZ6/bzxWI?= =?Windows-1252?Q?ADMU7rXfpJzIQjdtjfxn1Fnz2mK8oQsuLZpq15sbs8BerQSEPXNRM0QN?= =?Windows-1252?Q?4xHP1O9mb9LWpdf6SZRR3Xn9ZwKjMke51kUJ/DrypciU+lysE5nYYGWJ?= =?Windows-1252?Q?+b19+LiG/xrqoturZmFt4v/WK78VP2jmJFWxirn7KQfY2C99XwQ47ltL?= =?Windows-1252?Q?8kzJT4X3UJo/V8TyKlpkIGMTogxzqXDBYK08ozXBC9Kr1+o5r23JzCcr?= =?Windows-1252?Q?DM8in6210xP0SAY5FQ40NLmC38JI15NaZyM9/hNgPWraTr7LlzdNavST?= =?Windows-1252?Q?pcMit1MuOVV3blWsD2E31zMOVLuh9P1KoboeOcqCHk6sSqtitybowKWR?= =?Windows-1252?Q?Iw6y44s+VZoFr+xW3clqSFesV+Zzm1ClX6vm5xLX4aHVYBZdkFhM5ATR?= =?Windows-1252?Q?bHAFipmJSrHavMsFf8hMOWSuUlCa8VB0wpb98PagWV2nydXZ4V2LCKPy?= =?Windows-1252?Q?n/IfqDE+X1Q47tVdC9FrHzfZ8kb1wxbFoWUWYsPhikZI1qyzEp7w22b9?= =?Windows-1252?Q?1kHeAcj/11Ihl3tkKZ4JnZhzU8xuhZP2K38DSYiW7N/sNKM9QJsIEK77?= =?Windows-1252?Q?GZB7ScAeY/dD2Lp/j6+soGcBfKZnRUISB0bnbEab4qx/ClWW6beMEbz5?= =?Windows-1252?Q?HshKc2egEWWnYoe3uSl+yPxqpeNnRZQPNmi1Q/ARMtI4vFpQKKu38Kgn?= =?Windows-1252?Q?JoD9YflCkezSc44v21JN1FU31Evu4FxgHkgdQk2wdip2Yq7e4km51Tc0?= =?Windows-1252?Q?SL0Am75EkMXP9dDVtK62Jop4P/5kgVOKZ3soI2YTqKuTGRP+s2TA9o4e?= =?Windows-1252?Q?gdY6AZP6iUYecbh/GyRu4lw1jtNgwPSNY4tFWBQe/n6SMQk+B72L3bru?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3043.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1af2d1d8-1ac8-4260-84af-08d913a89939 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2021 11:41:49.4423 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vzUds8PrrhJjt7wjKY2al3GB1dvjaDHAjmcif1AHqFSJwzdmPizHN8pgfjtjrwTPDbTTfqYwiWy9pQfFc6uXAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4349 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] crypto/qat: fix NULL authentication request X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Dybkowski, AdamX > Sent: Monday, May 10, 2021 11:20 AM > To: dev@dpdk.org; Zhang, Roy Fan ; Kusztal, > ArkadiuszX ; gakhil@marvell.com > Cc: Dybkowski, AdamX > Subject: [PATCH] crypto/qat: fix NULL authentication request >=20 > This patch fixes the NULL auth generation case where the request > shouldn't contain the authentication result address. Allows to run > ipsec_autotest with a QAT device. >=20 > Fixes: 65beb9abca6d ("crypto/qat: fix null auth when using VFIO") >=20 > Signed-off-by: Adam Dybkowski > --- > drivers/crypto/qat/qat_sym.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/crypto/qat/qat_sym.c b/drivers/crypto/qat/qat_sym.c > index a1f5676c04..9415ec7d32 100644 > --- a/drivers/crypto/qat/qat_sym.c > +++ b/drivers/crypto/qat/qat_sym.c > @@ -399,8 +399,10 @@ qat_sym_build_request(void *in_op, uint8_t > *out_msg, > } > min_ofs =3D auth_ofs; >=20 > - auth_param->auth_res_addr =3D > - op->sym->auth.digest.phys_addr; > + if (ctx->qat_hash_alg !=3D ICP_QAT_HW_AUTH_ALGO_NULL || > + ctx->auth_op =3D=3D > ICP_QAT_HW_AUTH_VERIFY) > + auth_param->auth_res_addr =3D > + op->sym->auth.digest.phys_addr; >=20 > } >=20 > -- > 2.25.1 Acked-by: Fan Zhang